From: Magnus Damm <magnus.damm@gmail.com>
To: Johannes Stezenbach <js@linuxtv.org>,
Magnus Damm <damm@opensource.se>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dvb_frontend: MODULE_PARM_DESC
Date: Tue, 22 Mar 2005 09:06:29 +0100 [thread overview]
Message-ID: <aec7e5c3050322000677d5f22f@mail.gmail.com> (raw)
In-Reply-To: <20050322025104.GA18067@linuxtv.org>
On Tue, 22 Mar 2005 03:51:04 +0100, Johannes Stezenbach <js@linuxtv.org> wrote:
> On Mon, Mar 21, 2005 at 05:10:27PM +0100, Magnus Damm wrote:
> > Remove "dvb_"-prefix from parameters. Without the patch all parameters except
> > the declaration of parameter "frontend_debug" have a "dvb_"-prefix.
>
> Why is that dvb_ prefix a problem?
It is no biggie and probably not worth breaking users' configuration
like you said, but most drivers do not have their KBUILD_MODNAME
included in the parameter names.
Setting parameters that have KBUILD_MODNAME as prefix from the kernel
commandline is then done by KBUILD_MODNAME.KBUILD_MODNAME_xxx and that
is plain ugly - especially when a list of parameters are generated
from the source.
Some bad citizens IMO:
dvb.dvb_shutdown_timeout, asus.asus_gid, arlan.arlan_entry_debug
> > Error detected with section2text.rb, see autoparam patch.
>
> Please only fix errors and do not rename other parameters. We shouldn't
> break users' modprobe.conf option settings.
Ok, just fixing errors: frontend_debug should be renamed to
dvb_frontend_debug or the parameter description should at least match
the parameter...
Thanks,
/ magnus
next prev parent reply other threads:[~2005-03-22 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-03-21 16:10 [PATCH] dvb_frontend: MODULE_PARM_DESC Magnus Damm
2005-03-22 2:51 ` Johannes Stezenbach
2005-03-22 8:06 ` Magnus Damm [this message]
2005-03-22 12:18 ` Johannes Stezenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aec7e5c3050322000677d5f22f@mail.gmail.com \
--to=magnus.damm@gmail.com \
--cc=damm@opensource.se \
--cc=js@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox