From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3393F2D97B9 for ; Tue, 21 Apr 2026 07:39:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776757175; cv=none; b=LtxYhnah3oQiSI1sREW2fRdG+rLg0aKzI5Ai7hV4WISezkYOG3U/ur6MCwenW24Aq+rUcUxXGj9fIahc1+nJZOm/XEcW4uj3ITM1XU9hurMUMZZyaqZSNkzjVLrg68QNtrMkUFF077m9c96zRCaB1y8ZmANmmw6T7VyXBgkS9vk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776757175; c=relaxed/simple; bh=AHVDlaiPLZGv5Nr20tU+e7aqoJ89J/Y6fybbRvNtqW0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CgbRcz2hGryXxoBFdCUFKzAc927/+Xw/mC3S1SjkFC6uBWdHVfHRpIcXtnvx3/uP888evOa3bwQ34gS79HvHtN9xRWzGDjzm6lunBPVzAY3tcbGQjzBgVmm3t1RtLYW1v2t4zLLSMcVTKXA8WdAU8oLWy99/oE6sE1oh8QlCPi0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LG3mgwLr; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BU+/u14g; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LG3mgwLr"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BU+/u14g" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63L5Me3d1015347 for ; Tue, 21 Apr 2026 07:39:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=YFMzs4xFzTFlKpkighB7F1f/ Iyfj9GNd+fbtaY4rXjA=; b=LG3mgwLriOYT87TGWJpBg3Ydwc103wi13GWbQfCY qWuNmFNj4LGx1WPFQ/9K3c/NKCA42W70t7IThEbsK5l2nache5POPYe6qCyhrbX0 I/juHrv//VoJ1algfPd1+bzgfQHkdmIL8qrVwtrvZxOcioxyvw8eLZ1rGnc1iuKq BFN1STChaGSx0QIfck6cDKzzobeAyZzkIQuD0TPMVXtJ7DfjwKhqkarj+1kGwSC0 /XvqMNUWJ6iIk3EzDJHdpB/b8dOUZC27K2o4qSiQzlNViwnuhmx8OfxEhM3TjZ/Z g5GAJ0HSAdCW5rK7Rty8H/fcgXywyfSDsrndEcD5GxFuhw== Received: from mail-dy1-f198.google.com (mail-dy1-f198.google.com [74.125.82.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dnt9023sy-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 21 Apr 2026 07:39:33 +0000 (GMT) Received: by mail-dy1-f198.google.com with SMTP id 5a478bee46e88-2de07c12745so2386665eec.1 for ; Tue, 21 Apr 2026 00:39:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776757173; x=1777361973; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=YFMzs4xFzTFlKpkighB7F1f/Iyfj9GNd+fbtaY4rXjA=; b=BU+/u14gzSVJk9CR2tEYp+a+W2abOXOXabYXcZJ4/K89dw3qtPN13bfyIxHJCNKhbX XxFPmKtCYI/n8fE/dUnsv4mUku0IPFQG2w7goETbbGfG+BUPkpBh0JLnrRa7XVKsRVqG Ow22BQsSgZWkf0bJOz/qZZjQSCb4nugemfPQPOYwmEYD2iX9K2X5yMyfqh+riYCB7eio wwvUlf/iQp9ek1FqZFX78cpd3tW0R/9ARO4zjBHR7ZFT1fFUmktbvqlJMcGRHY+aZ6V5 B1AR0FMw1ktjQSgohuDEeaiOOsbeP3NMKsSo+XrlCuj/0hkmMhFZFBiQegfl8j4vgznQ VYiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776757173; x=1777361973; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YFMzs4xFzTFlKpkighB7F1f/Iyfj9GNd+fbtaY4rXjA=; b=UlYVfhBTL8ZC0rFRSiygSIMmIfRBQnPTL8XVe9LdKuQI60Nt6IhK3z7Dex2VV05Hi0 UgnlyoEyaYaEkTTdR8MsCRCQDGdT6SrAHvthg4pqu9Tn/06zYInsQ5qcdd8fhd6BCgVs nJJ2bPUBenvpEkIm3P8n1UcykCQLB06GWpCK7yWVZ8SVySMR76gGs59jMJz5jEkepx8I ZjvTx8aUs3QjlkTuXPTZP9SUmXmV6FOJHWHkCZ2K5ZmypTRCWuwFYPHyAYlNXTMCREg1 ImG6YGNEAP7/dShkzKqFf97kn0LmSsoe4Bek/f/2nMwsHjGjR/utUeikWnLL1jb9q12E XMiw== X-Forwarded-Encrypted: i=1; AFNElJ/7SL3qEg2d1aomQ9/cHO7LFEkeRG06e13bymmkWp34fEKaHMsgQ6zxFg+rrptdkfg4Bd5pptAuN2v+YZI=@vger.kernel.org X-Gm-Message-State: AOJu0Yxhml2RLwUb8IFIf+Mptv2CiUeNjNnh4v0B3dYAQcZVt3xc8Xqs LIFcXSlMhuusJCf5EvWA3b9Ik6krwcYd2l0Qv0/Au5oPRaM/DhPe61ESMF4TxzJJqhxl44DWkpt hOr7ZqFaKop7D2P8VIM0h19ClXbsln0fmxXbkOKI4WIhu8UzlGTs40xrNzI9LcJlZpjrO6w+aib JoBw== X-Gm-Gg: AeBDievtfdXAz/tTXtGnsvVOekwudIoAEX1ns5fqkriYYWVe++80SMAnpNG3L/lUywh /DhvkJ5xxD4Al2x/IlDWocpbNoTSQhwXl4JYOBWmFN8KN1hNnVrd0MYQyYZUE5SM652fw5N7BtQ TudGjrqFaRcYwp73RsAk3OrH0TA9z7vPWR1CgxuxVK4emGEBg3Fs3UdSubQdgaCVI+MFxJGRots /F/SSVnkbzrUQS4X1lMB+UaQahPZ6AbVqIXZ6LuaFQtx/3mv3FE+3EVfKepsXc5YP0QhW4e6JjA mHTg22yAMvtkN/2dKBOCDppYMonx1/+iREe9ePNXFsz0pLrNRRHYBjN9BzzTmRkJF+kuMU0LWP7 LyIbdUj4b5ogakQNeWzZX5ulPMUbGtypsdZCwyNcJY9S1+RNR94G4Jip9bDHuYf+UjpAEu5MaBa 0= X-Received: by 2002:a05:7300:dc05:b0:2e2:d94d:6185 with SMTP id 5a478bee46e88-2e466044594mr9276957eec.4.1776757172729; Tue, 21 Apr 2026 00:39:32 -0700 (PDT) X-Received: by 2002:a05:7300:dc05:b0:2e2:d94d:6185 with SMTP id 5a478bee46e88-2e466044594mr9276946eec.4.1776757172170; Tue, 21 Apr 2026 00:39:32 -0700 (PDT) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e53dcb487bsm18275263eec.31.2026.04.21.00.39.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 00:39:31 -0700 (PDT) Date: Tue, 21 Apr 2026 15:39:26 +0800 From: Shawn Guo To: Konrad Dybcio Cc: Jassi Brar , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Dmitry Baryshkov , Bartosz Golaszewski , Deepti Jaggi , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/2] mailbox: qcom-cpucp: Add support for Nord CPUCP mailbox controller Message-ID: References: <20260420034932.1247344-1-shengchao.guo@oss.qualcomm.com> <20260420034932.1247344-3-shengchao.guo@oss.qualcomm.com> <43db2263-0dab-4652-ae1e-f827d1dc5c28@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43db2263-0dab-4652-ae1e-f827d1dc5c28@oss.qualcomm.com> X-Authority-Analysis: v=2.4 cv=KfbidwYD c=1 sm=1 tr=0 ts=69e729b5 cx=c_pps a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=kj9zAlcOel0A:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=INs1rN3GQppflMMUrBYA:9 a=CjuIK1q_8ugA:10 a=bBxd6f-gb0O0v-kibOvt:22 X-Proofpoint-ORIG-GUID: -NaFcEONAsb-XaI2Y5M2Us1lEZ2RPezX X-Proofpoint-GUID: -NaFcEONAsb-XaI2Y5M2Us1lEZ2RPezX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIxMDA3MyBTYWx0ZWRfX8T5Mg8KvW+4+ m2HhpB8S7vfYkf1awqJwB+PDiKHghE9Q40BYxiSHzWGr/jAabD1oeg0T6UOnIUVStgI84FsnWCt U0qQJ5FDN7Ngzif8dVU2CqP6QZ2WBorx1kDKBgyGHswtHM6YFHK29Yn6H7diJa7tit81wn4VOSz yp3kv/QsG+2uH0BuWWQFgAyCK/qbawXhFNhnnsQHLoDDfzJf2qaWwUwy5g8FOVQcmIYfJqepIRb ljO86GIgOoaaG8QA2ayz/XKw6mE0beASnsfQukeXHjEBnZWYCwRJkyPs7BDi1jPCJit98VaI7o1 aVJW7PmJu2fSoQfehEB6C0SX4XGmZOv4r4XYuGwr+hraurMEEW88IH0A8PymsFGAYpO4DlTh3KK IMduDz43zK5rnt3/MwO5WwErpCdPJn0GcMfyiaTLNIKDCMwzC1LoPECAK/13UTu5jgTV8lvJC9H eRBBUCSoNrGt7C3Uc3A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-21_01,2026-04-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 spamscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 impostorscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604210073 On Mon, Apr 20, 2026 at 10:22:59AM +0200, Konrad Dybcio wrote: > On 4/20/26 5:49 AM, Shawn Guo wrote: > > From: Deepti Jaggi > > > > The Nord SoC CPUCP mailbox supports 16 IPC channels, compared to 3 on > > x1e80100. The existing driver hardcodes the channel count via a > > compile-time constant (APSS_CPUCP_IPC_CHAN_SUPPORTED), making it > > impossible to support hardware with a different number of channels. > > > > Introduce a qcom_cpucp_mbox_data per-hardware configuration struct that > > carries the channel count, and retrieve it via of_device_get_match_data() > > at probe time. Switch the channel array from a fixed-size member to a > > dynamically allocated buffer sized from the hardware data. Update the > > x1e80100 entry to supply its own data struct, and add a new Nord entry > > with num_chans = 16. > > > > Signed-off-by: Deepti Jaggi > > Signed-off-by: Shawn Guo > > --- > > [...] > > > /** > > * struct qcom_cpucp_mbox - Holder for the mailbox driver > > - * @chans: The mailbox channel > > + * @chans: The mailbox channels (dynamically allocated) > > I don't think this line is a valuable change Indeed! I will drop the change. Thanks! Shawn