From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 283F426B777 for ; Tue, 21 Apr 2026 10:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776765806; cv=none; b=ZICxOggNyN1xWdEdvy1AJsZWkU4Mb9BYZa1NXjLF54QRtFNgfAXVSWEDrq1JIBUmwKQpNBtsgXvNjRDlskjBP6wtMttXfrIDSHEBNn6w/1yvViU9QENX3HSOY5vj4g8XgEN3bZqLlSD0ueJgGKCzqp3Q6UCHpmQ3QakuWmfkpNw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776765806; c=relaxed/simple; bh=1ymte7yWU6imnPYbHZd0E3auT708F3JtTDpYQVqDeeQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FJXUKvlcpAkQVx7gI/Vqbk9dfiUnFSn9rM9virAEunxRJWTk0MABBgeMHMGTr/boiFQMHzcO2ubxxBX1JVU1Ocdn1gJqfnujyPtOXuWzTBaQ4yoX6kZZ21wQ/tNeNReI6HEsIrHnpxzZWvbBWlfGrElEO8n8TQu+GNe3BOyyI4g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=R60mC3Lz; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="R60mC3Lz" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0A9B925DC; Tue, 21 Apr 2026 03:03:19 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2636C3F915; Tue, 21 Apr 2026 03:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776765804; bh=1ymte7yWU6imnPYbHZd0E3auT708F3JtTDpYQVqDeeQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R60mC3LzWg2rAYU9AvmzP4L2y+w3o+qfzqVcSZIOG3rd/GT/Le4+lOVBgtM//7JD8 FpO6YEDQyMhp8fParKUfNlgRDqzyA6qh1rd1eo1i2fbSQvPGjW46YYp3/3DXB+oQjr N5e2FaD7Xz+5Wfx1FNQyCS+KQooK3EDs4crJZxj8= Date: Tue, 21 Apr 2026 11:03:20 +0100 From: Yeoreum Yun To: Mike Leach Cc: Suzuki K Poulose , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, james.clark@linaro.org, alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com Subject: Re: [PATCH v5 04/12] coresight: etm4x: exclude ss_status from drvdata->config Message-ID: References: <20260415165528.3369607-1-yeoreum.yun@arm.com> <20260415165528.3369607-5-yeoreum.yun@arm.com> <20260416155118.GM356832@e132581.arm.com> <57dbea1b-670b-4b8f-a590-1d4239bc2c76@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Mike, > Hi, > > This register [bit 31] indicates if a single shot comparator has matched. So > read-back provides information to the user post run to determine which if > any of the comparators set in this way has actually matched. Okay. so after disable sysfs session, to check former session check whether comprator has matched. > > Moreover, the specification states "Software must reset this bit to 0 to > re-enable single-shot control" and "Reset state is unknown. STATUS must be > written to set an initial state...." > > Therefore this register must be written as part of any configuration so > should be available in the drvdata->config for both read and write, But I don't think this is the reason for locate ss_status into "config" since its write purpose is not to configure but the "clear" former bit. That's why I think it's enough to clear when the new sysfs session starts. Am I missing something? Thanks! -- Sincerely, Yeoreum Yun