From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0585629430 for ; Tue, 21 Apr 2026 10:24:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776767098; cv=none; b=qQnYTY5UZaMfHkOthyxrbsvZ/8sYalWLQsbrfBztS6yyln9qYQB8WNfcj4cyOfG8NvvOyy68iUhyOSFMwwIsQMb1blee8CO/flLoc0QueFbi6WSKMpWaiRuS6G43wSHdqk6TyBBfv6WpkT8TwYaycwiBt0D+GQG57vMjmFLMjEI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776767098; c=relaxed/simple; bh=firh9QIDguLTG6wgrGZbOOkBiLIhh3fjZnBwKL1kIv0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TQPnVyxWkLe2A3IJW57PTiIyqQPTZGEmvI0jIOe+KIZtqjncCC5GWh9S+G15dAnT2ooySVu+8y9xX436zGjDPymVOnyQQxfDJNoKsuqE0hzLC0UZmDaYD4rSs5urW1+MdiAB/He4W7i/jAnEeXLEL7cEGQ+mFWn/M4FXuYiDf/c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HCemAdsh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HCemAdsh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5223FC2BCB0; Tue, 21 Apr 2026 10:24:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776767097; bh=firh9QIDguLTG6wgrGZbOOkBiLIhh3fjZnBwKL1kIv0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=HCemAdshi4KHRisPS/RvA4gQfws3j/RpyxXKUV0Yegibkt/idynoXy6hFSxswaKj4 yIPog4pFxpsumS1Dzkt0wk2UNZa2ovd/UR1Lta1s4Hedl9r3tkfTF41yQbgCqmU0DZ BGeA3mT3tF8ULSg2K01WZXOvDNheI+LpdNFt76wb5SEezuZck8GApCkjA9i5gxuNkV Txlk3Yu9CkOA0rBQPV1OWF5pzbXtA2abcQYSE3FbOx+aJP4Q619/M6hlqrYxA78/t2 PqaRG6eFDhwal6MZKLRSf4F8WNAMknUFX7PgbzwdyLlndysLpFhheB+hn/2TTgwdaU LTqt+RVzihJ5A== Date: Tue, 21 Apr 2026 13:24:51 +0300 From: Mike Rapoport To: luca.boccassi@gmail.com Cc: kexec@lists.infradead.org, linux-mm@kvack.org, graf@amazon.com, pasha.tatashin@soleen.com, pratyush@kernel.org, brauner@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 1/6] liveupdate: reject LIVEUPDATE_IOCTL_CREATE_SESSION with invalid name length Message-ID: References: <20260420141741.2688371-1-luca.boccassi@gmail.com> <20260420141741.2688371-2-luca.boccassi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260420141741.2688371-2-luca.boccassi@gmail.com> On Mon, Apr 20, 2026 at 03:15:09PM +0100, luca.boccassi@gmail.com wrote: > From: Luca Boccassi > > A session name must not be an empty string, and must not exceed the > maximum size define in the uapi header, including null termination. > > Fixes: 0153094d03df ("liveupdate: luo_session: add sessions support") > > Signed-off-by: Luca Boccassi > Reviewed-by: Pasha Tatashin Acked-by: Mike Rapoport (Microsoft) > --- > kernel/liveupdate/luo_session.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/kernel/liveupdate/luo_session.c b/kernel/liveupdate/luo_session.c > index 25ae704d7787..5e316a4c5d71 100644 > --- a/kernel/liveupdate/luo_session.c > +++ b/kernel/liveupdate/luo_session.c > @@ -382,9 +382,13 @@ static int luo_session_getfile(struct luo_session *session, struct file **filep) > > int luo_session_create(const char *name, struct file **filep) > { > + size_t len = strnlen(name, LIVEUPDATE_SESSION_NAME_LENGTH); > struct luo_session *session; > int err; > > + if (len == 0 || len > LIVEUPDATE_SESSION_NAME_LENGTH - 1) > + return -EINVAL; > + > session = luo_session_alloc(name); > if (IS_ERR(session)) > return PTR_ERR(session); > -- > 2.47.3 > -- Sincerely yours, Mike.