From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8892C3B2FDA for ; Tue, 21 Apr 2026 10:30:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776767409; cv=none; b=ZE4nZ0nA12oOOlRJiYf4Fw7HheBImKjSMLOgBLxpDMXmlwYGS2qN2UKfamaa3VyQKqRU8UgAUB0A0WyLeCFWYGJCEuXqubpEJwXBoafu9BpfFNNO47Kj0bYX+0vkoC78PEnZriD5vygOIW6NJKwmQUOVAa0+4D4igsS9BL4teT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776767409; c=relaxed/simple; bh=TakNj7Wkg489yxw2UozyVp1eTaX5n49I0RrLcW9q2QM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tadHhchdrwjGkUthdN9A8Jfp5Pi7EmxZJR0RmVar/nIGEKmSnxUxIurhjL8DJolFDiGJ35ERtXph5lDVV/br8xFu+a2+EBHYGC08iz3ZSCO0TLMFIMQaz0bIQ/F5qggi37vG6Dp8/PWGbgDleC5u9q2wEz53RmgMFlPjhQ9VtWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=YSGGslBM; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="YSGGslBM" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3318025DC; Tue, 21 Apr 2026 03:30:01 -0700 (PDT) Received: from e129823.arm.com (e129823.arm.com [10.1.197.6]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 16E7A3FE8F; Tue, 21 Apr 2026 03:30:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776767406; bh=TakNj7Wkg489yxw2UozyVp1eTaX5n49I0RrLcW9q2QM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YSGGslBMiCYYiCk0oXSHT2dTqoCyEVvVShgLEaMfdPJ7AzzMDJ3NsrPAQVYEeZ5lQ tCAvBCkWITvUmgvmsw0sIk0DcH5HyuZKa02j8wVEDL7QyLmKW2jQxzJiCl85T24wlD P4bRDKTxzAeV2pp2W74ArdbK5RXsxHbxa16UQ0Ms= Date: Tue, 21 Apr 2026 11:30:02 +0100 From: Yeoreum Yun To: Mike Leach Cc: Suzuki K Poulose , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, james.clark@linaro.org, alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com Subject: Re: [PATCH v5 04/12] coresight: etm4x: exclude ss_status from drvdata->config Message-ID: References: <20260415165528.3369607-1-yeoreum.yun@arm.com> <20260415165528.3369607-5-yeoreum.yun@arm.com> <20260416155118.GM356832@e132581.arm.com> <57dbea1b-670b-4b8f-a590-1d4239bc2c76@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: > Hi Mike, > > > Hi, > > > > This register [bit 31] indicates if a single shot comparator has matched. So > > read-back provides information to the user post run to determine which if > > any of the comparators set in this way has actually matched. > > Okay. so after disable sysfs session, to check former session > check whether comprator has matched. > > > > > Moreover, the specification states "Software must reset this bit to 0 to > > re-enable single-shot control" and "Reset state is unknown. STATUS must be > > written to set an initial state...." > > > > Therefore this register must be written as part of any configuration so > > should be available in the drvdata->config for both read and write, > > But I don't think this is the reason for locate ss_status into "config" > since its write purpose is not to configure but the "clear" former bit. > That's why I think it's enough to clear when the new sysfs session starts. > IOW, I think it's better to remove ss_status from configfs item and - add field ss_cmp in etm4_cpas - add another field ss_status under "etm4_drvdata" to show "PENDING and STATUS" bits to sysfs after finishing session. Is is valid for you? > -- > Sincerely, > Yeoreum Yun > -- Sincerely, Yeoreum Yun