From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 097CC3BBA03 for ; Tue, 21 Apr 2026 10:35:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776767706; cv=none; b=BJLZNRVcfdpueoE7rNNLqzPMTdD25hizrMUQmc2Uu5ztKHOiusgnhHep/11gF2sjFa6Ry+vSiEWeN6adpsJodxdH0Cs82/zD8eFNXN4EbwmLvHklfxpucwgaKWrbva6TtL826GNUT0RV9Tec+13+hE09HGsdAobFhE3Lg9I/NJQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776767706; c=relaxed/simple; bh=Otx4/28D/avzJk9j+GmtzEbJr9JeUGnkNqWUvmAkEB0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=awe7KUhlkJ8Ot982JfVxA409YmrXghZoMoc2X3hzELSeBPZAO8az65dslRIjtW6QxiXcFD1f8jI2tQkWQvBBE0a5KBvaGI29f5zjnEvWLV+WwByfjyr1m6WNJvuDskU8/FWEsKLt5gN12t65l7APBESM9BTUOQpvm6BeaNOz1tw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fxFNhT5o; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fxFNhT5o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68F2BC2BCB0; Tue, 21 Apr 2026 10:35:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776767705; bh=Otx4/28D/avzJk9j+GmtzEbJr9JeUGnkNqWUvmAkEB0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fxFNhT5oIpf/DoArdi5DWsQl/Vw0cITuuGLY+OnDTbqapl+Vvr902bX2oA/Sqved1 JheUmnmd3Z/zvhKAPmOxliqyx/4oQTv+Mx+U1LXTbe/e4fB4GISVVU5UJnpqqRVycQ gLpAz9t8O2jMQsYimjLHYAUozjs5iggt3NmSuZOXOhgA3qrxyR1uZ3xOdi2o6H1r1E WviXL2QVS3PvUx139LohMrlhOFBvyK26mOutl65/ME2Mb9ccNedXgXfNNizBLWRf/+ +GmYVYlfI6Qf57qGBzB2lFtiE1dZYWNROXKR8RwCZ1DUtAgLUfPQID2yZ3RoF7iSAZ l3M2lsNKCK/9g== Date: Tue, 21 Apr 2026 13:34:58 +0300 From: Mike Rapoport To: luca.boccassi@gmail.com Cc: kexec@lists.infradead.org, linux-mm@kvack.org, graf@amazon.com, pasha.tatashin@soleen.com, pratyush@kernel.org, brauner@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 6/6] selftests/liveupdate: add test cases for LIVEUPDATE_SESSION_GET_NAME Message-ID: References: <20260420141741.2688371-1-luca.boccassi@gmail.com> <20260420141741.2688371-7-luca.boccassi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260420141741.2688371-7-luca.boccassi@gmail.com> On Mon, Apr 20, 2026 at 03:15:14PM +0100, luca.boccassi@gmail.com wrote: > From: Luca Boccassi > > Verify that the new LIVEUPDATE_SESSION_GET_NAME ioctl works > as expected via new test cases in the existing liveupdate selftest. > > Signed-off-by: Luca Boccassi > Reviewed-by: Pasha Tatashin Acked-by: Mike Rapoport (Microsoft) > --- > .../testing/selftests/liveupdate/liveupdate.c | 71 +++++++++++++++++++ > 1 file changed, 71 insertions(+) > > diff --git a/tools/testing/selftests/liveupdate/liveupdate.c b/tools/testing/selftests/liveupdate/liveupdate.c > index 5e99af0cc6e9..c21354dc9b93 100644 > --- a/tools/testing/selftests/liveupdate/liveupdate.c > +++ b/tools/testing/selftests/liveupdate/liveupdate.c > @@ -105,6 +105,22 @@ static int create_session(int lu_fd, const char *name) > return args.fd; > } > > +/* Helper function to get a session name via ioctl. */ > +static int get_session_name(int session_fd, char *name, size_t name_len) > +{ > + struct liveupdate_session_get_name args = {}; > + > + args.size = sizeof(args); > + > + if (ioctl(session_fd, LIVEUPDATE_SESSION_GET_NAME, &args)) > + return -errno; > + > + strncpy(name, (char *)args.name, name_len - 1); > + name[name_len - 1] = '\0'; > + > + return 0; > +} > + > /* > * Test Case: Create Duplicate Session > * > @@ -427,4 +443,59 @@ TEST_F(liveupdate_device, session_fstat) > ASSERT_EQ(close(session_fd2), 0); > } > > +/* > + * Test Case: Get Session Name > + * > + * Verifies that the full session name can be retrieved from a session file > + * descriptor via ioctl. > + */ > +TEST_F(liveupdate_device, get_session_name) > +{ > + char name_buf[LIVEUPDATE_SESSION_NAME_LENGTH] = {}; > + const char *session_name = "get-name-test-session"; > + int session_fd; > + > + self->fd1 = open(LIVEUPDATE_DEV, O_RDWR); > + if (self->fd1 < 0 && errno == ENOENT) > + SKIP(return, "%s does not exist", LIVEUPDATE_DEV); > + ASSERT_GE(self->fd1, 0); > + > + session_fd = create_session(self->fd1, session_name); > + ASSERT_GE(session_fd, 0); > + > + ASSERT_EQ(get_session_name(session_fd, name_buf, sizeof(name_buf)), 0); > + ASSERT_STREQ(name_buf, session_name); > + > + ASSERT_EQ(close(session_fd), 0); > +} > + > +/* > + * Test Case: Get Session Name at Maximum Length > + * > + * Verifies that a session name using the full LIVEUPDATE_SESSION_NAME_LENGTH > + * (minus the null terminator) can be correctly retrieved. > + */ > +TEST_F(liveupdate_device, get_session_name_max_length) > +{ > + char name_buf[LIVEUPDATE_SESSION_NAME_LENGTH] = {}; > + char long_name[LIVEUPDATE_SESSION_NAME_LENGTH]; > + int session_fd; > + > + memset(long_name, 'A', sizeof(long_name) - 1); > + long_name[sizeof(long_name) - 1] = '\0'; > + > + self->fd1 = open(LIVEUPDATE_DEV, O_RDWR); > + if (self->fd1 < 0 && errno == ENOENT) > + SKIP(return, "%s does not exist", LIVEUPDATE_DEV); > + ASSERT_GE(self->fd1, 0); > + > + session_fd = create_session(self->fd1, long_name); > + ASSERT_GE(session_fd, 0); > + > + ASSERT_EQ(get_session_name(session_fd, name_buf, sizeof(name_buf)), 0); > + ASSERT_STREQ(name_buf, long_name); > + > + ASSERT_EQ(close(session_fd), 0); > +} > + > TEST_HARNESS_MAIN > -- > 2.47.3 > -- Sincerely yours, Mike.