From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 245892E7179; Thu, 16 Oct 2025 13:55:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760622926; cv=none; b=oAHtL31Yu1WYkjzZ4Rm30A8PmNefp+MCjwZM70CCJah7xJR2916AlYkVPYRYGpB6mjmD7KGXR5BjzLcJYBsu/vGiBB4lIgbVbkVIYScAQCCkEbBLr2XTmVLbR3jzeM9lu5pTsS+VtxGGScuujiuYmQsSi/TvqVXNbMvwbrEOik8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760622926; c=relaxed/simple; bh=UEKp1DHAqPsI6gpkgu9tC/Ox9lhUWrYCS7E0VTkLkKc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lft8FyiTfu0RFdDtMp5Y0s6HrKurivCBrRxC5vCht+E6rYH9YhVQC2SWuDd+CucbK09bi0S/LyxqGRmJlqw/LW2DXnzBpQogyrNQSHdgxbIP/qWF6I2Ntm/ho0AlBdPgAUVouHzZYK0BL3X1+63myrMgLbTOkbG+W5EMD+bAODE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jcvMWYo6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jcvMWYo6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44DE0C4CEF1; Thu, 16 Oct 2025 13:55:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760622925; bh=UEKp1DHAqPsI6gpkgu9tC/Ox9lhUWrYCS7E0VTkLkKc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jcvMWYo6bGSIeoJKKdb+YNp0NXUn0fAq+GEtFWjhyKip2w94+ZO0nUQSCsCnc1Cjm tvaNWT34osvZA7pQbxGx+/9qinfl/czRRNmBS/RzKqi1vpADnqqEpcVpEn+Oy6CiIm lgtOYCE7iif0mFWCoStXSGRDTByDvZIV23kFwWUdokLx2iMCkTQ21gnlCh19tCA+kT 4CUhGXBiSlHFJwJs2CW8OIdsqCSmuDoYQ0KyaTKNn11j1bnf5dqb8n1JYwxPj6Vb8F BzpbqWKTDfZcnMHzDkOBJwOd2E0do98bEuUHqH4Vmx2u1e3kL0ACz2L05wE8zJM80U Xcmj0IeY6QclQ== Message-ID: Date: Thu, 16 Oct 2025 14:55:20 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] media: qcom: camss: add support for SM6150 camss To: Wenmeng Liu , Wenmeng Liu , Robert Foss , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251016-sm6150-camss-v1-0-e7f64ac32370@oss.qualcomm.com> <20251016-sm6150-camss-v1-2-e7f64ac32370@oss.qualcomm.com> <1d4d4627-7fe9-43b2-8622-8ffc078e30a6@kernel.org> From: Bryan O'Donoghue Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 16/10/2025 13:36, Wenmeng Liu wrote: >>> +    case CAMSS_6150: >>>           regs->lane_regs = &lane_regs_qcm2290[0]; >> You don't need to specify the array index for that. >> > Here I have only added "case CAMSS_6150:", then do I need to modify the > part of "&lane_regs_qcm2290[0]"? Hmm no I'm wrong - again. Please don't be afraid to call people out on being wrong - like I am now. Existing code is: case CAMSS_X1E80100: regs->lane_regs = &lane_regs_x1e80100[0]; regs->lane_array_size = ARRAY_SIZE(lane_regs_x1e80100); regs->offset = 0x1000; break; case CAMSS_8550: regs->lane_regs = &lane_regs_sm8550[0]; regs->lane_array_size = ARRAY_SIZE(lane_regs_sm8550); regs->offset = 0x1000; Your comment is consistent with existing code. You may ignore the previous statement. --- bod