From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A25FD3C8738 for ; Thu, 11 Jun 2026 10:24:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781173448; cv=none; b=MjmfnPaKzk9Il44+dIItZvlDNLkngtzVBdY1AAWh0lWq6iuoww9iNLkaGHbhaWDlJExHU+upeVOQitHJVs+71zcLbufGT9Ykd0+7YloealnG3aryQSrzm+T5Mw6rA2lT3oYqdqPhulB1Y98GFMAYiqOXNs4r2KwEE+ywdYSGh7E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781173448; c=relaxed/simple; bh=BRIhP1c5l64GL5nzREWYnxFaIeCLqtTAcpnijT42FMU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N5khs6O4udBvWpME4rVrCDv2L80B/3H8m4iu+qJ+r6LdKcl5yiZRONl1ZuCXgQaFtTftniqQHrVmqOMSzWBCmSX1YvIVLHWKjJU8VDkWem/qf7zPOGZOUF3hUo5nK2vG0/rEk0JvKno2vS+NHDV9wxUIzS/bbTHYN0rkv4GhJq4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=UmBpdEBE; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="UmBpdEBE" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1781173434; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CJW9SRp3N9hZK79ixkB90qcmSFzNxOBqsqkfGQa+AM4=; b=UmBpdEBELirtlTy1TMMuDQz/Xtov9IDXlcQLgcy/00OliRPFMmSuJ4YT5v+p4RCiYZgYUy JE7iPtINt1CdyrvQngLuLoA3u+PACDwwXXOPkBz3C5HaLeUIQslpjwjtVDIPFr8i5Bqk3I ziwH7QbZ4jFlYrMjTXkR8TAQu2TCyno= Date: Thu, 11 Jun 2026 18:23:42 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v2] bpf: Fix unaligned interpreter panic on JIT fallback path Content-Language: en-US To: Tiezhu Yang , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko Cc: Puranjay Mohan , loongarch@lists.linux.dev, bpf@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260611101216.30153-1-yangtiezhu@loongson.cn> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Leon Hwang In-Reply-To: <20260611101216.30153-1-yangtiezhu@loongson.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 11/6/26 18:12, Tiezhu Yang wrote: [...] > +/* Fix up helper call offsets for inlined helpers on JIT fallback path. */ > +static void bpf_fixup_fallback_inline_helpers(struct bpf_verifier_env *env, struct bpf_prog *fp) > +{ > + struct bpf_insn *insn = fp->insnsi; > + const struct bpf_func_proto *fn; > + int i; > + > + if (!env || !env->ops->get_func_proto) > + return; > + > + for (i = 0; i < fp->len; i++, insn++) { > + if (insn->code == (BPF_JMP | BPF_CALL) && insn->src_reg == 0) { NIT: better to use bpf_helper_call() here. Other than that, lgtm: Acked-by: Leon Hwang > [...]