From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010027.outbound.protection.outlook.com [52.101.193.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99A753D2FE6 for ; Tue, 21 Apr 2026 12:33:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.193.27 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776774810; cv=fail; b=GBBtG3GRafM9gZvTP9OJgELPud9rYoBaz4sMS1/+ag5yTz4bkBPyflRqV65rhy3rDShnVchVwFWUsGkXjkeolAFUb1bupklEaETpT79esF+B+tLMhnH/moXoiQdAwrcB0QIpsiGbN/ShRn72VRXuCmyk6On6Hy0pQj9OZwgFHeg= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776774810; c=relaxed/simple; bh=T41c0jDY//P/fUXNlTpbCE1od9G1J9Qh0t/1mn5DE+o=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=TAnBUIddaIIPelwJQeIv8Ff1Fvq3TRimN7eOItfCDP46qwxXjPeMswqzM2ApY+fEGnrhevAaGlDyLPmtC4fvCB73AL0uzIcE5IRTW1YliqsRVQUZeGbtfYAEGLdBgkBrRz5DbpoMzBJkhf2akw/hpTd31xcBPSsPeovfUbKoxwg= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=PoV56110; arc=fail smtp.client-ip=52.101.193.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="PoV56110" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HpRnOqfV2LGtslG1s3MtdKQZ506KCSk79TjLbaFaK82Ja7/lMvEa+IvFno4fFikRbRbpVonY5NIcpOtiphx5Rh+ODuDdi/H7DWLftZQizneDI64p/1ZKKKDWJxhnkU5waMwGgfuw28i/Fqj/zlc3n23ZZCa7mZsKLbtbey4NLIOAs182TQpo9MGm72yMJ2W9FP7hO6ESAyo4LvOZ/PEAEVXFFyT0XieDBvOV4m/BZqZg4qjBybGgXbGXumqR4XHQZN0TmeWXklg2AHkWyGjk6L+XlJ94iOgk/NX3PS/GJIrB78qL9xZWN0zcpbD/fGIiFxh690OfJBD5HWFdStcsow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+WvEhLJJUXm6yoJlmYP9PTArK+pSvgC79VyV/fYmdaI=; b=UG77fhmJQUdDrFI1ofoc7v3Bysehj55U6jX3K6ypQunqfcnMJGwmNDdWczmTv6xTyyzogzTRq0Gpi1GOsFs4BHkmwWyRgbhzy6NcYRlMadF/67b5Z5Su3L1xeE2VAcSA6zwBX9Z+l9xWC98iEjgC/RIT/bA67Gh6mOFTIq94kiU6SEhUMHQApkLMExoKfSPKr7EsIqttBY8JMUCjl49P/c3kBrFqxtWxk+s7YBfmuIyv6Rea0vYx49htUr66bG/F7/YtQa5vC6Dxm98/YLTRKPDDijOm2bBY0rf+xsXH3muIY4FhBnzUktex+MejQbInnZVfp/uIg3c4Ado7sFawpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+WvEhLJJUXm6yoJlmYP9PTArK+pSvgC79VyV/fYmdaI=; b=PoV56110VLF3eeBb/RZH9BswwsP86o6sMwK/Qbg1hecjCZ41PGWZsJ3/zubAsZ6toH8v2Tflv7sofFQLwLHR4NZn3ljv4kj1VqIF7WkhOID7IjZDrtUKF47hr7Jh/lONvsZ8E8no8WVehFVtDhPhnsA64rt5TurlsIOfHLmLkHtP+2ktbxjVMWGowiXaEO2nlK32aYayZMlqG5qSXYS5Kw9H4EkKjDEbe5ZCbg+qcX+Rs4Pr0O4KydMcsW6K8syEfyFfvkwDg3RGcMwhrDRU1oMhF8TbhzspGyWaOTARyVcquoM/lsIDOokshcja4f5/3Ti5i4TeD3ZsmWO3gbxZhQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by IA0PR12MB8253.namprd12.prod.outlook.com (2603:10b6:208:402::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.16; Tue, 21 Apr 2026 12:33:21 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9846.016; Tue, 21 Apr 2026 12:33:21 +0000 Date: Tue, 21 Apr 2026 14:33:13 +0200 From: Andrea Righi To: Vincent Guittot Cc: K Prateek Nayak , Dietmar Eggemann , Ingo Molnar , Peter Zijlstra , Juri Lelli , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , Shrikanth Hegde , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] sched/fair: Prefer fully-idle SMT cores in asym-capacity idle selection Message-ID: References: <20260403053654.1559142-2-arighi@nvidia.com> <64fe32e0-d428-42bb-beb4-2656d8781b0f@arm.com> <7313ba07-7b87-447c-9c48-2f6b2b53ac94@amd.com> <1230f5df-470a-4e59-8c8e-fa159a6fc093@amd.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: ZR2P278CA0086.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:65::16) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|IA0PR12MB8253:EE_ X-MS-Office365-Filtering-Correlation-Id: 592c05ea-17aa-45ae-80b7-08de9fa22c36 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: EGfKwZDAmJ8JuhYM6qThQejxzAEb5YcFOHheiul4yaTFuGBuAw79+dShcekB1IUcTucfD3vu03VdUGit0F2c8gz3nsVThY0zg7gm9xBwD2Lw5Du8sIsn17YC28Z22maP7CQFzcC2tOQ+DQdAPkCduXQWeSJSkbs93RZS45de5INY+YV9criYfyeFUwoJxlvrzTDRh7wpMKOJ/bA6o0uFB/tmIsUtaP4+hm+7gZLRzPrlzbywo+79EGWvPXlr8Brjx7ap90pxZ6QqXKbWWdUN4QIHrns6d9Xzenn1aXKmqWaD2409nYYPxwTJK0RsWdblVWJ4H+6uelS0vcXOc6gYj+PeEWYuqKPskXYLBT3VqDjlilP/f+mmWKnrveNl2i7YNy8Yn+Kf8+F39naquTD/z87AXq03mw3Kpol0To/i1wodjaPVVgOMh3Al3pipm0XJAR0fYchxgCeNKXFr0S1vMIMJWBdrUAGurM6EUCsGgU+QdMT8CpYmI000AUJ2gQBAZixooDU8BqU/aVVoAcgnAMp1vW1rHuWgA9xI/cvJ6kZKpwE/piAz3XcPOJOT6UVguwNprpeJAjSw+zWmWhvBTdf9qbS4THPGfk45ss+fuDkeDdW9lY0fONH0ImoGoRAfG8pjcizS0M/4wII1hv4trzCWqBk1O2339xioWX/z68gzxSi4+Cx93eNjG4yu1dkBFQJLkj3twtzoYyzLuZfEgRawVuHaExAbaLEwk0TNevc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BhogVPMqBSShCyakFUn6u6vhL8aeX8Oc6MTuLONmzSNTcJDkcuXiSOJCzCn8?= =?us-ascii?Q?ExccIFPtDxyQz4GSpOgKXKbu21FrxlJSZnkTS4wLU28+ZRn35G66RJXDQUJc?= =?us-ascii?Q?Cf1l5hSY/bDTOLu6vK/Od7r5sIiL8q1zQBMEVr/VI1DTsQDUkONMqENZ1qjQ?= =?us-ascii?Q?wLt/bIjEAqETzR8IxKbyQQOVe/q+JUUVPD0crAR6JxDga2w/xby6JBwDBsB9?= =?us-ascii?Q?XMjLpRYsxtlIzz2HY+I1S4Z6/JuYu/4LxKFlxHF+cJcp/1s5UXpicwVtTRFC?= =?us-ascii?Q?5lW1/+/ZFTBbuJXU6nu9vQXhNytms86D7hdN0JE7azgH+SFVVY8QiS7q68NR?= =?us-ascii?Q?S41db4XYbDbkGiyaWPMdNqtcok0mbhFUUPMuXJyvFQbJtdwpST3cgtMVw4ZU?= =?us-ascii?Q?GkfcWw3Ek7WSglfo4aQ9x4L2oAwpykrL0T1ivxfLGzJMCS+4DqM7LBqVg7Yh?= =?us-ascii?Q?zl5smU0hBHd+K2wQYQqcNrXB5wgPbAMx7M9TW38cF9SlhyHhi/cozU6os7u1?= =?us-ascii?Q?RoPuRMEpWdfX99B4lEHpY76aZvLwTfOCkFOYabzAddtSJ3BmGMxWMNyBWy26?= =?us-ascii?Q?pPwn5/QabjWRtFvVbNThCyQyYK3ZsodGqQKYLGt1+Bz37ZWlRGFdNYbZv4D5?= =?us-ascii?Q?k+Gptio8QjfDD+FY30hraovceXuTGH8X3AH4FfxRvTGLJvu674QKLP3ZdPIb?= =?us-ascii?Q?uxqbf5ELqBLx4Niv9AnJlG2w1x8dtm5mFoGvZ7OecLJKp3XlqumkFB3f8sZ+?= =?us-ascii?Q?/vxryR95llRB20vLnKsx530EDdT8pPUxEXDq/AAkqvdP6F/0JyX/MPYoM1Jt?= =?us-ascii?Q?Q2hylfWxCaUJpHY587r1N+1MjxNIuvRm80+f4fP2j13djyQCSD0cHlpoX3PT?= =?us-ascii?Q?4rjRxF5CulzLthZ+sgEjMUZePzbLe17fEPX2wdhDCuAJ37UpEfdTEGKu4asg?= =?us-ascii?Q?LrSNANI3jI0LpkKfodJWWvcCNlbsGtRMNxRzWKbB5iodelOwi9DkLl74Agof?= =?us-ascii?Q?LnG0/Hhb1Un9NI+i2uX0eQrp62+9+VFvlyhfeSggaJlkIUNBERg64269APNN?= =?us-ascii?Q?SVOh+Oq76VDR05xcwdPAEWnpfnFtj3p/mVfNf+8UvACEJa9GNi4+KEHogiuU?= =?us-ascii?Q?qxgE0znFKejZyk+5z0TWODKKbVw3yAv10qsQ6hinwe5tSgMpftK4VutHZkiN?= =?us-ascii?Q?iPpJR6hT9ApS4J5xRR8HoxKLU+zCI3L/b3JXKVfCOUFMq7M2tRZpMqHMLjUI?= =?us-ascii?Q?wOJeYskot6kvgCt29gqm4fz0X8RoJ2lMz3UPRwD5Ibq9Fx6q6AcoFKdejYrO?= =?us-ascii?Q?aVPAcuzncJ6oSt8K8J1dFQ6zeuqSKtB0s8MvwMpyfoQjrVTH/p6TVr6YaCA1?= =?us-ascii?Q?qaYs5Pxoks7xfTygq4NuS5LOGmYzPAr982EPKONCnSQn+NW9k5+dbzBbyE+E?= =?us-ascii?Q?fUrvXLSnbKrZPmpOkF+dx91cSOMIBfy+s63N4mIiCyyGZrYHzskrW4C8Pp7f?= =?us-ascii?Q?blNt8/l31He/YoP5su2hXPdvSLMwgpTRCZofDFDeb/P47XkCvHqPV2ztmlxu?= =?us-ascii?Q?DBpxoOlag/a+x4eeYtuOHi1XzbMC9jEieTFmmYvSVBnYL8oIo8FjAMy/P5+S?= =?us-ascii?Q?f7SXM9/c4Gcp+XHgiqQgCSCEA1AEBToJXJp3D98poVYXR/eIpirNP/NgZIAC?= =?us-ascii?Q?QltQbVquYcnasHgh/QR0bW1qjzoUqGhcm/n4WDdwh0wMUcRxj16ZeybdF8b+?= =?us-ascii?Q?1BLTBbLM6Q=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 592c05ea-17aa-45ae-80b7-08de9fa22c36 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Apr 2026 12:33:21.0347 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zXGOzpzkcRXE8oO4D+98hQ3wZPsObUX9DxaIITCoxCIBB5rhPyhByhojVv4ruP2RdlWfprK8nRDkp9M7JGWy6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8253 On Tue, Apr 21, 2026 at 02:26:58PM +0200, Vincent Guittot wrote: ... > > > > Yeah, makes sense. I'm wondering if we should attach the shared blob to > > > > sd_asym_cpucapacity only when asym is a non-overlapping domain, otherwise > > > > fallback to sd_llc and, in this case, ignore has_idle_cores in > > > > select_idle_capacity(). This might be not the best in terms of efficiency on > > > > those exotic topologies, but it'd eliminate the overlap/aliasing risk, while > > > > still being correct. What do you think? > > > > > > I slightly changed your patch adding this logic on top, I'll send an updated > > > patch series, so it's easier to review/comment. > > > > Actually... while preparing the series I realized that in select_idle_capacity() > > we may end up clearing the has_idle_cores hint even when the failure is due to > > affinity constraints (no fit CPU in the allowed cpumask), not only when no fully > > idle core is found in the system and this can lead to false has_idle_cores > > hints. > > How is it different from select_idle_cpu() which does the same afaict ? Nah, it was just me not reading the code right. It's the same with select_idle_cpu(), so I'm back at using Prateek's patch. Thanks, -Andrea