From: Namhyung Kim <namhyung@kernel.org>
To: Markus Mayer <mmayer@broadcom.com>
Cc: James Clark <james.clark@linaro.org>,
Perf Mailing List <linux-perf-users@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 1/1] perf build: fix "argument list too long" in second location
Date: Tue, 21 Apr 2026 10:47:51 -0700 [thread overview]
Message-ID: <aee4R3i-xnb0F0qb@google.com> (raw)
In-Reply-To: <CAGt4E5t4v3ztJPFRX-x0ygTk3cgnM_SwB_t+vvbNJ+_ifa=KHA@mail.gmail.com>
Hello,
On Mon, Apr 20, 2026 at 11:26:42AM -0700, Markus Mayer wrote:
> On Tue, 14 Apr 2026 at 03:43, James Clark <james.clark@linaro.org> wrote:
> >
> > On 11/04/2026 02:07, Markus Mayer wrote:
> > > On Fri, 10 Apr 2026 at 02:25, James Clark <james.clark@linaro.org> wrote:
> > >>
> > >> On 09/04/2026 11:14 pm, Markus Mayer wrote:
> > >>> Turns out that displaying "RM $^" via quiet_cmd_rm can also upset the
> > >>> shell and cause it to display "argument list too long".
> > >>>
> > >>> Trying to quote $^ doesn't help.
> > >>>
> > >>> In the end, *not* displaying the (potentially long) list of files is
> > >>> probably the right thing to do for a "quiet" message, anyway. Instead,
> > >>> let's display a count of how many files were removed. There is always
> > >>> V=1 if more detail is required.
> > >>>
> > >>> TEST linux/tools/perf/pmu-events/metric_test.log
> > >>> RM ...634 orphan file(s)...
> > >>> LD linux/tools/perf/util/perf-util-in.o
> > >>>
> > >>> Also move the comment regarding xargs before the rule, so it doesn't
> > >>> show up in the build output.
> > >>>
> > >>
> > >> I'm assuming this is just a cosmetic issue so it doesn't need a fixes
> > >> tag? And "upsetting the shell" doesn't cause a build failure?
> > >
> > > No. It's not just cosmetic. It absolutely DOES cause a build failure.
> > >
> > > From the cover letter in this thread:
> > >
> > > GEN linux/tools/perf/pmu-events/arch/arm64/arm/neoverse-v3/extra-metricgroups.json
> > > TEST linux/tools/perf/pmu-events/metric_test.log
> > > make[5]: /bin/sh: Argument list too long
> > > make[5]: *** [pmu-events/Build:220: prune_orphans] Error 127
> > >
> >
> > Ah in that case it should have a fixes: tag then. And it's worth putting
> > the actual build failure in the commit message IMO.
>
> Unfortunately, it looks like the patch was already applied.[1] Is
> there anything I (or someone else) can do to fix up that commit
> message in the way you are suggesting?
It's already merged to the Linus tree. I don't think we can change that
anymore.
Thanks,
Namhyung
next prev parent reply other threads:[~2026-04-21 17:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 22:14 [PATCH 0/1] perf build: fix "argument list too long" in second location Markus Mayer
2026-04-09 22:14 ` [PATCH 1/1] " Markus Mayer
2026-04-10 9:25 ` James Clark
2026-04-11 1:07 ` Markus Mayer
2026-04-14 10:43 ` James Clark
2026-04-20 18:26 ` Markus Mayer
2026-04-21 17:47 ` Namhyung Kim [this message]
2026-04-21 21:12 ` Markus Mayer
2026-04-22 10:02 ` James Clark
2026-04-14 17:11 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aee4R3i-xnb0F0qb@google.com \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mmayer@broadcom.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox