From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B683D21A447 for ; Wed, 6 May 2026 14:55:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778079303; cv=none; b=hFrD1qn0lB5+MYOLuNdcFuiAVEGF9b7SugpyseeL2eG7eueEGNwFDL2IS6Edk5Rm/vcv+3Ty1kYwz/ssFI2GPgKiklxeL8LVs7fUZcYA4CZ6Ui/R+TQ23UNdwhz2oiSmESCEG/e00i3UnJoh50TjLi7LiimEXyG+rWU7MUKzk4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778079303; c=relaxed/simple; bh=rpq98Csl+lQ5wYR6qlUiykh7sw2CinuH04grcHiC76Y=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=fhJlqPS5Dzdyqzf2Q/AR/dR8lavlUsjYW+okIjxx4nBNDOH+j8RY49yv3Mg+LGPsho+RHZ/5DwxYdqVl5EMN2t9PDVVpMQh9I4cqGcARlbUlIRsBr42qcIfH/XEC5ev/0NiUEh0MclyNV6IHUjkrxKfBBupzQgMMKvuNPzE16SA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=L4Ub3bjI; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="L4Ub3bjI" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-44a786a9a35so3658080f8f.3 for ; Wed, 06 May 2026 07:55:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778079299; x=1778684099; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=q9IziybJHuk3HSxCnNSfWSRrMnoKvg7/QyPJ8LC6HiM=; b=L4Ub3bjI93FbAV24RYiF/YbXq8jYWSF+Z0XeIi5xPvjLx+uZCg+Z8306PrA0CJgcLP qED5M17nd7fB4XCNETqfOtYYNU+7lgCvaVW1bKmj5pGhcuNQHfdfZBQduJVoy6P/euOv D+o35miAuA2g25dvCz7MsrGkFe+kUauVudRpmDCQOkzkDKNuR/8fOgi+DfrWoidhvrff Sr9NtB+oguPa7+0WaFUHil65Cu4cBZT7MXa1u+c2rgckvtZwZ1uBc0r5IBh07xLxlXMc I9K29g1Dixcm2uBeN070kUnNhmAQQb1oLQwvAq1b907W7ZJRShuF1Xc9qAEgJnsevxzH kI3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778079299; x=1778684099; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=q9IziybJHuk3HSxCnNSfWSRrMnoKvg7/QyPJ8LC6HiM=; b=VPNCUbIEmwSaEKMbdnsQ5xeSUeoeVVct7P3oWI0XD3NCeiVZHP8zWb0aVC3b05/W+4 Lr27+PhbTVApL4GrDSp3dICqNqfTOZGUqrR9vucUSa4cy2O6fnj4cSHkWT+rUcbfSuR4 whh2y25p8dpiHt/ZD+gooWtH1+N56TGI23sUN8nByulWN56iStHqZ9VRUMEFHjzCM+5z TYiBxBJuy1HY7w9mQaI2KdGvsDqqO8qY6Jc24Daff0XSozZ7DDMJNEz4gYNnb0mszOFa ov8XjSyv8QdHGLvKwrd81rgOo6Y0ww8EZemerHcHv28NShML378YZPHj2Mi2Sda8OX5a Nc5Q== X-Forwarded-Encrypted: i=1; AFNElJ9GLX4XXqloM72kZcOeSwbUN9iLPntk6zcwYKeztleiX5KnZYsQxgQufm+hDmIW7Q4f0ynIfHMK2EUFvsE=@vger.kernel.org X-Gm-Message-State: AOJu0Ywmu67k0aYGyOYyPU0k/lZQZHjHfMnVPFV/cMTmJD13vJzp9imZ AYX6+s85ZMcjcQ+snNQ/Lw1ZhGXXz9LPhuTxkzwfZ0x2u7NNaAzbQOmMwx0xuQXdjOA= X-Gm-Gg: AeBDieubiQj+UXtGKS4/exVvCLTu7BmVdgspwv0fkocw4tVeKgK4a17nNGE4Z3FxvJu 530XQwTWm9hxUaz/Hz8kYMIIfU5+9f2iLTddAkTyn0llMjEnK20AcQN3A2OoEzds5cVIcfZwOaS Xc15O/tnwd++YH4vxZABv5GSMkw/VKbDG4OAto09g7ul+HYAcEn07MsFs1eUsPfwMODzGnOq120 euq7SwSygCuxSLCughNYdCg2lIFo4II7FBccuFPPG4YFxIRY/gjhFh8Mi2fN3wmN2LGA16Osq3Z paCTfYA9NaVxMZeBtH6UM8VAI4d4Cmf0YCnIzDD8GrrUp8gBBP43671hbKSJiXpu1A0nZecocDh LxVe90AnXs3m8wGxu5rEQiXJikPkmPfvjlht49aBIy8jEucxAmn3AtPww+PsN3e6HHmTb8dCLmi HAvTqCjDHPIFPYo3frIvltLikPACEwCLXs6AFFMP9e6M3Ej5GPC3oU7yOqb0/ApYAkdcedoRPdA ffIcx5QWe0fVJEGhA== X-Received: by 2002:a5d:64c9:0:b0:44a:3aee:370e with SMTP id ffacd0b85a97d-4515ce1c5aemr6073557f8f.25.1778079298902; Wed, 06 May 2026 07:54:58 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:5798:67fd:c866:b378? ([2a01:e0a:106d:1080:5798:67fd:c866:b378]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45055960902sm14567686f8f.28.2026.05.06.07.54.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 07:54:58 -0700 (PDT) Message-ID: Date: Wed, 6 May 2026 16:54:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v4 09/16] phy: rockchip: usbdp: Use FIELD_PREP_WM16_CONST To: Sebastian Reichel , Vinod Koul , Heiko Stuebner , Frank Wang , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Andy Yan , Dmitry Baryshkov , Yubing Zhang , Alexey Charkov , linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@collabora.com, devicetree@vger.kernel.org References: <20260428-rockchip-usbdp-cleanup-v4-0-7775671ece22@collabora.com> <20260428-rockchip-usbdp-cleanup-v4-9-7775671ece22@collabora.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260428-rockchip-usbdp-cleanup-v4-9-7775671ece22@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/28/26 18:13, Sebastian Reichel wrote: > Cleanup code by replacing open-coded version of FIELD_PREP_WM16_CONST > with the existing helper macro. > > Signed-off-by: Sebastian Reichel > --- > drivers/phy/rockchip/phy-rockchip-usbdp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rockchip/phy-rockchip-usbdp.c > index 6d7ca11b308e..1bfc365e2b2c 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -75,7 +76,6 @@ > #define TRSV_LN2_MON_RX_CDR_DONE_OFFSET 0x1b84 /* trsv_reg06E1 */ > #define TRSV_LN2_MON_RX_CDR_LOCK_DONE BIT(0) > > -#define BIT_WRITEABLE_SHIFT 16 > #define PHY_AUX_DP_DATA_POL_NORMAL 0 > #define PHY_AUX_DP_DATA_POL_INVERT 1 > #define PHY_LANE_MUX_USB 0 > @@ -104,8 +104,8 @@ struct rk_udphy_grf_reg { > #define _RK_UDPHY_GEN_GRF_REG(offset, mask, disable, enable) \ > {\ > offset, \ > - FIELD_PREP_CONST(mask, disable) | (mask << BIT_WRITEABLE_SHIFT), \ > - FIELD_PREP_CONST(mask, enable) | (mask << BIT_WRITEABLE_SHIFT), \ > + FIELD_PREP_WM16_CONST(mask, disable), \ > + FIELD_PREP_WM16_CONST(mask, enable), \ > } > > #define RK_UDPHY_GEN_GRF_REG(offset, bitend, bitstart, disable, enable) \ > Reviewed-by: Neil Armstrong Thanks, Neil