From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>,
richardcochran@gmail.com, jonathan.lemon@gmail.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ptp: ocp: Add newline to sysfs attribute output
Date: Sat, 1 Nov 2025 23:45:00 +0000 [thread overview]
Message-ID: <aef3b850-5f38-4c28-a018-3b0006dc2f08@linux.dev> (raw)
In-Reply-To: <20251031165903.4b94aa66@kernel.org>
On 31/10/2025 23:59, Jakub Kicinski wrote:
> On Thu, 30 Oct 2025 20:45:19 +0800 Zhongqiu Han wrote:
>> Append a newline character to the sysfs_emit() output in ptp_ocp_tty_show.
>> This aligns with common kernel conventions and improves readability for
>> userspace tools that expect newline-terminated values.
>
> Vadim? Is the backward compat here a concern?
Well, unfortunately, this patch breaks software we use:
openat(AT_FDCWD, "/dev/ttyS4\n", O_RDWR|O_NONBLOCK) = -1 ENOENT (No such
file or directory)
newfstatat(AT_FDCWD, "/etc/localtime", {st_mode=S_IFREG|0644,
st_size=114, ...}, 0) = 0
write(2, "23:40:33 \33[31mERROR\33[0m ", 2423:40:33 ERROR ) = 24
write(2, "Could not open sa5x device\n", 27Could not open sa5x device
So it looks like uAPI change, which is already used...
next prev parent reply other threads:[~2025-11-01 23:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 12:45 [PATCH] ptp: ocp: Add newline to sysfs attribute output Zhongqiu Han
2025-10-31 23:59 ` Jakub Kicinski
2025-11-01 11:18 ` Vadim Fedorenko
2025-11-01 23:45 ` Vadim Fedorenko [this message]
2025-11-03 0:00 ` Jakub Kicinski
2025-11-03 13:04 ` Zhongqiu Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aef3b850-5f38-4c28-a018-3b0006dc2f08@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=zhongqiu.han@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox