From: Chris Wilson <chris@chris-wilson.co.uk>
To: Rakib Mullick <rakib.mullick@gmail.com>
Cc: Keith Packard <keithp@keithp.com>,
akpm@linux-foundation.org,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm, i915: Fix memory leak in i915_gem_busy_ioctl().
Date: Sat, 26 Nov 2011 16:53:23 +0000 [thread overview]
Message-ID: <aefc95$2cas5k@orsmga001.jf.intel.com> (raw)
In-Reply-To: <CADZ9YHinT6Y98Ks6Zs3UnG2xQSJYqDN5W1RgrNtyaPz-n8Zajg@mail.gmail.com>
On Sat, 26 Nov 2011 22:29:12 +0600, Rakib Mullick <rakib.mullick@gmail.com> wrote:
> Yes, no real problem with current code. I was just thinking from code
> cleanup's pov. Is BUG_ON really needed in i915_add_request() ?
No, just documentation as a reminder that the request should be
preallocated, ideally so that we can fail gracefully without touching
hardware and leaving it in an inconsistent state wrt to our bookkeeping.
(This is more apparent in the overlay code which could hang the
chip/driver if we hit a malloc error too late.)
The BUG_ON has certainly outlived its usefulness.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-11-26 16:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 18:49 [PATCH] drm, i915: Fix memory leak in i915_gem_busy_ioctl() Rakib Mullick
2011-11-21 16:23 ` Daniel Vetter
2011-11-21 17:16 ` Keith Packard
2011-11-26 4:44 ` Rakib Mullick
2011-11-26 10:57 ` Chris Wilson
2011-11-26 16:29 ` Rakib Mullick
2011-11-26 16:53 ` Chris Wilson [this message]
2011-11-28 4:29 ` Rakib Mullick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='aefc95$2cas5k@orsmga001.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=keithp@keithp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rakib.mullick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox