From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f202.google.com (mail-pl1-f202.google.com [209.85.214.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6435A175A6B for ; Tue, 21 Apr 2026 23:19:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.202 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776813547; cv=none; b=Ul7h3bE6dFSHftMdQ1Cg2DVZHgkz2Wcxe8RposcPFYQqOQNiubIOn8hA2GYfECwlSzsq0hEPOz1ybK2kwDuvPui3WS5/KT2V52bTc9wnE/OeDAwTXcKKtfqyoHEEOOBe9xdWIoP/RP5XSLqCUB4DfzQGcX5YuG4LtJUPse9RVjw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776813547; c=relaxed/simple; bh=YfWSGbEp3Ri5vampl4rizakqWYJxYDI1iUywls5D1TM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=iiUTiuKn5SivzK2YTm3qOz0uW5rI+KTcGqS8hF4DrHBu7dXQ235dQQPgQBqlNcq2UorFvhTAzHmDL9bCNjdEciMvUPM3NwaWRqBr+CibV3GimDU+yE2/7hMeGMNxVJ8R9VjN+NOJfurmaWZvoRexgFQ9prQ1Ld7rOXw2tEFQ/Dk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gNcOPW6X; arc=none smtp.client-ip=209.85.214.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gNcOPW6X" Received: by mail-pl1-f202.google.com with SMTP id d9443c01a7336-2b249541063so42247275ad.3 for ; Tue, 21 Apr 2026 16:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776813546; x=1777418346; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=kzFNL3zJHiQW2Vbyq91237YpRLX6Z7YBrHD5R7EMXmY=; b=gNcOPW6XuAwnGlPCGvTAVzswebAL7Dt0ebJoQye+2ZWDxK4arDOLu1R0X7fxBiRIq0 rjDkA/uvqLpTt+Ae7V6R2tqNoDLvNie9AzR1fEJC+YFU0npqeyiPULOAhHh05+i4QsA0 IpIPByJ+XcqVPQa02ouy16KpKLYiWcFWYCQGaEGMwShfSacnphFoqDrw0cFUet3AlZQt DEncMjytLqP9Z5z3pNaxStFnjfvNUMZaCeoPpK9gmlhWiZQAX+c63deuwDo6tERNyqhA Tfnw05UvjNA+ytzfI7BQNYrs55AUHIeBDSFqPU1N2e3w6TaH8mOzDcKBkSMIlMYe7KOT NhEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776813546; x=1777418346; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kzFNL3zJHiQW2Vbyq91237YpRLX6Z7YBrHD5R7EMXmY=; b=ovBIuy7epvOyyyTdOPOfAn1/rAgv9ol4wRQvlCbA44X+tQXTaVcbenOQGNx/SprVlM KJj2lFZKx5ljP9ndiIxI/xR4CfCp4g/2Ms4fdRftnVLLD5Y+aS70e7T8fRVXvo3s0pJ9 r3u/UlJR7D+E9rFqKtU97hfzTPP4Ans8VM43/wppyRsoDmwN+AN6HkclAyMmJiiWCg4P HozXQQxgqnNyJwUe9H9yq3+lSIvxCZq5EO6qmJ7l7SRSNQEG2UHEBOMOogtVTACn/HgS Vv6C9SWsqaiBcIWOazjN+6wB0YtoyVotZEgbLlRwcwOOpoMf7iMuOCHJIVhmvnJjAFIW F6Gg== X-Forwarded-Encrypted: i=1; AFNElJ8Uk+3/aDxIsaARR5PXBIab1DmiibnAJtKtJrD6tKsjN9N1WPHzG2gERX52ESl9HtoiJb0fB2nOCm61DLg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8iBd+muzlrOqa/MHrdu2Wj3CIhRNiFrErJG3o/Y3G+A6fAG+l h++tUz5X6vyTWTMeLM0Qh4gLpt24Np1W66lcszHwt7/VKvruCLuUVRNq5byFtRZ/ZTNZHJaWJHz fd9mrIg== X-Received: from plu17.prod.google.com ([2002:a17:903:3691:b0:2ae:39ef:fd8a]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a17:902:c9c4:b0:2b2:712c:61be with SMTP id d9443c01a7336-2b5f9ed0b48mr140812005ad.18.1776813545519; Tue, 21 Apr 2026 16:19:05 -0700 (PDT) Date: Tue, 21 Apr 2026 16:19:03 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260408001137.3290444-1-peter.fang@intel.com> <20260408001137.3290444-4-peter.fang@intel.com> Message-ID: Subject: Re: [PATCH v2 3/3] KVM: Take gpa_t in kvm_vcpu_map[_readonly]() From: Sean Christopherson To: Yosry Ahmed Cc: Peter Fang , Paolo Bonzini , Madhavan Srinivasan , Nicholas Piggin , Ritesh Harjani , Michael Ellerman , "Christophe Leroy (CS GROUP)" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Tue, Apr 21, 2026, Yosry Ahmed wrote: > On Tue, Apr 07, 2026 at 05:11:30PM -0700, Peter Fang wrote: > > Move the conversion from a gpa_t to a gfn_t into kvm_vcpu_map() and > > kvm_vcpu_map_readonly() so that they take a gpa_t directly, reducing > > boilerplate at call sites. > > > > __kvm_vcpu_map() still takes a gfn_t because guest page mapping is > > fundamentally GFN-based. > > > > No functional change intended. > > > > Compile-tested on x86 and ppc, which are the current users of these > > interfaces. > > > > Suggested-by: Yosry Ahmed > > Signed-off-by: Peter Fang > > --- > > I was going to suggest a WARN in kvm_vcpu_map() and > kvm_vcpu_map_readonly() if the passed GPA is not page-aligned, but Sean > usually hates my paranoid WARN suggestions. Heh, for good reason. Adding such a WARN would be triggered by this code: if (!kvm_vcpu_map(vcpu, vmcs12->posted_intr_desc_addr, map)) { vmx->nested.pi_desc = (struct pi_desc *)(((void *)map->hva) + offset_in_page(vmcs12->posted_intr_desc_addr)); The PI descriptor only needs to be 64-bit aligned, not page-aligned.