From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A6653624C8 for ; Tue, 21 Apr 2026 23:51:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776815497; cv=none; b=YHRY+l+wpNrLaQZchpzxREQJJdsOdBTU3IyKjjskYkB0kdZFinCXsb809UEQ1vPGYLV0uSAP6pOTV4Sqk/z8QXrRr4QWBAzRouurxnqF/T3VilkTad1Pi/dWaXKj2ovGSq2hUua6K0T5ihUFtdcv5D3UrRGmIywpaJBvK9eT37E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776815497; c=relaxed/simple; bh=2AzrYkkgpTx3fjRxudg30kIroDX8P20+i+BvUvZC36s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dLdouRsXlfze1yDEhIW6GUu95wmqCOnlF5n8ciTajzuS9NRpvjdW7kEuMmItWoVy2RxdUWO2CkrPpFMXoOhMOgoMPqggEbj7BVrG8NyeQfVu2TgbeaRVkbWaS5J2qLrxPOMtfiQ2+IMuzcQfpKf3AtBzVK1WQgkh6RMWDe6caNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fyK7cMjp; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fyK7cMjp" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-43eada6d900so4738733f8f.0 for ; Tue, 21 Apr 2026 16:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776815495; x=1777420295; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=E7KtRjUQ6sLg+MZ5FkEZdS8HGZukGSYFwBFKnRZPFYg=; b=fyK7cMjp2CMGPz2FdRfRpzvDF1ODnzXxOeGgLbsoyMuJs8CtmnVoMuEGKR/DiQwvVd om2H2D8vJ66wmPSxXLdGRVEfa08nqNR1m0TG6U71NgNi8bqjnZRaUjftd7a6DVByQu+b RvnuisU94v0RHBD7dPGzjtc5xPl1L6TB/RAT1rQaZLo/nMCR1leYulMNHWr159h/NSHT Ac5Zkm+x6KJs6SUjOmIG04nmqBbWNSMNjRzCB2y9ltcjEAsSwST7gHixqoJhz1c2+Cer 8uZJMHjoSY7zpUA/UKDSSSZ1LSAlJbVClGD/2ksgmp4LWD83I5ObRtShYIZk7yjrnbMi s15g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776815495; x=1777420295; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E7KtRjUQ6sLg+MZ5FkEZdS8HGZukGSYFwBFKnRZPFYg=; b=qTBZtkdQ18lrMTxJCfsTaAvFTkjM5wht7bysggJRqxCqiVDaqgk5MAye3G20k357QR NTUOIfsGGj4uLknIYkQJiMOQOKrWekOCGOIzTEe5PFD2crQsBzc/UIQPAZKteaJ8UqHL 1ASaMxMsqLpwt0Hbp4/gUTkWnrUj2SJifZNvyxxLk5wfzINOukPotAUEso4zxJCZ6KB2 nTVJZ9FzNIosWwFxGW1sH9X6PqWZGEiLsCh5hEsExRhl/oDL2JJF3ds732xkrGSUSBpe DReCswjWWKshE/r67fRYnmA7i6AMci9V5rbClkMAwpWexKj7N0KATlZqfpIsKB8WN+fu pDnw== X-Forwarded-Encrypted: i=1; AFNElJ9YDEmqF1o8TUAnNgh9OAjiuwV+vTZBCAkB17R/9u1vET/BZdWRV0tVodcnlflQZAsco/1xDuj3No+7z8E=@vger.kernel.org X-Gm-Message-State: AOJu0YyqondZADrG4eytkJe9F+vQxXmqQuiKFlc4vVWppf6XVDRsAiN0 0WEv+H5AMPSI8fF+56jZH1wYlE6e1cB53c//7vEEG+qdkbBrIZobiiFb X-Gm-Gg: AeBDieuFDr1+gPUvh/1tc2/y6DJvRSy3flBagGLBliD2UqYQdU1yDO5icixpG/yV+PB 14bV2lbwtmKHuHG8xABJXHzJs611JkIu7F4tI893shhh8RqZ30SFSt9D1ojKRcUZTIdoMFkt96E Ld0EeZgpT4rx7pDKmgMj86KzfOKrilo0Xk1rfoXFGbDRdkk5mTqBpf6oBUESpPzX2tGUp56zX85 tQY4WBEOaXYNNUGu9JeA1rPFvRw2Fn3Dk0Fgk483bvKbbVdyhAUw0UixoV/xmFak8DXke+3GO1H 1LKd0Wz0xXt5liBfhozD1C+iRksJqHoq0rew8KKHaUyWSDUYIt3Q40ypkSiSqj8tSnPzmnf/Of+ Z2Y8icz+rRbGVkMQJ95vd8cS4IMY0jWN46JF0EM5YRYL5FOW1SY62qwKzmio2cKcMtKDQO7XfhU XxFUTv7kJlVbuLaJZo44muXmxQZyW9666bPiNOWdneF9Up+ZMLiooNKGlftfwjTKbyga8OMtVhH VjDAWAJMHUxHMIH0gA= X-Received: by 2002:a05:6000:1a8d:b0:43c:f28b:8863 with SMTP id ffacd0b85a97d-43fe3dc7998mr31534684f8f.13.1776815494812; Tue, 21 Apr 2026 16:51:34 -0700 (PDT) Received: from fedora (185-147-214-8.mad.as62651.net. [185.147.214.8]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43fe4e4d525sm39222137f8f.31.2026.04.21.16.51.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 16:51:34 -0700 (PDT) Date: Wed, 22 Apr 2026 07:51:27 +0800 From: Ming Lei To: Caleb Sander Mateos Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ublk: optimize ublk_rq_has_data() Message-ID: References: <20260421194744.1524637-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260421194744.1524637-1-csander@purestorage.com> On Tue, Apr 21, 2026 at 01:47:42PM -0600, Caleb Sander Mateos wrote: > ublk_rq_has_data() currently uses bio_has_data(), which involves 2 > indirections and several branches. Use blk_rq_bytes() instead, which > performs a single indirection with no branches. > > Signed-off-by: Caleb Sander Mateos > --- > drivers/block/ublk_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c > index ef8a0705e68b..5f9b3c3876f4 100644 > --- a/drivers/block/ublk_drv.c > +++ b/drivers/block/ublk_drv.c > @@ -1172,11 +1172,11 @@ static inline struct ublk_queue *ublk_get_queue(struct ublk_device *dev, > return dev->queues[qid]; > } > > static inline bool ublk_rq_has_data(const struct request *rq) > { > - return bio_has_data(rq->bio); > + return blk_rq_bytes(rq); > } blk_rq_bytes() doesn't return the actual payload data bytes, such as, discard command, but bio_has_data() does. thanks, Ming