From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0186E36E47E for ; Wed, 22 Apr 2026 07:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776842280; cv=none; b=MHr0e3IIOtBx2bVT7YuLif36KjVEvT+ErE3GUezH3DfOaCZwPMHMIcBhd26zeAcuK9tV1aWyd36pO157JVK5QdX9M0hOYzeKow1wwnCMJH0Tyeb2iEgn2wFpgyxhF7fjYmqhj08Mj3cJMRBzun1FMtGcUSjaNoHk8u2ppPsNDAE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776842280; c=relaxed/simple; bh=ZG90j3XRb95Ay3b1mW4KNO+ayzL4kVs1S7yqpdo3nEk=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BX+NkToVyGQhUt9T4+r20CRvh80aHGzrkTvWw7JsFy5f8NOM+AVNlCt0oeIzPr6ltp39Dhj1XNPK41uXbmTiFanLgzoXaS8mhluSNPj4jzIqT67qYAD0bHN4/AA6xv3lmWqak4FqtL9CkqfQZ1/jcv7IdbG2NrQAbw6k5EDkowo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DxUCs/ub; arc=none smtp.client-ip=209.85.167.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DxUCs/ub" Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-5a2c9c5ff87so5827938e87.0 for ; Wed, 22 Apr 2026 00:17:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776842277; x=1777447077; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=2XNH6lrFfSGfrUbW+37AE4lo9UaFSg4Ouhd4198aVww=; b=DxUCs/ubCsiy3qDpz4hE4vttyrl7LWE19hgfdhLYRBzk1fF7OXZ2Evw0+ads4PwghD JuCbX79VhXr0xbIGUVN8mXKcImTTpr9BVNFGnZzqE1vf6BZhRAtSfDHYdgydB4hin7Zh 7cCjWby5kUR05IcEfSTZ7qgk710+cl40fNuTAFoyQNsTKrbiRBTHcqzuU8kY+psTAZRX 2jWk6noJEy5tgcnIpvw5roCdmr2AjwKqCp6HjISgU+8AI68b6yS4OMfjsuZkRSwEwjae iy/gG4R+UAbUVdAjzhnYbZ5eXzz/riolWp9A36UBmmU626UBDQBWahF8Kep5DJwX6ev8 OEAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776842277; x=1777447077; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2XNH6lrFfSGfrUbW+37AE4lo9UaFSg4Ouhd4198aVww=; b=PLB1Lc3MH8ZLcUDoW141ciy2PBS1FPZ5hAictqPnMYmt1JiYnZi1wQ+kzjxCGj6NpZ aomr+8CHq7VwlpoH6yg7CxMCvCGS8idpuDbajrleNOYxLdTNgHB09rrIPR1EGREXsRcS GthjPvjNzbUErmZJXht5wBs0YZzslyMgpgRbiia2oXBSPfkZqIRSXw7jw0O1iEeIwJkA 0wRfPdZrTQYw8mWQzvL2RqQuXRaDzt/pP0qSxLao72jOmH3qqeZ2lwUMch7a8AAlhw7D ulc+xahV+JlVzZkKRZjgBHSHW3MdAS3mRMJmkfZGfRup6xuQaLGjsMA1j8plgY0wr0E9 OD0w== X-Forwarded-Encrypted: i=1; AFNElJ93uJfbnwARPy93n7jC2r3YJLqimHls/P0OdukHSSCry86B0pmNv1P8/kevJeS3PAWjk1lFjmcVf6BIm+8=@vger.kernel.org X-Gm-Message-State: AOJu0YxAvTHwlHxR8VUNjHMyQBbW+NCOiVZSQvqZmxjijog08/NLem8U T+QgPWf2b8p8mAnincyzpsRQfhTw39BUI4GTgT6yWJdfXLzIZqR7VnCf X-Gm-Gg: AeBDiesC06ZwUwNbFkpGEKXbOOuSDGw7VLzhFJmYEZWVR9oKZ+pv5FJLM7qKEhBYKsP Wlo44Rp7O0LXMg+nrykqYjsYODJNYriG2R4NOq6KMK7mYhCd/iV6EPd7CGfjUrgUK1ouW2fBHiQ 9mfK80m+GknmC7MsclXFKWXb5NOlMDzSniQzpcpyaJYB8OsaiIVd1K3Smxp35utZOy9dsFCAM6i 2KZef/uuahJRcVydmZT41KGAJ9qX4fnPB/x8H8xch+lffGxm0CGbCx6e+xLERw2yeJgUvOXW21d +/lzwFpNO53IOkmW+xszVjgfCG5eZN6t5rYp+qKoy4NrCyvTFtpYPcM8PHB/pkjgB3TaoyFYHi4 8v8T9eCP0tmuxrpKwzdJ4C5n8LeIV6T4eN5lqKRo4RaVLQjLsRIutzFfc6TvUVUjU5H6FhFKt22 PGEstUsL0Y1A== X-Received: by 2002:a05:6512:159f:b0:5a3:f0f7:7da1 with SMTP id 2adb3069b0e04-5a4172cd17amr8166452e87.17.1776842276850; Wed, 22 Apr 2026 00:17:56 -0700 (PDT) Received: from milan ([2001:9b1:d5a0:a500::24b]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a4187ebf2asm4221846e87.80.2026.04.22.00.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 00:17:56 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 22 Apr 2026 09:17:54 +0200 To: Herbert Xu Cc: Uladzislau Rezki , Thomas Graf , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Michal Hocko , Baoquan He , Alexander Potapenko , Andrey Ryabinin , Marco Elver , Michal Hocko , linux-mm@kvack.org Subject: Re: [linus:master] [mm] c6307674ed: BUG:sleeping_function_called_from_invalid_context_at_mm/vmalloc.c Message-ID: References: <202604211323.fac1b29e-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Apr 22, 2026 at 01:32:35PM +0800, Herbert Xu wrote: > On Tue, Apr 21, 2026 at 02:36:26PM +0200, Uladzislau Rezki wrote: > > > > > > diff --git a/lib/rhashtable.c b/lib/rhashtable.c > > index 6074ed5f66f3..a892766dcedd 100644 > > --- a/lib/rhashtable.c > > +++ b/lib/rhashtable.c > > @@ -473,7 +473,7 @@ static int rhashtable_insert_rehash(struct rhashtable *ht, > > > > err = rhashtable_rehash_attach(ht, tbl, new_tbl); > > if (err) { > > - bucket_table_free(new_tbl); > > + call_rcu(&new_tbl->rcu, bucket_table_free_rcu); > > if (err == -EEXIST) > > err = 0; > > } else > > > > > > Could you please check? The problem here is > > > > rcu_read_lock() > > rhashtable_insert_rehash() > > vfree(); > > rcu_read_unlokc(); > > > > we can just defer freeing via call_rcu(). > > I think we should fix that warning instead. The memory > that's being freed here was just allocated in exactly the > same context through kvmalloc with GFP_ATOMIC. I can't > see why you're allowed to call kvmalloc but not kvfree. > > That makes no sense. > There is vfree_atomic() implementation. Regular vfree(), historically is not supposed to be called from non-sleeping contexts: * Context: * May sleep if called *not* from interrupt context. * Must not be called in NMI context (strictly speaking, it could be * if we have CONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG, but making the calling * conventions for vfree() arch-dependent would be a really bad idea). */ void vfree(const void *addr) { struct vm_struct *vm; int i; if (unlikely(in_interrupt())) { vfree_atomic(addr); return; } BUG_ON(in_nmi()); kmemleak_free(addr); might_sleep(); since your GFP_ATOMIC context allocated chunk of memory using vmalloc() sense kvfree() uses vfree(). The simplest fix to free via RCU. -- Uladzislau Rezki