From: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu>
To: Prasanna Kumar T S M <ptsm@linux.microsoft.com>
Cc: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
linux-edac@vger.kernel.org, git@amd.com,
shubhrajyoti.datta@gmail.com, Michal Simek <michal.simek@amd.com>,
Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC/versalnet: Report PFN and page offset for DDR errors
Date: Wed, 22 Apr 2026 09:29:12 +0530 [thread overview]
Message-ID: <aehHkO9fhiyoxf-e@csail.mit.edu> (raw)
In-Reply-To: <c4a7a3ec-cb87-4edc-ad6a-32dbed15197a@linux.microsoft.com>
On Wed, Apr 01, 2026 at 11:28:10AM +0530, Prasanna Kumar T S M wrote:
>
>
> On 29-03-2026 18:14, Shubhrajyoti Datta wrote:
> > Currently, DDRMC correctable and uncorrectable error events are reported
> > to EDAC with page frame number (pfn) and offset set to zero.
> > This information is not useful to locate the address for memory errors.
> >
> > Compute the physical address from the error information and extract
> > the page frame number and offset before calling edac_mc_handle_error().
> > This provides the actual memory location information to the userspace.
> >
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
> > ---
> >
[...]
> > if (stat->error_type == MC5_ERR_TYPE_UE) {
> > pinf = stat->ueinfo[stat->channel];
> > + pa = convert_to_physical(priv, pinf, ctl_num, error_data);
> > + pfn = PHYS_PFN(pa);
> > snprintf(priv->message, sizeof(priv->message),
> > "Error type:%s controller %d Addr at %lx\n",
> > - "UE", ctl_num, convert_to_physical(priv, pinf, ctl_num, error_data));
> > + "UE", ctl_num, pa);
> > edac_mc_handle_error(HW_EVENT_ERR_UNCORRECTED, mci,
> > - 1, 0, 0, 0, 0, 0, -1,
> > + 1, pfn, offset_in_page(pa), 0, 0, 0, -1,
> > priv->message, "");
> > - pa = convert_to_physical(priv, pinf, ctl_num, error_data);
> > - pfn = PHYS_PFN(pa);
> > -
> > if (IS_ENABLED(CONFIG_MEMORY_FAILURE)) {
> > err = memory_failure(pfn, MF_ACTION_REQUIRED);
> > if (err)
>
> Nit: pa and pfn calculation can be moved out of the if() condition.
>
Hi Shubrajyoti,
Could you revise this patch with a similar cleanup for the versalnet
driver as you did for the versal driver to avoid code duplication,
please?
https://lore.kernel.org/all/20260415060239.733200-1-shubhrajyoti.datta@amd.com/#t
Thank you!
Regards,
Srivatsa
Microsoft Linux Systems Group
next prev parent reply other threads:[~2026-04-22 3:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-29 12:44 [PATCH] EDAC/versalnet: Report PFN and page offset for DDR errors Shubhrajyoti Datta
2026-04-01 5:58 ` Prasanna Kumar T S M
2026-04-22 3:59 ` Srivatsa S. Bhat [this message]
2026-04-27 10:47 ` Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aehHkO9fhiyoxf-e@csail.mit.edu \
--to=srivatsa@csail.mit.edu \
--cc=bp@alien8.de \
--cc=git@amd.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=ptsm@linux.microsoft.com \
--cc=shubhrajyoti.datta@amd.com \
--cc=shubhrajyoti.datta@gmail.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox