From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3655B1A3164 for ; Wed, 22 Apr 2026 16:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776875121; cv=none; b=HnqgPvOJiJal7bQpcmzetJolJnmGTVTdkXRNSWiUSRASkUSEvtGgV1UUdcemXWOP8s6NWORVT3HsWSGQy+FX1C2lsI14y2cA5HYF4HkSvrZ7oQd2zC6aYfDlm8YaUFU3HL6E2frwErMf6emlEmYpvPqSI1fluBIQ20MpfxB7t3s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776875121; c=relaxed/simple; bh=relbCsxTarhTN/DEzWhHsVEnDfMzmaIQrETkxNLHpDg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k4ZEWG4Dzo+hLxVX3KOWI76GHh9zirJu4HhePnfX0fzQc+pzFAnldjV+Pyd0dcQdwgUhNdHxFuNuIQcga795Zq58l6i6FYQGixqrbEVGvxSvAwgncG1WPG9O45vomOrZAc4SJc7Gm1UmknlZNyf6nWgBHnqYPn2whAELRszEJD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sn47eyXK; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sn47eyXK" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4891f625344so40614935e9.0 for ; Wed, 22 Apr 2026 09:25:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776875117; x=1777479917; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=5/XQOT4wkfrl5gFL1ciRkF4ytLnsNeqbo+o9raOSWLA=; b=sn47eyXKgOtGENP5oh7LALWSVhCJHteISgjqg0y8vN0La35PESTrpqxT9CDSja/8m6 wBraoTRnzCWAlv9XmURJ7gCiwKbIYnWThMcLLmg4w0nV5Yn/Ou4uWN2RmdTWtzqpz4oV yySK63EFabOGs9CNhgSKPTi7+lwazKe7TPHbCuoVLjNwUk0rWxNZy+Y4WtW2bL7V+o+a Evu6tBfLj3KShg378jzeb7/azw+oArNg7vY4H5NhuRkUT70GISmZc5aF525AVCUoyb32 CvM6Aw9h++/F0vN3UnJ73SogQtiRPAlmlZpFhHYKa6rp0efIbh2eoaP2GqkF+GYuKxVh 2kiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776875117; x=1777479917; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5/XQOT4wkfrl5gFL1ciRkF4ytLnsNeqbo+o9raOSWLA=; b=Q63vg/YHDsn3G2JTmb7ruKCgjFUws6ANQP7vGFvYd+3fFnQF1Op6mrlBBWNNc2omHd t41G9zRSfPgOr68i/wQ3vFrVCMCpZTHlxhRE6unRZf4PeLv+2PoRVwW+/ZNAK8uF046N Ox98d6OGm2xBjzM2UZpfFOCZdVZkBLtOWgWH65Sw+AcYFr4yE0Sfw4c1aIT/4GWjMpFT IwzaWxw1L3FIKiLiqNuS3GG4RgC/KwONkOqnc/AFE2/1SYP62xOy/vt+6t/uNunFuefB Wtam6sy07E/IR8F6l7XF8vNezhhL+RrKUcBAgKzTBEPa5MulCLsxvDuvfzACoV3DECT0 VpfA== X-Forwarded-Encrypted: i=1; AFNElJ/wtvwVBTM4oG4+0DXJ8znnITW7xXaXoJfNbdsfiGA2S8o5aoBCVEHXkqnG4e6h7p2KLKTpG9GatOLx21w=@vger.kernel.org X-Gm-Message-State: AOJu0YzvjGTLheDH6g585Zv91b58FVIdFfuZnwbtItIQNK1kpnv2dzFl 50agjnLNTort69XvvgTTZ/Bwr/UjB0rC1Ow5yGMba8k5DS2MvusHxzSA X-Gm-Gg: AeBDiesdtD2iH7jq57EHOnHlpQlNuxMdrpr6A50b8Iewnt1TDd2DX9baKA3NIgEBhBD wvYrYBrxqPrJhBdd8TU4L4E4xc9icbCx2ASqIez//TAKz/S/MS1HkF/MQSYT1xK/rbntVVM12u0 XeCiqe7T4I3f+qUd7ApnOQZ+bL8TkYOIUU7QrApB9Bs5WwoGXfbnZMqkTzcaY1Ig8Vl+kJ8IEy7 pqxbanlbyJ7K8fc7s8JZMaPqxF4Blu3S32kn6pnNh32FeIoIrvJuAJHECfGDn93P/lt+VK4Bs3v 4+DCPwwnkM6Zsy0w3BVpjeJ7i8mQf+qY7HPXhlo/LJebiDjFVnT5scTaqXjkDv8FE8aOHiSZXnk ccbnGM+TKULGhSxf6eeoOKoU5PlcEElzRLl4uX9MPFlxrNy9kiZXEHK2Frd2NqdnF8Ayqx1Idbt mCTsdcBg75Fjg4EVyWigx8iJqjU243V2ozj/Zk8AxonLiD0nneCArwJsjzW3YyaYKKlzOZC3eOq oVy7//LtjhcMsHeybE= X-Received: by 2002:a05:600c:3ba0:b0:486:faa8:9e4 with SMTP id 5b1f17b1804b1-488fb8b91a7mr299355075e9.12.1776875117203; Wed, 22 Apr 2026 09:25:17 -0700 (PDT) Received: from fedora (185-147-214-8.mad.as62651.net. [185.147.214.8]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a5499b0edsm147182145e9.14.2026.04.22.09.25.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 09:25:16 -0700 (PDT) Date: Thu, 23 Apr 2026 00:25:11 +0800 From: Ming Lei To: Caleb Sander Mateos Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ublk: optimize ublk_rq_has_data() Message-ID: References: <20260421194744.1524637-1-csander@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Apr 21, 2026 at 05:31:40PM -0700, Caleb Sander Mateos wrote: > On Tue, Apr 21, 2026 at 4:51 PM Ming Lei wrote: > > > > On Tue, Apr 21, 2026 at 01:47:42PM -0600, Caleb Sander Mateos wrote: > > > ublk_rq_has_data() currently uses bio_has_data(), which involves 2 > > > indirections and several branches. Use blk_rq_bytes() instead, which > > > performs a single indirection with no branches. > > > > > > Signed-off-by: Caleb Sander Mateos > > > --- > > > drivers/block/ublk_drv.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c > > > index ef8a0705e68b..5f9b3c3876f4 100644 > > > --- a/drivers/block/ublk_drv.c > > > +++ b/drivers/block/ublk_drv.c > > > @@ -1172,11 +1172,11 @@ static inline struct ublk_queue *ublk_get_queue(struct ublk_device *dev, > > > return dev->queues[qid]; > > > } > > > > > > static inline bool ublk_rq_has_data(const struct request *rq) > > > { > > > - return bio_has_data(rq->bio); > > > + return blk_rq_bytes(rq); > > > } > > > > blk_rq_bytes() doesn't return the actual payload data bytes, such as, > > discard command, but bio_has_data() does. > > So you're saying that on a discard, rq->__data_len is set to > bio->bi_iter.bi_size, which represents the number of bytes being > trimmed even though there's no data payload? I guess we could check > req_op(rq) here to at least avoid the bio indirection. Yeah, you may add blk_has_data() or open-code it. Thanks, Ming