From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03567221FD4 for ; Wed, 22 Apr 2026 14:51:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776869512; cv=none; b=LVjbHJwDiZOe36q2XnEKNLsAufH0/Zodirm5ZV4FxvY1DzEJ/VhSmWPTdgCDWCNLqiytSYxOPBZkrI4iwT77CkUjeTx87JR8rNyD1k8N+zzltQS71h1QTVvT3hBtb2p+TgbzfYzm2dQY9yxh692WmqnsE2+5666OWwhLpVuMiWE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776869512; c=relaxed/simple; bh=ahzeuw2Fr7v2Q6H4S+tVbXo/VAJSEVqnHn8ydmBa/aQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YeeZmjS7aPt5MvC4lNBhG3Xa2IS4lkrVCAOGfFzI4QfijyuCaaVwlgVqTTN87L6h+fwrfwIMMpH7MSMjZWpI6HPRekO7+VXNwcPgYW6jrZndj+ax1v64lDSxISh9wlMNMXBG6GFwRBr4FCCpGhu7NXvQhfntEVDPtnsxFBg9L48= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mmVGIkrn; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mmVGIkrn" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-82f68b3aaf7so2109265b3a.0 for ; Wed, 22 Apr 2026 07:51:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776869510; x=1777474310; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Rbt+BBcSmg7tGy8kUDRFXyu/cUFZjBGT0zn2Cx7Dl4A=; b=mmVGIkrnSqCsk4pvbbf4vYCABl85xSKDXsXwh6yLjGT/D2gFxpj5bPmXv7jmwA1NH/ ebk5wuLJiOKpspb05w1dVE/FkBGbo7d/4BUF+0E4Mia96+Kso+6WFRU4v7oJ18m8Nrou tSRTw3svC80GEY3ivCK+HCLnW6+dxZcWi8AEwkoDj+5kYKIaR3H1mDJqJLpGD5NIxQlE cOR5XN0wcLw6nFQxkmD0sRVVhdzfW8/PbJvL9Z2zuf8slAhwfPQZjkDPed5dtO3BnkqC fBmfUrCLzaz5/iPn6Zq3lfpdTe/pXMGhrS8DDt4IFRPxZzjGZop1KcBNLdmU42XBXE5/ qDbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776869510; x=1777474310; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rbt+BBcSmg7tGy8kUDRFXyu/cUFZjBGT0zn2Cx7Dl4A=; b=oLdowDpXYiEE9aFnS7bNvkAkfN+EAErT1jpPBgHEnnbperQGNgrMLmnZgJx9c0W5X6 oD/T/r/KnHwlmySlcKM3jAzXzswbjNtTYjV7AYOjZkSwnEtIuZibPaTZCmkzdMjYs7tI 9uf+NAk58ADhTFwjJgDsUyV12h/Jlb7iZ+ekLyCl4K7+mjjLyLmavyyQ75CyBYaPB33R 60lA9pKZ8C+EeUnEZCLNPxrGKuRK4CZREtYhssjPbZJ70+4cVOmKqHgzRDM4kYhiV918 kvLK+ocRHFF2e9dygb4MqncdjJbMPkFMrdZrpZ/DlKAhWKCcsB53ULM4+bNvCKcZLyuq s5/A== X-Forwarded-Encrypted: i=1; AFNElJ/GxgqcE5Btf5YDuqnN8pGMVr6Ylelw43C7dfW8wK8BpPiiC52noDIlSOMj2GylK/Wm0++6vChreXUCYEk=@vger.kernel.org X-Gm-Message-State: AOJu0YxdYMMaM7CQlD72mUxfzs1m7dnAjDta4mRZxG2gFJuogeUEXxJq +mdAlT2q4FXiChAnDw1+Rw6HcfXeOaaXeCqyhxcAUd6BI9h4RnMUbKZ8zWakJrmt4Lk= X-Gm-Gg: AeBDieuHMC0sd9i/9kQ4niuVllCVOGEcsaBvuALq1AlJu4zNTmO+b10JNfOfP94ayhe RKxOq7EpqUZk7r3zndqgceahvubZj+YO3874Lr3jh7VxTSR2VpeinW249grS5FQpKTwkHZb9gv6 JjYxEC4gxr1PID9K9wMZjLKKY6Cuwlb4TjtuQcKgIdnddrhQ1E2okSSpVcRrjlqF7Ms8DGAk4ju YtEoLDNhAhAuEyyvLgfJOAqtSCKU3F8boUGxpnF2i/cUrzNuUUX69uTh9Yjmoaqw6ExQyZCWCTk Uammto5XH/qHAVngSWWifRgXQpqMfcMFsDStxR9+qrOfrX0bTkI0SmffFG6Q5faZITPFq3hy6pj Pq8ZA4zkt+IBndD4foZy5Kpg3k52vMx8GIYdSh5p2EIohr3Vb1Y6APShII6VyJnVOWuHkHu2Fef BQjuLWU5PjTSg5wtc9TWLmlcxTtLR1GxbjAbtt8A== X-Received: by 2002:a05:6a00:1bc4:b0:81f:4a36:1c7c with SMTP id d2e1a72fcca58-82f8c8c5b5fmr22866132b3a.23.1776869510056; Wed, 22 Apr 2026 07:51:50 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:fd65:9224:aee7:cdd9]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8ebe68ebsm19470018b3a.47.2026.04.22.07.51.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Apr 2026 07:51:49 -0700 (PDT) Date: Wed, 22 Apr 2026 08:51:47 -0600 From: Mathieu Poirier To: Yuho Choi Cc: Bjorn Andersson , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] rpmsg: char: fix use-after-free on probe error path Message-ID: References: <20260416042338.10146-1-dbgh9129@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260416042338.10146-1-dbgh9129@gmail.com> Good morning, On Thu, Apr 16, 2026 at 12:23:38AM -0400, Yuho Choi wrote: > rpmsg_chrdev_probe() stores the newly allocated eptdev in the default > endpoint's priv pointer before calling rpmsg_chrdev_eptdev_add(). If > rpmsg_chrdev_eptdev_add() then fails, its error path frees eptdev while > the default endpoint may still dispatch inbound messages through > rpmsg_ept_cb(), leaving the callback with a dangling priv pointer. > > Avoid publishing eptdev through the default endpoint until > rpmsg_chrdev_eptdev_add() succeeds. Any message that arrives before the > priv is published should be ignored, so make rpmsg_ept_cb() return > success when priv is NULL. > > Fixes: bc69d10665690 ("rpmsg: char: Introduce the "rpmsg-raw" channel") The SHA should be 12 characters. > Signed-off-by: Yuho Choi > --- > drivers/rpmsg/rpmsg_char.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/drivers/rpmsg/rpmsg_char.c b/drivers/rpmsg/rpmsg_char.c > index ca9cf8858a5ef..549a24b70884d 100644 > --- a/drivers/rpmsg/rpmsg_char.c > +++ b/drivers/rpmsg/rpmsg_char.c > @@ -11,6 +11,7 @@ > * was based on TI & Google OMX rpmsg driver. > */ > > +#include "asm-generic/rwonce.h" Why is this needed? > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > #include > @@ -104,6 +105,9 @@ static int rpmsg_ept_cb(struct rpmsg_device *rpdev, void *buf, int len, > struct rpmsg_eptdev *eptdev = priv; > struct sk_buff *skb; > > + if (!eptdev) > + return 0; > + If this is needed, the same check is probably needed in rpmsg_ept_flow_cb(). Thanks, Mathieu > skb = alloc_skb(len, GFP_ATOMIC); > if (!skb) > return -ENOMEM; > @@ -490,6 +494,7 @@ static int rpmsg_chrdev_probe(struct rpmsg_device *rpdev) > struct rpmsg_channel_info chinfo; > struct rpmsg_eptdev *eptdev; > struct device *dev = &rpdev->dev; > + int ret; > > memcpy(chinfo.name, rpdev->id.name, RPMSG_NAME_SIZE); > chinfo.src = rpdev->src; > @@ -502,13 +507,17 @@ static int rpmsg_chrdev_probe(struct rpmsg_device *rpdev) > /* Set the default_ept to the rpmsg device endpoint */ > eptdev->default_ept = rpdev->ept; > > + ret = rpmsg_chrdev_eptdev_add(eptdev, chinfo); > + > + if (ret) > + return ret; > /* > * The rpmsg_ept_cb uses *priv parameter to get its rpmsg_eptdev context. > - * Storedit in default_ept *priv field. > + * Stored it in default_ept *priv field. > */ > eptdev->default_ept->priv = eptdev; > > - return rpmsg_chrdev_eptdev_add(eptdev, chinfo); > + return 0; > } > > static void rpmsg_chrdev_remove(struct rpmsg_device *rpdev) > -- > 2.50.1 (Apple Git-155) >