From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013069.outbound.protection.outlook.com [40.107.201.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCCA932B9A8 for ; Wed, 22 Apr 2026 15:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.69 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776871795; cv=fail; b=F71ZMjZiPkYfGxGhrhZultz0fbpgBI6rJZulTUp4QL5kNyGeCg5hr4Xm0rNvjt0NCJB7BgLHkztw7Ggk0djEe1Y1OKCSccRlaKqoaOrZg9eTwVlldCBGRs/+rkmC2QgTr1tZgu2NS5q3MsRkn9CiPwWKyqItDwW6YWQrzIm2u74= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776871795; c=relaxed/simple; bh=giJbQnDkhQ+tn1lTUBAbu1ehzclLSBchwIhTOyKWzRk=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=sJngp3zAtO4sqSlpqezHSwYysQFHNeVY86Jmm1xsW20BlSzIK1Ps6YdsoR6kuxexuEnYaL2M576vzP4iendpdnvERaUVXs4929YRrDs/VzCsjWNeRG/RcMacZMsRp+m1iWkxah6gdITsHB2CznXr+41d0Y8cHsApY5B0fA5DCLY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=sJME74Ah; arc=fail smtp.client-ip=40.107.201.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="sJME74Ah" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=J0Yai1o+322+LQ4/XnNvqpOhQP0vAIc2720GuNslLqHYxgLkUJVdF/dwJgx7VngdXGGzFYxxFEWcFOkdWI8tCv7iN+nifsIEtQCI1thYR46XTwWODc8vaFfhK2lR+98U2SQVfHWi+IymxpRT41yhRz6yle7/P0J6vypy1GqzWhBvm3GOQlQBXdGEqS1mVJnThL1ujue71GHuj6+M3pO25X55jODtwL+U1m7CT5kHtWivGEQGOOjzeFVt8aajIr1Ej7G1vqAu5XB/nAZBmu5D9aMlgfgHCgpofxwfwtDluJssXca2ZK7FIXTMFo5m48WyBCn/rd/nLtrq2KN5AyQqFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2d/OZzw9Kmvspw09iU9b1HiTprewY6Ln/VP8dtgmoRs=; b=BO5iQUnbdY/Uy7mhZAdhIH6WNgs8UMEZrOh53LWCoTJc/1QrO2n6mRoQFZKHEm/0aWJOQmbnWS+4ObOnM+yDrdsTTc7Z07NkyUOs8pYSsMz4kRrtSHp9vQVlIUTbnNkvE2ppl3AwPLfVmxCBl4+piyz2+bQOLi4PkKBFpj1ZvMJz4I3K5rsm7dJGXlY3hmBkXvRbYua8cocOV6oP3JWSmF6QzRpYwy/KKqymHkORBoxkt+GpAGligt7lSZ/DkI3cTXfupEPKqD59s9OgQzmsxdYtYJ6Dhv18xZ/qXtbVV2PBjr0V9r4rrtx3PQlcL3iaVouDZ8zUaj3i9kP5a46D6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2d/OZzw9Kmvspw09iU9b1HiTprewY6Ln/VP8dtgmoRs=; b=sJME74AhmamS/YdSyZIRzXnznQrOTG41vu9+KpgJF7oCmcfBK+nT9KgN2eewwtdxHrxh5PTVgCGfST8zaY+/6baDX2BIj2LpYRm/2s6xigx0E/bVAWjD/T1TASIXM5ypFrijEotRUNopTGayv8pSiD4n5AoQAg2LSHsDe6ooV0xkt1V+GRzBtjrbMhLHVbZukPj0Plb+PiEPQvW8atFpRw8ID5tgviInXJIWcpQRBPhnTi6RbtAgmg1/1XBB1o5CDVtGeA2rZf50jGys2W9l87jCWWi5xsqGYHL/dE+vItuYO+qXzp8wSoljdWXC5w81MELXiy018JxHqv3UIut/aA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by SJ2PR12MB8652.namprd12.prod.outlook.com (2603:10b6:a03:53a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.20; Wed, 22 Apr 2026 15:29:46 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9846.019; Wed, 22 Apr 2026 15:29:46 +0000 Date: Wed, 22 Apr 2026 17:29:33 +0200 From: Andrea Righi To: K Prateek Nayak Cc: Dietmar Eggemann , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , Shrikanth Hegde , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] sched/fair: Prefer fully-idle SMT cores in asym-capacity idle selection Message-ID: References: <7313ba07-7b87-447c-9c48-2f6b2b53ac94@amd.com> <1230f5df-470a-4e59-8c8e-fa159a6fc093@amd.com> <3cc4d887-f44d-4fe8-a57a-73f595647eab@amd.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MI1P293CA0023.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:3::9) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|SJ2PR12MB8652:EE_ X-MS-Office365-Filtering-Correlation-Id: 962bbd15-83d8-4f4f-e3ed-08dea083fc0a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: bX+g2v5w+n+UMLFZVX8glUkcIgvrUWpi5P1LdkEymzAgJeHXmMrmMuYUW4KAXABwpfjYryojYf/axXn/vOBP5iIE2EtlK9AFpmSc2k9aqpA1TVP0i0h7i3JvMYHjG6S0qaOeRi6RYQ+pPDCM5kIRa2/wSqKFnQbjwhQh+aqT7UcB+A5NCAs2sVCg8jn+838XoBZddnfYDZSF1mpYJf+F67YCsB6T7sSFwcnuE0GU8xofKDv6bn9n7a7Bm9neghfzC3+J7eHd4X2Acm0hsVzkj5FYJqSCaD+le5dnq9KfpAWKkkvvBfuDgRpfJfvnJI4eukLr8JiokBcPs8WpiKTxo5evIVgn4vtRiVxN6JWqmOMxpGeqr9R2rBOELBP4Dq50Te1+pzBHfCEBUM6YYVWKC0CaXaJVW36PWH86uDkrL6N1YEiwkwebRG3NtLNV8gedeAkkB4TdkdzP59lBDRj+UUTdU980PedSTQF7NsabRSXZVqznUL3cYrR0w81dzu1ynOAOuq8B26SpgrzVRCm697JoOfp4bLjjx2XEyQqvNqia2PdRM+9sh9dMjeGhoRIiccO+GW23hygBWBVQrN87+cAe1H9dRAcuz3taBWKElWDCsWMtnROogzwWWVXVEuu6VM4YDS1eUiH05NuSbT249GU1ufqC5T4qgFCu1Whkl4WcZKJmhCaEd6dNhjaPWWZHRTSk5Mx0bO24lW7rtQpve06rMBFydHoZTCiEQH6XtIU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uBEOpvo4CGkDCSpXYira9YwOvSFodmNjC/4RFO+bRP8VlZVAupnc++shqPER?= =?us-ascii?Q?jsh2I9hzZZItWxq1ShhDbzs52HvTMrzCeOIF+c6dJ+SHlqfEWiJjBRTuKqlC?= =?us-ascii?Q?PsbddOiEQGveeh2BzMEmA1QuzA8FJ1/A9FiNmwpRIp8ZZrxxRCeeXJMnrDX0?= =?us-ascii?Q?U5nKzoDSp3vk1T1KA1GwB0xoGtDirhZCr4FzJlCtP8VO3avbrPbfI+n2wLpE?= =?us-ascii?Q?/I+M/6K1PED3MP5Fn5dL3tB2Wd0cDO4D1cuHXEMpZH1ftq7g/vtI00jxenhl?= =?us-ascii?Q?+NFKE1GKq+oXhJ9H7CCp+DDWL8A1omx9isPhXA67LxPgIinzeWu2ckYb/TRf?= =?us-ascii?Q?bweOQ3tY0eEEuvQFjVOMgpq8h7LEw8qeNyAxPGknNlAoT4I0N1hyxDLcbZsW?= =?us-ascii?Q?InvQHBaroHa65AIUQWkAc6J7F+/XeGsgsNaVPPp1lJNvBDqdTcgS1ffK/C9+?= =?us-ascii?Q?Cb4brHIb/UNZFhQC2SyQrnAEPyZMY7pANrL5Vsvhxs+hIzOubGtYIsfnyuX7?= =?us-ascii?Q?kt3emBLvLGVaGsL5jh6i63HBSVx5IUt3aTkh76xR82/PsWpQla6prFWyZl96?= =?us-ascii?Q?vpzpeBpZcP/SaSMyPFW/GU1TF66gxYrp0SjmkZhPfa9YcFhlAJbRBYJxMMyY?= =?us-ascii?Q?1NJrRnmjlj+krnLvmHuMr34rppJzQyQU1dim1b5lLUiOnXupldyNG9ZVcT5O?= =?us-ascii?Q?3MUXHwPvobvz0IQ6OC4sbMous48j1w5QOgSAZHbNBlizcVBvg680nrEwjq/a?= =?us-ascii?Q?4RG0kWHA6zlcYhzi83xmd5RJTJuwHOgJoNNbzV11QzB4F/UtSxkw4mVUVtK7?= =?us-ascii?Q?PcgIyV7pyJx8Q0FJRQbc+BqHliSh95+T3zh6Hu0GptagVMdQ/9FwbULdgAX+?= =?us-ascii?Q?cWUvmUhZa/LRZPcH++NONuvBIsvipkHXz4CNbLw1+BgjGFS8ElPxzh5uJiSC?= =?us-ascii?Q?DQAT4sACBq2AsD/21xAkgFcb2pJUKxBgnNtR9kRC9qEsi3dxKCRHqalEx4Dl?= =?us-ascii?Q?ePeJZqnF8lO2dTauW9qOBjbWEqiC/2dtv4Q0CkaEDzxAyvFrJoZ+wJv3wFvU?= =?us-ascii?Q?gggNW6692KecS267xOFSX62SUj+R5f7g0pYosELyzyIbDafToQV7IaeM6mwk?= =?us-ascii?Q?XO/+AQ0/vLXb0gLLIx9iuQy+p9sSRupIrhxrF0xwoGj5atZoAsT+V54/vvYN?= =?us-ascii?Q?e3lmLFeybG2BMweCJC04q3x2xb73ifGOO0kwo4b+ojjDYrBMLWj7v/lA8LRQ?= =?us-ascii?Q?0OZnmLOLhokn619Bflla7kgODEMebRH5FQ18+PJwPhcV7hE8UeB0lTfm7ppp?= =?us-ascii?Q?qFDYfK4BDS5pfdoulVHtwqT6+AHjljWLOGK/+OaqAnA8jzfxeAXtlNGrBeST?= =?us-ascii?Q?IczvA0UEh0x+gznzKK0yAwBd2Id5/cG0m23K/RnVqH2RXr2xbAu/F/ByLO6Y?= =?us-ascii?Q?hlcOEDc7nWPk+5g2CywtPCQ8igm+DW7LjokJgZpcVP9uji/i/fo7W+t1xBgj?= =?us-ascii?Q?GDZpG9bDkYFxDKfWZh015tnB/6t2kqNBp3cxNi6mLsm/K52WDGMkqrhna4mF?= =?us-ascii?Q?ifrtXya2B7/vFg0Hfdzn42v6Q+2GkRJ16mUtqwVvNfyU9xGtMa8YvJK5ntzx?= =?us-ascii?Q?aAmR8HnTRqE5q5W4m3tCHyQ9klbEAyQeJeCtAqlfRjam7k8Rnn7U/UdgZTkw?= =?us-ascii?Q?i7NLLxmisq1q2tX0AVx14BnZe1Dw62NPLsXrKjQoWq/9dZZgAFNovPmIXEoz?= =?us-ascii?Q?iOkdB+uyyQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 962bbd15-83d8-4f4f-e3ed-08dea083fc0a X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Apr 2026 15:29:46.6355 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gd6jlzheQT7rOTkICvwIR5+1j+jxIjKMGn8FE29dMEeU6HCLut+4u6R52BXiTB4/F/uKYAAs+Z8ApXH1bHhwCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8652 On Wed, Apr 22, 2026 at 09:06:40AM +0530, K Prateek Nayak wrote: > Hello Andrea, > > On 4/21/2026 7:08 PM, Andrea Righi wrote: > >> You can also try "best_fits <= -3" in that last bailout condition and > >> see if that help. > > > > For the bailout condition I don't see much difference using either <= -3 or > > == -4. In general, I see a small but consistent improvement with the SIS_UTIL > > logic, especially when the system is close to saturation (as expected). > > Thank you for testing! I guess == -4 is safer then. > > It is probably best to add an enum of sorts to help distinguish these > states rather than the magic numbers. Perhaps something like: > > enum asym_fits_state { > /* In descending order of preference */ > ASYM_IDLE_CORE_UCLAMP_MISFIT = -4, > ASYM_IDLE_CORE_COMPLETE_MISFIT, > ASYM_IDLE_THREAD_FITS, > ASYM_IDLE_THREAD_UCLAMP_MISFIT, > ASYM_IDLE_COMPLETE_MISFIT, > > /* asym_fits_cpu() bias for an idle core. */ > ASYM_IDLE_CORE_BIAS = -3, > }; > > > > > So, this looks good to me! Do you want me to include also this one in the new > > SMT-aware asym cpu capacity patch series (keeping your authorship of course) or > > do you prefer to route this separately? > > I think you can send it as a part of your series for easy review. I'll > be happy to help reworking those bits based on the comments if folks > aren't happy with them ;-) BTW, the SIS_UTIL part also improves performance on Grace (tested also there to make sure we were not regressing the non-SMT asym-cpu-capacity case). So, definitely +1 to include this from me. :) Thanks, -Andrea