From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SA9PR02CU001.outbound.protection.outlook.com (mail-southcentralusazon11013063.outbound.protection.outlook.com [40.93.196.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1C1ED531 for ; Thu, 23 Apr 2026 01:10:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.196.63 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776906619; cv=fail; b=HxVc4EoJmg9T1VqRxWold1pjjxZrrwjhyAZ5dWH9YKHoCOwnhkOw3Ia6lu+ZM/O5BeXqf8uMcFfD8VadsaBnPRAAozE2zQuPUMwPc0c4xIB6MiXO7qcVKTquaJd0p0Wh9pjrvMJRcLdrhK5YSEnwob7inRftuLYT3C5L0Wj2ius= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776906619; c=relaxed/simple; bh=f06bM8aVkKQDxFqnXNoDcjIY7wEPnJa+EzAAfaYEbL0=; h=Date:From:To:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=DCfKFmnbsrWC4IpWPpCHxSx+1hwWLocOjw972YzUh9nUC9OEWFhMOr51SwhipI2Kpt7rEBJUQzazzUtg9rOqMlYPIJrbONx2r4RBN4f3SaCDeHm9VZ6QQcL5Yfdr4fNH8DC+Q+Zaw/Yf9DO2jYZ+TkmuUyEQzn18pa8QQsxJGxs= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=sHsG11cd; arc=fail smtp.client-ip=40.93.196.63 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="sHsG11cd" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KmgadgIPAeooFtOsr0B0Zsp0p9TclpfCNxfL9FsB730WaUB/bWbwZfmhUEeCHMBrayyMDp09O/qK4dZjdN5Q6uuzF1aMHIjvGHyfRVbolw76/tiTWWm75FutgQf5ltN72rcAzg/egHRiS8Zxnr8t/Gc5ljZujweNmONwetQ3ThX86xLrA8PdqasXj+SV/fXqV94u551xSQPX4BAiLv1UWgJoOoNZxDqQWIfMt9+or+s6MHmzBcbnZ5L7fnnaBVyJK41BQK2xShyrrP3GXsPnTCux0UjADIfw3O8iFIGyHe/Wb2leiLWovbv9ej6rUYf64SDu3JZdQneP3TRo2IQNjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xSzXHM92RMHb6rEPBDG3xUz1eMmgZGklfyHKI2TO/x0=; b=FXMws2hm0ZFp2OJUBBefVsrcIvQlSW8BYxpfyw7eVSnfkOTx5En2pAn+OuVZz9zXOOAiX3E3qKl2RRooouuCFY4usZ6QH6z50wvfRYXbFrlO5llabqVjt0DtVKPVFW5GjDe8dcB0WJuWjkJ3aTMmmmI4VImFw4WvAFt1XItTUbvE6Zzm+M0E+nG66EJrb2i26gKSVwmpjTEUfVarBibHgY1fhcLyLtLYlpJjso403jxLvnuFrNw/xsiHwFSVmZaNPsDlG+z7DFhFQzS1KNUnbhWIt1+rv3pGUIxk2VbleEbjBPSbLkbT8bnEEcT2M7uq2JakzLJqVntCHkV0zfyGkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xSzXHM92RMHb6rEPBDG3xUz1eMmgZGklfyHKI2TO/x0=; b=sHsG11cd0GloBWuod0veF2zS6pKyQQ7Fwf8LPFDTSfw00p37UlOwXfW9qvU0gk9Min1Nx0hd1jUU0VT9n/82VZHF/DyNHiAQMd5Q0du78FgtwKlBEm61Jy2gcV1LsLC1FSRaLwg2xUotVRw4TlJQJB3UfllaSGUCDrECXfTA0DWMbTBbwa7ANATH/gq6JrUWRZ73vVF5Pgo2zy8djpsZ8bhAg88d2JNN0vjF6syJFobjKq5I4uh+Len+EswesITapi6fDDfAt9h214Tr1VTO7tvDahxflSpy96QfXOgGjUjA7v0GFhTmJJ+XggYIpC6QRsFpJhOOHU3Hc8OKgOPUjA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) by CYXPR12MB9279.namprd12.prod.outlook.com (2603:10b6:930:d5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9846.21; Thu, 23 Apr 2026 01:10:13 +0000 Received: from CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de]) by CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de%3]) with mapi id 15.20.9846.019; Thu, 23 Apr 2026 01:10:13 +0000 Date: Wed, 22 Apr 2026 21:10:11 -0400 From: Yury Norov To: Valentin Schneider , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , K Prateek Nayak , Yury Norov , linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched: topology: cleanup comments Message-ID: References: <20260401145654.16241-1-ynorov@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260401145654.16241-1-ynorov@nvidia.com> X-ClientProxiedBy: SJ0PR13CA0228.namprd13.prod.outlook.com (2603:10b6:a03:2c1::23) To CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB8300:EE_|CYXPR12MB9279:EE_ X-MS-Office365-Filtering-Correlation-Id: 0bd3be46-a87c-48f9-b61c-08dea0d512b2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024|10070799003|18002099003|22082099003|56012099003|921020; X-Microsoft-Antispam-Message-Info: dS3CanQMuzmPaq2oqJWefCI3QTgPCVZvgXujKnOVuYPQ/wAuH/XsISHmRRjdeuhSrDda2UNWVwZoY+rh4TKd3GVz6FQOC5JRotOtNDYao2p9WklZuHjeA3sMoDA8xNi2bRSPQmclRpIsVoK96Zc1T17ij6WDMwW7HWGKkqCzV4HD4PTSN5HZRjBuptznoTjQvWi7J7N+8otJD4dpPsZbYNug4jFhzVHpjOBmO1KCsLdqRqj8Gk39iQBKszEjnI3qDQlf+yaJZHAmnjTR2ErznPO7SMZrKj19BQ7ZB1GDwANShAD+PjVSogj1lEO4TUkt2sd68Ep8BSSut040S4kWbgYFPrL4MjHi3G0ursRTFhiVmbAUCRswXlEnDtjdSBKKOJzpioJWj2Sba/TCCYxoqZOQ0NdGTFgVFcvTj72yX/3iVyywwGA8YGgMuDxJBFkOd5p1X8bNdOTuVea0R+M7xgUwlTUlDX2dmc58tqKMgGO2lawQCAF5EjRNro2pNH5Q+w8eDq4cV3IU55OWnP0axIk7b8F/CLNxB54vnaOa7/1NZEDdOY4FXKEBZ6KfYZGGqWchlGRHSRu7LOemP/2+I+jzEXzx0CAsagEVx2dkpE3aBHUqHTM5baaI4K2VHSo/4AwXi8U8Fz4nwvAl9tP3M3Lg+ljvoDDfIU+JiVBYlIoEjR21XBrh6gkEzRdC9WJJDHyBJ5mPAbK9xHEE37ecwmyfNjCxks2BFpaPN2QVMRwP1NIZorAOw39/ZOpqR06eYZpbXtfkl9n5s0mIANljxw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB8300.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024)(10070799003)(18002099003)(22082099003)(56012099003)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?pPKslLCzPtS6daSCKEJeov0sjD+zGQxIRS0x7LGHf7P4OXNN4+Q05jnNm8oo?= =?us-ascii?Q?kzSwMfg0zx0HVsJBkWEfC0mkh8sjoDoY+y+kCBMby/0gYEJNLzoPmtkTm5ir?= =?us-ascii?Q?nwcmXCZ78tUspUXuG4Fnwf/V0ArIrBfVRvf1r7z1tA5+dF3MM7JmFohWtk48?= =?us-ascii?Q?QO/Qy7XRp7txw8uSJW6C16nj5NWHLVcrlZnZ0OQtrDQ9U8HU/uTlZyh9LVxB?= =?us-ascii?Q?MzSVq8198WEK1xzIhV5yqUsReAqAFiqBRc7hAUI4+zmqSWN8OjSC2PxKPNNh?= =?us-ascii?Q?6kyzZlPWf7JWHWFh2FOXtkhWl+yFg9224KtLxsmhGPdVC1WilQliFgtE0UgW?= =?us-ascii?Q?fc0V/wBC6zQ6iKA6R1quYrSjGF8JEVvGrcVQeJmyLoXHpSze+0AcPykWyzng?= =?us-ascii?Q?q657mY1+ySRvvz+/EVKUy4x1r1xqOVJCZUgYQmtYfnjICejfNi8jNrWIblKi?= =?us-ascii?Q?/Jzh0yW75BE9zzmBShtteCkBxxxHgs4b/JEpXHEvGswhA2yRvP8uv+gk/hrO?= =?us-ascii?Q?ybJts2Dc14AvjMnzG/S7aT1lV4ebE0RnKzbMZwLi3UmsuHKz8vvj6N7RLtsX?= =?us-ascii?Q?FocIo1stjBe4+wv8JaEmu42rYH/neRvmflqWpuHOshOhcADHMo2t4YVSgx+v?= =?us-ascii?Q?eKbCIryAhPlqCl1rn2uCtEW8sjAYZKCeZ/NsyCPI3T1n5Xehc5MZfz9JsrbB?= =?us-ascii?Q?Uv9/WBw+UtIiTCUsJSdL9UmEZTzzNT2qw6sza8vaiZCPBumXEMcI1mHxSfb7?= =?us-ascii?Q?t7hb/hreA0o/+vtKkzVOw+gEb8BRoP/dj+2g+SJmokj0nDFJwnF+EpSt57D/?= =?us-ascii?Q?Hgcg7cvLRj6DgxhHI65ppHbdM14DuzgeKrFQGD2hfOcfFsT4MIlutTxGyc6K?= =?us-ascii?Q?sI2q5Q5ZoZcu8TXkWpzXI+cGsr6x0AOE33GPWNJTVkfgs+WfLM/oa7wDSJ1R?= =?us-ascii?Q?B+9hYzMwCVbZEP8fuuBwOfgYRZx0eY6dgJhDP18r6LFWYOTOtltkOEOlv+YE?= =?us-ascii?Q?knDJl/h0iNot4igleEfUP6Q3uXuQETozynm5ETcpIemCzwDe0gX1YCcRb0aY?= =?us-ascii?Q?Qi+YRKj5PiczFWh2Ybm3EnMN7WDmFTWu0bFaDqG72zqVq9KOKpwCHql5Go2N?= =?us-ascii?Q?BHNG3Te6sEfCmQz720wdOs9D/mYmtdMJitq6YtDaWrS3PoWOquix3eqjDqI/?= =?us-ascii?Q?B7/lUxxHrRKqj8NkvjKp74hU7p8t9hu+eUX6EqnQSxLIgD9KyK0MEiyUIUka?= =?us-ascii?Q?Hs6MxJlsEBbazVOwqT3cPTF3FgWm22h1rrQr+N0WZVlDO9PSp/OVJ0iXwlb9?= =?us-ascii?Q?BBc4IsYdqyuyWABtIx75l9ETQ3V75dr3386jmQT5ZExetupbdbrgbcSsTxbB?= =?us-ascii?Q?zAa8r0ue6hff18vwzVk07mdNDASTtrcYnN/jlRjMrDgq6wig4WTh4btLuEIq?= =?us-ascii?Q?zGGVk5VprYdF8vjWHHzQ2izQFWFJvv0GeQnWswtKq2TvqY5ydPLaWOvkc9uB?= =?us-ascii?Q?CKJppQs0eP4N6E579xu2Ur5+3QnaVg3roqaxTq+fgLtiJ77y8GIVEh2aCZa/?= =?us-ascii?Q?6pP9xpeYQwph831+U2nxHvYJXOktpjW1sWXQwosaeTKAyHdaK6yIg0VQRuSY?= =?us-ascii?Q?3ge0Gq04ay0D9Icqm5u3jmCyo+sKNmqS97xhlwOVve5Y5kbgBPYLIrHNnDz2?= =?us-ascii?Q?ao2f/jpZimGRzoT3A29zemgltEdVhTqiZgRLj7tz+mcYAfJ2zb2BHqJLle5c?= =?us-ascii?Q?Nwzmh6LoEP4zOWS46/VbEficlgD4VCFr8GEjcNZMskNxSgpsuuWu?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bd3be46-a87c-48f9-b61c-08dea0d512b2 X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB8300.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Apr 2026 01:10:13.7354 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5guvVuJIBmSFfjkBN8WrqglsPs3tWWGGx6C4fhlFkTRpZv8IKC7D7wtyTbAyF0qSVJeBSiEd4jjZ4QGQKLEekg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9279 Ping? On Wed, Apr 01, 2026 at 10:56:52AM -0400, Yury Norov wrote: > sched_numa_find_closest() top comment is almost kernel-doc formatted, > but doesn't appear to be a valid kernel-doc. Fix that, and while there > reword NUMA-level comment, highlighting that 'NUMA level' is a synonym > to the number of hops. > > Signed-off-by: Yury Norov > --- > kernel/sched/topology.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c > index 43150591914b..1e7b89ad6d11 100644 > --- a/kernel/sched/topology.c > +++ b/kernel/sched/topology.c > @@ -841,7 +841,7 @@ int group_balance_cpu(struct sched_group *sg) > * > * We want to construct domains and groups to represent this. The way we go > * about doing this is to build the domains on 'hops'. For each NUMA level we > - * construct the mask of all nodes reachable in @level hops. > + * construct the mask of all nodes reachable at that number of hops. > * > * For the above NUMA topology that gives 3 levels: > * > @@ -2237,13 +2237,13 @@ void sched_domains_numa_masks_clear(unsigned int cpu) > } > } > > -/* > +/** > * sched_numa_find_closest() - given the NUMA topology, find the cpu > * closest to @cpu from @cpumask. > - * cpumask: cpumask to find a cpu from > - * cpu: cpu to be close to > + * @cpus: cpumask to find a cpu from > + * @cpu: cpu to be close to > * > - * returns: cpu, or nr_cpu_ids when nothing found. > + * Return: @cpu, or nr_cpu_ids when nothing found. > */ > int sched_numa_find_closest(const struct cpumask *cpus, int cpu) > { > -- > 2.43.0