From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F637364954 for ; Thu, 23 Apr 2026 15:09:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776956982; cv=none; b=rFilXhwYSLPJOMHcB8cdzkQHUEz3Wnr0g+Y0MxEy1pz8GwzD6Fge1TZ7dqlJfQDjiKjuujyQQVIUSNx7/yc+kGRbB4WmILGYpKAukrVFiK8pktPHv0KfdFOcl63RxD/fgspI//Di0ddqPO7yj+HYlzUj28FUYHiSykbjg6rzCDE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776956982; c=relaxed/simple; bh=fAk/H/P5kUVb4f/sC9mNVdxg3zeLOWSvVSZAeYbxyI4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BTHYqphOemOCLoqwyBDlx+7zM3bsud+MmDWloOd+i6DSj7keaEuwmSg70ppBuEL3Onw8VcUVeHSI1z0fHhPhbardq/N84zphorkhV272EsuPXOxkoFH343N/k6ms6t8AXiamFKTjh2Nmn5dvCGFa3LyQrXCex7FDUkEsA0+iVrk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=abXU6I20; arc=none smtp.client-ip=209.85.128.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="abXU6I20" Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-78fc4425b6bso59048017b3.1 for ; Thu, 23 Apr 2026 08:09:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776956980; x=1777561780; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DAkJRbPnqB7pwOh2l5JQO+WRUaBhz28RcGSRyyXQT0o=; b=abXU6I20vbg5pk0BYBA8F81JLCifvkwlU20h+oDQYYw4p47hm5X2fA2R5dxnc/J1t7 7N+2dDswN1C8hr87YL1MIcq038Cd4pi5NQ7ed+mMEfwRurgJ0QwnVFDe0/WXWy2oCfNi 1/BqaGspECN720Jx/iBCLHZlkDC0ZB7jqOVtK58+WhZ1qbQjOMbLehZoEaJZElPKTfYJ UBX1QIIXUTbxicIPkw2QV0+QP4NJMvwv/Dh5Mc+qeqnzboZVFfZm51DNIKOShWF0Bm/T QECo4WMb/PXHj75jRCl3yF0BrBketw4caK9qZiLXRuVd0ZTk30Pipp0rBB8nLb7rWuhc 8bbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776956980; x=1777561780; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DAkJRbPnqB7pwOh2l5JQO+WRUaBhz28RcGSRyyXQT0o=; b=f+WPMJFaLJdEGkRZ4Ewl6DGQGl322eqldw8VAe8QLenjXAOkfTJkicUxlQT+8i3T3E FOE3x72f4jQTvw7doZzu1DtWXjxi+jf2HXPhY8CRGwiqmQsKoFFtDSxCgr4q5oSheCgF zVpLN8jBmu9fF0EFCyNToCzCHK5sW3442tCXbjoauTk5IcXJYrrRGM2Cnxi2EaErATqr PPV2ORAftqbJulK7Rpp+UCYEpg8asTCxscsg1UOujNaUQrPGPeM0ub3NZfr3Ls7sJfzg zi4KlnYM6vFWZlARJyXVdEenowXKJE8L5VzJ+otqdrUFBRcOsOsAIBUsL30ovpsCSIDv ScBg== X-Forwarded-Encrypted: i=1; AFNElJ978bAiWkWoYCrLPGOa12179JEqad1/d7T2iSQr4uRYaxqpnmv1rdQxwEZ8DCKfeZBy+0HDQK3qZtX45OE=@vger.kernel.org X-Gm-Message-State: AOJu0YxCZetbCu2uS1glPIhHLu+a5JIqM7pXn5X5gfaxNhFuP+1WpDF7 rDBx8LVqi5sj57J4QbW2BTc4Xrno3n/gIw/rIN5ULyk2d24gZN1faR13 X-Gm-Gg: AeBDieu8Tw3WUwtoazPzbDkcoXlPGlDBjBwRhLelfVuXSrWUZLOfzormtCvsT4RsmC1 WmezvpJhZVC0fHmKHqhTitKcCRGkMAIWTDzHcheauLBipdQ6eMMWXzQVYXePADA4sk+mzeLU0gR njk7W728zRpu8e5J8VR+VJyAIiG+TPpp9LLdGwrxmymAJ/AVXmMBOzOnHtcC8M1qfsF2IgohTCy rdsEOYWipVfJpuZJbaJmO9OUPIoJU8Y4jVE2LbK0Z5U06bv105d9OLULLAYJO80F8LMfeh7Xfym emf3/dJPEVp3D9wDlft4QcGweVMnc3LXtdJbPWxciaQd/Afwkhnlrt6a0pFxZJ9Iw3Uvffy5d0k 76jyJ7WONT2uSDrmOF4y3F8fx3nq7M9r6su/PZG0ptuClrNvMEL42dgGVFsMyUzEMElAzW6jeUJ 1aAFsIIw8XbIkh4JGyr1JGiY7MY3BW X-Received: by 2002:a05:690c:39c:b0:79a:62a2:b3a6 with SMTP id 00721157ae682-7b9ecf7af46mr282323967b3.29.1776956980273; Thu, 23 Apr 2026 08:09:40 -0700 (PDT) Received: from localhost ([172.216.252.33]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7b9ee9b1c4dsm81858127b3.33.2026.04.23.08.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 08:09:39 -0700 (PDT) Date: Thu, 23 Apr 2026 18:09:33 +0300 From: Dan Carpenter To: deep@crimson.net.eu.org Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: replace TBTT magic numbers with macros Message-ID: References: <20260423141213.720643-1-deep@crimson.net.eu.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260423141213.720643-1-deep@crimson.net.eu.org> On Thu, Apr 23, 2026 at 04:12:13PM +0200, deep@crimson.net.eu.org wrote: > From: Kenet Jovan Sokoli > > Replace magic numbers related to the TBTT prohibit settings > with descriptive macros in the header file > > Signed-off-by: Kenet Jovan Sokoli > --- There are a bunch of people going around looking for TODO in the code and then using AI to "fix" the TODO. The last time I looked at this code, it was someone doing AI. And then when I asked them how they came up with it, they fed my question into an AI and it hallucinated up part of a spec file which they quoted. I'm pretty sure it was a hallucination. I downloaded the spec file they "quoted" and the section didn't exist and none of the information was in it. They later admitted it was from an AI when I asked them to provide the link. I worry that you are getting your information from the fake spec. Or maybe you have a link to the real spec? regards, dan carpenter