From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCBD21946BC for ; Thu, 23 Apr 2026 12:48:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776948533; cv=none; b=B2oRRaMuG9ajwXgTUk54aVRa28alEybCOlaCcXEiPqwZGq4h/e8QTlyEaFg4NNr+K8enbRC4++XJsuuQrWLwLKm1LA2Zuz1MtSgW/tafPpAWu/NXx2/OuLm1KHTmbYbTtT7t65YwfSkJ+bRJkNdV2ZIZg/ncM+hbfSlY7dXUfLI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776948533; c=relaxed/simple; bh=3SulGgN6syejyR5DSaOUn2aLn8Rpzv+efGh0UUrNjqM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KhHfvlSxpSiM/KkPxkFjNV/WynZSzOn/ibNTPZuwo+jJqOKFzgukkOelFZ6xHJD6AzknKsrapJar0u7dlbNajeZTMbUVqDRHletWqIr/pONGwMnWAw6+uwkwP0dY+Cug5Psx1SWcU2dUl+YZiGgap5eObwUy4AVcb/IkQTGkV3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dcFSPB7C; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dcFSPB7C" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60DBDC2BCB5; Thu, 23 Apr 2026 12:48:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776948533; bh=3SulGgN6syejyR5DSaOUn2aLn8Rpzv+efGh0UUrNjqM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dcFSPB7C9SR5oYCDdBRbZyRDWvx8C7coSPJgSXK4GFVU7hAILKsyR111pw4yK7vRy A8iUf0RE+Ub+nWRbQp+8ICIQiBuZddTq1FDANp2EEcWCO9ksP04F6SuWgov5wcnNxO lKu4zgsMsZq91Z7CjOW1OY75o3y7dVbhDPS3BTmIliqtFYje+T+7lplIYqudp/b8IG 4/PZL/3voyuUCj1vvlViifNQ+FCP9pJdWtw/rxXZdomz7qqkFSGtIt/fGPDREnT5kg PQxl7qtU9A9RwQQKT5Xoi/jL6M40v8P+DHgfa5rpJh+wR+SZy6o5TTZOdlbxUaZcLw YyEuEjvZee/Fw== Date: Thu, 23 Apr 2026 15:48:40 +0300 From: Mike Rapoport To: Kaitao cheng Cc: akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, Liam.Howlett@oracle.com, vbabka@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Chengkaitao Subject: Re: [PATCH] mm: Convert vmemmap_p?d_populate() to static functions Message-ID: References: <20260423101441.7089-1-kaitao.cheng@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260423101441.7089-1-kaitao.cheng@linux.dev> On Thu, Apr 23, 2026 at 06:14:41PM +0800, Kaitao cheng wrote: > From: Chengkaitao > > Since the vmemmap_p?d_populate functions are unused outside the mm > subsystem, we can remove their external declarations and convert > them to static functions. > > Signed-off-by: Chengkaitao > Acked-by: David Hildenbrand (arm) Acked-by: Mike Rapoport (Microsoft) > --- > include/linux/mm.h | 7 ------- > mm/sparse-vmemmap.c | 10 +++++----- > 2 files changed, 5 insertions(+), 12 deletions(-) > > diff --git a/include/linux/mm.h b/include/linux/mm.h > index af23453e9dbd..1d76da6e0791 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -4860,13 +4860,6 @@ unsigned long section_map_size(void); > struct page * __populate_section_memmap(unsigned long pfn, > unsigned long nr_pages, int nid, struct vmem_altmap *altmap, > struct dev_pagemap *pgmap); > -pgd_t *vmemmap_pgd_populate(unsigned long addr, int node); > -p4d_t *vmemmap_p4d_populate(pgd_t *pgd, unsigned long addr, int node); > -pud_t *vmemmap_pud_populate(p4d_t *p4d, unsigned long addr, int node); > -pmd_t *vmemmap_pmd_populate(pud_t *pud, unsigned long addr, int node); > -pte_t *vmemmap_pte_populate(pmd_t *pmd, unsigned long addr, int node, > - struct vmem_altmap *altmap, unsigned long ptpfn, > - unsigned long flags); > void *vmemmap_alloc_block(unsigned long size, int node); > struct vmem_altmap; > void *vmemmap_alloc_block_buf(unsigned long size, int node, > diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c > index 6eadb9d116e4..3c35d2303a61 100644 > --- a/mm/sparse-vmemmap.c > +++ b/mm/sparse-vmemmap.c > @@ -151,7 +151,7 @@ void __meminit vmemmap_verify(pte_t *pte, int node, > start, end - 1); > } > > -pte_t * __meminit vmemmap_pte_populate(pmd_t *pmd, unsigned long addr, int node, > +static pte_t * __meminit vmemmap_pte_populate(pmd_t *pmd, unsigned long addr, int node, > struct vmem_altmap *altmap, > unsigned long ptpfn, unsigned long flags) > { > @@ -195,7 +195,7 @@ static void * __meminit vmemmap_alloc_block_zero(unsigned long size, int node) > return p; > } > > -pmd_t * __meminit vmemmap_pmd_populate(pud_t *pud, unsigned long addr, int node) > +static pmd_t * __meminit vmemmap_pmd_populate(pud_t *pud, unsigned long addr, int node) > { > pmd_t *pmd = pmd_offset(pud, addr); > if (pmd_none(*pmd)) { > @@ -208,7 +208,7 @@ pmd_t * __meminit vmemmap_pmd_populate(pud_t *pud, unsigned long addr, int node) > return pmd; > } > > -pud_t * __meminit vmemmap_pud_populate(p4d_t *p4d, unsigned long addr, int node) > +static pud_t * __meminit vmemmap_pud_populate(p4d_t *p4d, unsigned long addr, int node) > { > pud_t *pud = pud_offset(p4d, addr); > if (pud_none(*pud)) { > @@ -221,7 +221,7 @@ pud_t * __meminit vmemmap_pud_populate(p4d_t *p4d, unsigned long addr, int node) > return pud; > } > > -p4d_t * __meminit vmemmap_p4d_populate(pgd_t *pgd, unsigned long addr, int node) > +static p4d_t * __meminit vmemmap_p4d_populate(pgd_t *pgd, unsigned long addr, int node) > { > p4d_t *p4d = p4d_offset(pgd, addr); > if (p4d_none(*p4d)) { > @@ -234,7 +234,7 @@ p4d_t * __meminit vmemmap_p4d_populate(pgd_t *pgd, unsigned long addr, int node) > return p4d; > } > > -pgd_t * __meminit vmemmap_pgd_populate(unsigned long addr, int node) > +static pgd_t * __meminit vmemmap_pgd_populate(unsigned long addr, int node) > { > pgd_t *pgd = pgd_offset_k(addr); > if (pgd_none(*pgd)) { > -- > 2.50.1 (Apple Git-155) > -- Sincerely yours, Mike.