From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E977272E7C for ; Thu, 23 Apr 2026 20:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776975144; cv=none; b=F1rGSVT3RuMu+Ltiu8M4h9W9Jzf/HVOfP+p8N6pqB0DUpCYZcWHf5SIxg0Oujs7oMKJxqjs7D9m/fvGRr1Racuc51Vj6+RozclLtOkvuOMSXZn+e9Ua0rQ95Ev9Js3cMs35UT3n92dk1nMWQNVTnkSMDBj0JdTny/FyGTdq5zF8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776975144; c=relaxed/simple; bh=/sylxGN4Dmmmd90EcxP9FdzC4bbLZRL6ub267DfwBr0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N/YgOILQ4vPs6piqh1afzFYkmEFm3geqkkdc6kQ5fixtDuDnV/WhyglN1zDDIXCiBGR2MbRcc5mROOKtFT4okWtP94LBeX9IR/RNlFn6l0pnFpHdc4k73L0Ok48eL3d1PXYJa5ueV2jTMkHeOS3gsx8eHY5KotOTzhEUq4+PcLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gOiJK/7r; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gOiJK/7r" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-488e1a8ac40so87192355e9.2 for ; Thu, 23 Apr 2026 13:12:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776975141; x=1777579941; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=F5AMv4bglIF0XOHNIgTCSUa8oAPcWQ+ne8bZUxu85CI=; b=gOiJK/7r6CnT905PYVzmLGa5kYN6xiJ4h5hZE4U4qyqghagwGX0paqdmNksvZ6PYej jz+29sZZEa4NfLqjy0mrgnpLRQiWtHvxkX8UAufDW7qxqGbGOD7gYOtM409JncMgOYCe sxu3kLZkf85CxEhsA9zY7xqxMdjqNRcnd1QoNnuVU4wNhPYoB4aUmAsDMR3Eh8LvdyVT hHDubHzfsiZQ/FWie6vP4qlQFtje4bK9fwdaVKidDqaDghrKONDGNO/HOctn8+KXyCgT 1a0DCGxMJMrywLbI4A48SHkdQB80wD58NhFPUqtEtIq06U9sKUTACg9I1fTZejilbscf 6lwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776975141; x=1777579941; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F5AMv4bglIF0XOHNIgTCSUa8oAPcWQ+ne8bZUxu85CI=; b=EXUXxieE9p76V9X3ZkAfoGwW4DcffjXR84wh8O5+d1wiNp4uqGiGuAHg0hGjI7iVYI drpbqKeRU3rho5BTL9v1YPa2CkCwVEf0Arhlbge5MVC1c0+CKTDHFSea84uQQlmwdFmB 6CHbP9Db1MWdP4kqeg4C6t0e9WwAXOfc5eY/M2f29OrlLsHAOP23fxk7L+kJhRSjXK+f j1MnQmjkDpX98dvg+NXKjQsuFFtehaCw0m25tjwCoELRnJtsukrhmCwYX4aWETKq+qFN p7MX8sO05MESy6cJ6P2ueAEeYCBPn2HZE+zZmXxuTBdaXRn7uND4owWn0RGgK4PyClo6 +Q+g== X-Forwarded-Encrypted: i=1; AFNElJ8jqv3d7UGTMUy3J7jMgv5tICkxNT+9VKayhntTTHi8EYl2ONEn30G/1s04k2QPENrOgVyMdEFjtjVhUEM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywv9KXN+MK40VU/3EFg1eFfE2GpePjVFCp8KEzpLzzdfBw4JChB FQByvbPXfHa/DGQdfxx2xu9aiAT4hjgdZZVRZ3vmt+mzcXjAdKp+BI5b X-Gm-Gg: AeBDietQPZMnlixGr3Pr0Gi9g35v4bzj0Q4DeheUvViBaI3thVheB1LEdNaTBThP59J eoyStwXczMkDodIEwfA3SNiS30Rph1KuoL/NzJJkN/kVNLSWijYnz0Mhy58Qz44cilqSW51moUK 26hC4HSueKj8A6rqSsuWnFHvKja8+0b2/q3MS89QJkIU5fNlAAOsDHgI5PknmoS4cmfTCcKfEj7 voC6GET4+aiXH1E+IhLdu587F51ywclC18KWIaLnopYxKQyMVYa9nIe4GiLVgG0ZpY3+7ZQQoxm n0SzTZ7XSeOcMVv0fF7kS3RTkwTgrCyMwc2HXHQQlwf/CmsimkrJVLZWlo0+5hEZoygdv9JDYqx vEhyB+w+6krlrNb4MDBGvkRxEDTQCiVcdNE6zGy21bImfhQh9ZIuPrCI/KIgbsQRIl8G3j6jONg aBiAUCDS7HT2aIbxHPRK03TfBNsIBFoTsZA+paKTE1E2vMIMnonAV6h+IV2nlvTAhQrnft X-Received: by 2002:a05:600c:797:b0:489:1a3a:9e45 with SMTP id 5b1f17b1804b1-4891a3a9f38mr175552685e9.26.1776975141244; Thu, 23 Apr 2026 13:12:21 -0700 (PDT) Received: from osama ([2a02:908:1b6:8980:5f44:38d2:bccf:b54f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a5aa3ae83sm270934595e9.12.2026.04.23.13.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 13:12:20 -0700 (PDT) Date: Thu, 23 Apr 2026 22:12:17 +0200 From: Osama Abdelkader To: Luca Ceresoli Cc: Jagan Teki , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] drm/bridge: chipone-icn6211: use devm_drm_bridge_add Message-ID: References: <20260414180518.160801-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Apr 23, 2026 at 10:31:27AM +0200, Luca Ceresoli wrote: > On Tue Apr 14, 2026 at 8:05 PM CEST, Osama Abdelkader wrote: > > Use devm_drm_bridge_add() so the bridge is released if probe fails after > > registration, and drop drm_bridge_remove() from DSI remove. > > > > v2: devm_drm_bridge_add instead of drm_bridge_add + manual remove paths > > > > Signed-off-by: Osama Abdelkader > > --- > > drivers/gpu/drm/bridge/chipone-icn6211.c | 17 +++++++---------- > > 1 file changed, 7 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c > > index 5bee10c64265..4bc98c45f65f 100644 > > --- a/drivers/gpu/drm/bridge/chipone-icn6211.c > > +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c > > @@ -5,6 +5,7 @@ > > */ > > > > #include > > +#include > > #include > > #include > > #include > > @@ -730,12 +731,11 @@ static int chipone_dsi_probe(struct mipi_dsi_device *dsi) > > > > mipi_dsi_set_drvdata(dsi, icn); > > > > - drm_bridge_add(&icn->bridge); > > - > > - ret = chipone_dsi_attach(icn); > > + ret = devm_drm_bridge_add(dev, &icn->bridge); > > if (ret) > > - drm_bridge_remove(&icn->bridge); > > + return ret; > > > > + ret = chipone_dsi_attach(icn); > > return ret; > > } > > This patch is doing two different things. This one is a code improvement... > > > @@ -758,20 +758,17 @@ static int chipone_i2c_probe(struct i2c_client *client) > > dev_set_drvdata(dev, icn); > > i2c_set_clientdata(client, icn); > > > > - drm_bridge_add(&icn->bridge); > > + ret = devm_drm_bridge_add(dev, &icn->bridge); > > + if (ret) > > + return ret; > > > > ret = chipone_dsi_host_attach(icn); > > - if (ret) > > - drm_bridge_remove(&icn->bridge); > > return ret; > > } > > ...and this one is a bigfix. So they should be different patches, the fix > having Fixes + Cc stable (with fixes being before other patches in the > series). > Thanks for the review, done in v3. Best regards, Osama > Luca > > -- > Luca Ceresoli, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com