From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from BYAPR05CU005.outbound.protection.outlook.com (mail-westusazon11010046.outbound.protection.outlook.com [52.101.85.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F01A1BBBE5 for ; Fri, 24 Apr 2026 05:19:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.85.46 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777007976; cv=fail; b=H8roLYEJHfyaQVv4tPElQePYku/fQeA+Gn1qD9RIFMe2POmCt2rwc4fgzVPYl8d3CxhG++8G8C1+8E81uzpCHWVEjanlGS6wYciov6F3bAmoyA+GeUv37qP7iQRuRbh3nOO97kcVGfiBEzaQ5uET0l5TKm+ISXiEkMb/DHdgTxo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777007976; c=relaxed/simple; bh=iEbXLgixwMpGg70UArZ5w9hYrbj/Onzjd/PstIUZDGg=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=RZk28NBIzEPPlSNZ5ATv+RZTglcFRp/hABtkFru6xvBtjQVgV+mPtBKe1aHEm8PprOoVko4F8kx3SjUtBkQ009a0aKRPNJNO3XHjAz69lyJEWccVzJBWQ1bPdFdwByUAWW3PsdzkgK/jQ1i/jgXCOYU+qD41wRyXzKByY3YloEA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=DyU2kCS8; arc=fail smtp.client-ip=52.101.85.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="DyU2kCS8" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=B1/C6ZMgjQtEWXuHPKTMoyQ+RZN9xTzkTSR/kyhz+8FTgRcqehe2YJF+GDFn6YR6MA1L/MeBy6VnY60/KLMLCchhqPTval7MWT5FXC3cYurisqWfKae1TOMlLIJkNt1jtD+M0hvTqMTjStdAlfxavGYNBaK17edNGtYSSYV2yPRBG8Vz44kYNL7wD1vXkJ26PXkX28dg+++JT4cT283pF2vQP7oYAn46LbVGCwwRQOH3FHwgeLqFMI3FpoeknnVN98HU/FYTwA+lMNplLhxX+TlMLvddyp3r/VBEnhb1jzrofBc5/7g48PZk6vKlqHUvUtZXIH6Z9fp9j6UgVHIa2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OXbgTWwkBKJgc7wWhmufVpBGLm1ckbMI4bbFpUO6Jms=; b=N8lvJoWffahMav75EB4BsCwFGEGb+MX+UzHsh5VKUgRW8PzUoumWNwnxCJWb78vyHuUtSVKPeZKyIZpSgugnPYTTPqLulZbT9DxgX9AX4oAMVRkeRYBUiIVMpvnORXaEWiCDRUG3IP4ydQpre8J7sSV4lhPvTapN/HbFSC76mXibXib5A39aKeC4le0o8AUOBqMHSfscjVz6NFgFfD02l2VuseiZozT5x5aAAAMs3+OMQKYaFINd91NssaNjedW/yjq7j4nOQ+9n/aIGaqYoglQeVlqfnqYV5GXya0TklqCqYQfy4R09LENv4U/RViQ1b8fuE8s66odO2qoHYvuiUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OXbgTWwkBKJgc7wWhmufVpBGLm1ckbMI4bbFpUO6Jms=; b=DyU2kCS8vOpe36t+DoCTBZx82FRWDp+olXjjOPrSQzBfJ3ppURdyiF8Kysqp0ZR+Gvvr94nA18/evKpwJMuQpeCLyAIm7ttNFjVmMpXqu5i7Z3MpOibZF5RWsEsV+2rk//agCj9WGRGHukCgjO3SfjIY1y/MKjCZhD0u6Uc1z4AwFLIWk2rFFqOex9vozrRIt+25m9jEUcz8k8nkf6agRUL7lh1Ub2+4LuG04yy9lO4qJ5oU27ULxJ9hwR/yfI3MkqZncs8wUHGbJpM0WFrORo5W/rifdOtoY9ZewsZQZfdOgTqvdH0l6nmD70yD+WmeyyFPbxR0hLBmSIbXvfGhag== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by SA5PPF9BB0D8619.namprd12.prod.outlook.com (2603:10b6:80f:fc04::8d8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.25; Fri, 24 Apr 2026 05:19:29 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9846.019; Fri, 24 Apr 2026 05:19:28 +0000 Date: Fri, 24 Apr 2026 07:19:16 +0200 From: Andrea Righi To: K Prateek Nayak Cc: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , Joel Fernandes , Shrikanth Hegde , linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] sched/fair: Make asym CPU capacity idle rank values self-documenting Message-ID: References: <20260423074135.380390-1-arighi@nvidia.com> <20260423074135.380390-6-arighi@nvidia.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: MI0P293CA0003.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:44::9) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|SA5PPF9BB0D8619:EE_ X-MS-Office365-Filtering-Correlation-Id: e126337b-cf89-4d3a-2d10-08dea1c10ef7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|366016|1800799024|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: zev6YMrLFNfX02ftDTOJJpEri+oOdrZ3/iHb6qWNNu4Vvy5i32YmOGuo2DByrCCJ8fIgbJhlR/q1fzZt5VkEEsqhOLm/PatfV2aNsDSndxmR96mZLxs3s419KOdiPw0k5ctD/alZs9ZcducI8PZj2iIslbOXKnQrSIXM2Phwik6iNddERhgtLmSvd8G6WJY4XeCmg5C9TbrrgmI5+PsHVlSai8iUjrZywmUE+XMOEHriPiZ0qOAOYjkyuFGhuPGyK8PILG3P3zHQ36BoYrA8MKYHCLG9TOkhoAdBwOBIJmelXgN1TWf6jZF3XKlX+AZZI9N/NVnuDxryujVjBRuWZt1GkWfF5mD0A/sbuZZG5djfG6v+n9Kbp4QWy4zVOZpZa17ghavbiN/KBa7vpBS6scAUBi2f3P8W0Md+Fa++7ghWbdxdDSEgQSZhC8x5FU/LgvnxnSrZNqcwE8gHaqXjbz3KFRObabDz9mhbMmyeER1hrpWRzFkr0u3fJyD2neOYCVzXxvM4pPAKmEYwIkWhyEdvSb6ArEAj2G9Krx5VUHGRGv778p+78HA7CBzY07kfVFtCgySEnwLZsZ3Rjpr5FK8Skqdp915ttnpTjaZ8o0sDRBAIn6M8GTg5zpLT/1Kwa5D7hustMmkxgfxhWuqY37DnLRsLoxGsT7DC8wD309e3wh6CKJ9PuSYDUGf2lLLoJkrk98lKzKk3AwMsfl64YcKyJZp1+dNKrisD1oUyMVo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(366016)(1800799024)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rfBDtnke3qpYxMJ70YLV6jCAaFCUH+dEhL1s8D0OV7GQm82QY+5t8HrjIf/g?= =?us-ascii?Q?Z9Sx0vD/Z52YDWc232VG6fyOCMukdziZPQGoVRGSJM69NsJ1/RhitkaV88QW?= =?us-ascii?Q?S+4ZTP2RbEG1476mB1Gz2POgIIwiOeansk05F+YWGKylWykFBlLLtGTAFO66?= =?us-ascii?Q?GLc7F8bTIgdD57I9dBEIHAnun5rm65/rHuAKo0dPNVQqFHKqu1Lilcxvsa6j?= =?us-ascii?Q?2qXdJwB8Dx9M4c0IBaBvnBp705dj9u0hFi0DF6gG8MiwoVZXSCL7eRmnnOOT?= =?us-ascii?Q?b1pSPfU9wZi2sLY4OyjjFN6FIqS+w/McTnidF8DP5DWsUQL9WLuEvpjCET43?= =?us-ascii?Q?XpnY3BOxUWx/0nWb2++PhTPGQ7p3gf0lX2WjJNHnP6LZ5smEcfGMDVlRywvz?= =?us-ascii?Q?QuBHfUznpWHCDzxn8pCiSHDX+MmQt9t+svgu3huzzSIhgk9dnKA9vEYRQFSi?= =?us-ascii?Q?BLljnU3dtzZDXAWrzdiwSWPmY5qI+w5ougPRfgFmlJrZI3Xoszhe+CLiJ915?= =?us-ascii?Q?/p6rYi9N6jrw0vmyNvNcDfb3/IVS4vMwlAB3VWyvNrTNlAxt6PQrzdMfUuat?= =?us-ascii?Q?2ctw6qXsmF5u2JNkBFdvnNenSJYz4luqciMKVotFT+qyAhYmwVAIqw/hn97T?= =?us-ascii?Q?E+o+n2/vuuAHBM3axAId3/dSn0N6u5HF6fo5m7dungLg3ZfyjEyF1oT5xeGt?= =?us-ascii?Q?KGxwoD2Uq/eG6tSOVTyqsCvXGUBhm6tUsu7HqZntp5i9rSkBubrE0zGocAip?= =?us-ascii?Q?eFkgSxRVw7Wulihz4HAMOPgMFuSKm0osI62vSmxeXyTnohF+mLKSGaqLvGNV?= =?us-ascii?Q?J3fuEU2JfesMZF0ElEivXGszasMmlIhN1OkfNbe5JDZF3X5yyBfTV2H0Ak+i?= =?us-ascii?Q?VuFk5yhDFJ5VBbz1jdH1/Y4skTiqFRadfvbruKS062T11RR4L8R6iRkJm+NA?= =?us-ascii?Q?vKxq3KSD3C5fFVU5wVPtWGQCPP79sT9BHm/rxnEBjuOO4kxjt5/GXsjBKFHC?= =?us-ascii?Q?FHfGClbFOwZOAiTlgFPPbYyQcpjA+shLaWiFaupwhiq0LnGBHaxKem17nMxq?= =?us-ascii?Q?vHN/bi/6SiG/7tU60bfIjiC0YownkEy8aQ07DmXLLYBDxVCg2749iFnhbTf2?= =?us-ascii?Q?hhV4ypCG74YJCmJSf4NHsoEPDJYhbc+1/dWf4tfYCeeMbyZVo1RrZR2cE6RV?= =?us-ascii?Q?VX+C+G6fr8X2CB1EEQe00dMV1pWPGhZbacYearIlyZk2+H2BZTGD9OilL5Qa?= =?us-ascii?Q?iSehIdvtIIZhuOdg5e9fRbYy/a/fLo5jCkZWFq1r7azu9P8jJcnxKnqXSqUv?= =?us-ascii?Q?8sdJMEMHx/Brc5WuDG8Y3pLYS7f7UUwhL+BHfBsp0savCbcC1EjRo0hdlUBx?= =?us-ascii?Q?RHDLkjNX8ABC/0WtK5M8avCB5C3I60/kebPmjTaxebf7k3b6rV6hwPyga5dX?= =?us-ascii?Q?Qdp+OKqveSZCs8opAaFOQBYE7vl1VXw2snfyppl9Izt4mhuHq//h+uO25ybF?= =?us-ascii?Q?7uX7OuXzOTcEZQ7VKJasf3Gfee7q/bXze4IeTmFxztpXKJiNj1mN6aCjrlpi?= =?us-ascii?Q?aAUQMgH9/rJjLOZMcOeVUMpT9FPK+/t2Jcgjujx1Jew68omhuQYL1dopULLC?= =?us-ascii?Q?5qKfK8yy2/ygdBBkpdoGFGfwLVg8JW3Ync8UuIBCa8F9m4dJ1vIBGThi3Yd4?= =?us-ascii?Q?rF8pprf2AMOnjCBM1j6lBEtQFswKHpXGaSjhFfaVWFS+Sk3Q4y9+BpAvEucY?= =?us-ascii?Q?JcpTbra0Tw=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: e126337b-cf89-4d3a-2d10-08dea1c10ef7 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2026 05:19:28.6631 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a3n+LKNPlEgAUQ5Q9064akmEvV0Voto4+5kyE40z+9z5OMAEgYqJpHFH+D62DOYjdEkxKABbc1Tbwr5hcfbuPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA5PPF9BB0D8619 Hi Prateek, On Fri, Apr 24, 2026 at 09:59:42AM +0530, K Prateek Nayak wrote: > Hello Andrea, > > On 4/23/2026 1:06 PM, Andrea Righi wrote: > > From: K Prateek Nayak > > > > Introduce enum asym_fits_state for select_idle_capacity() scan > > preferences, instead of using raw constants to improve readability. > > > > No functional change. > > > > Signed-off-by: K Prateek Nayak > > All I did was suggest an enum; You did all the work on this :-) Well, actually you wrote the code, I wrote the patch description. :) > I think this can be squashed into Patch 3 and that way we have we > can avoid the magic numbers from the get-go. Thoughts? Yeah, that's probably better, no reason to have a separate patch. I'll do that in the next version. Thanks, -Andrea