From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93A2C2BE051 for ; Fri, 24 Apr 2026 05:48:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777009686; cv=none; b=MQMqfgLZK58ALGl9CXvRnZqtq8b3PS4nAbljKs85ptyMBMDUa3VVwdB2wIBpFmDB/jZ1wx3MYnXdo02V3gzlFsTp3P1URegwOE8Fhn+a+akXLJTzzJ2xgtOnL6ftMdzVZyEtNiwlcSKv66wMwNYMj4W+4yih/Q/M98oIAK8Ii58= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777009686; c=relaxed/simple; bh=cEiTno/uh3xHogJLY1rD/3Lq75ip7IpQ33GgXc+X/wI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tkAnW/PbJ5DrmszgacSpWCfp7Hr5tcZ4fyYbCc+oBy8NLj5ijaEely/MkKpuQRO4QAC9KvV6Wd/Nq++/cqOaCYpZxXO8T9vjJYGLlycwwZ8mRXWirrJ2NYeaINv9z1U2Wgty0pKMyJXhKqX63IYmXlVnZWiDxEyB1CQqJpbw8qE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gucVLpRM; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gucVLpRM" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-82f8893bff3so3543482b3a.2 for ; Thu, 23 Apr 2026 22:48:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777009685; x=1777614485; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cEiTno/uh3xHogJLY1rD/3Lq75ip7IpQ33GgXc+X/wI=; b=gucVLpRM7HwbbqX3RvG6lhuvYvUwFYrupZk16LxZCvgSzJ1qh45SvQP3j2v5HUBaew npy88TnPaQEa8djB/aHneswmxBiVMnXhkkTBmHO8YVyanG7UpY1wbWT/jXB9me12HZWj CF4GzxtDkyD4uaT1hg4z0IYQvP1QncHhy+Q7RYr0hVldABq3ljangK9BOw5uvmNQIW7F 9wvoacsWmKEY1XktO75It5j+2vWhad8fGu+WiuNSaGRUTOrXQfKtww86WNCOcGt0Pi9g DZYnabaIXzJAgiL8bBmSZYktTVOEZaiCLjWYlIA1YhNIWlxHyF6JZhBkIwMaXK+DDYBS UL0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777009685; x=1777614485; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cEiTno/uh3xHogJLY1rD/3Lq75ip7IpQ33GgXc+X/wI=; b=W5F9A1VFmBxyZS3ywKZhnHsn0zoS8sGJtkmjDTw5EhgKtQa+zOTpMfqd7iKCCGzsG+ TmLb48nZsLNGrmhAUsAW9QuLuq+gTAc3zg1kJOHvlYhnzZj6QF8JKeXxBxG9WrW5Y3hr e6xPXGZj/2D1yHP1vg5eBU2VimBioYOACNI+RO6jvi0hSShQ3b6BYDQXjT/PVdixwu86 IU9osnMLzTwQJAdNIk1Lfa7I4TpPvcwC1Q7MSW8piAcIi6vTOVmym+sdqy1pBG93vQ3g 04itQQBSxuSHLl1uY9syqV+irEVGOrneh3egjuTU2I1xI7FaX3GPEWyi0vYFpCnqoFYL Es0A== X-Forwarded-Encrypted: i=1; AFNElJ+ZYIsO84Os63bj+cjA44dSLANLy0i5NXHNE67Xa+vWur0rFFxBxR/y7Utqp1JpYT2zAXLiyGRC2nJ6ybA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0ZKKHaXFLpN0NVzXjPzA7F1fVA20n1tzdhSLAMR57kswhZTT4 zcHCOYBZA85i0LAb5x9j0H4k9EgfPIeMevAFEH7Tw3rq2l976EsU7ZgI X-Gm-Gg: AeBDieuopWiBRpMw7+BDyx46/2065mm1SyAoBw93TJEMaF55NBV/c7dAcv5RglzYKL9 cPI9DEeRPx3J92aKFaT7xxMC2Bz+TH4ICdqXvVzbDohIOksvCnIS0OwMEOnTfSZ0xYP3OIOgFt8 Qa/2vGoSlKdJvfCO+6OdZ1ISlKJBeCYMFKyKMMdkPoBExp0hcc8UKxw/P/s4Wk0ZWlsvx73qgOI QxOKabZq3maiqDazLxOaTFAGqCKMPZFdrmctEcoOMlI1d7Lb1MjBn3U30awJ2eNBa/J6c1bWnzj CSr8wrPO+3W5DNAoxT22ZwZOevH4TOWHZp3MLRpdy98Pbqm77IBWVdQCLpDq8JEv3Cc8/42u6D0 nxR6xcpc6Y9WUEC1ITOmpSHJ3QWiLFCMa4TPdYdfR4+gJJiPD7zKDXYUwNrhCxnL948oaZudTNB F6nsY2PpJHdFb7FVD9HAWyfZPyQdUowfbM9YLZ X-Received: by 2002:a05:6a00:3cca:b0:82f:120:fd6f with SMTP id d2e1a72fcca58-82f8c40ae88mr31344043b3a.0.1777009684887; Thu, 23 Apr 2026 22:48:04 -0700 (PDT) Received: from soyboi ([2402:8780:1073:993:9321:304a:9347:5e0e]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f8e9e0f40sm24070785b3a.17.2026.04.23.22.48.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Apr 2026 22:48:04 -0700 (PDT) Date: Fri, 24 Apr 2026 12:47:58 +0700 From: Robertus Diawan Chris To: Dan Carpenter Cc: andy@kernel.org, hansg@kernel.org, mchehab@kernel.org, sakari.ailus@linux.intel.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com Subject: Re: [PATCH RFT] media: atomisp: Add error check in create_host_regular_capture_pipeline() Message-ID: References: <20260423060246.296986-1-robertusdchris@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hello Dan, On Thu, Apr 23, 2026 at 10:17:13AM +0300, Dan Carpenter wrote: > On Thu, Apr 23, 2026 at 01:02:46PM +0700, Robertus Diawan Chris wrote: > > When calling ia_css_pipeline_create_and_add_stage() function, there's no > > condition to check whether ia_css_pipeline_create_and_add_stage() throw > > an error or not. So add conditional check for the return value of > > ia_css_pipeline_create_and_add_stage() function. > > > > This is reported by Coverity Scan with CID 1408952 as UNUSED_VALUE. > > > > Signed-off-by: Robertus Diawan Chris > > --- > > You need a Fixes tag. Oh I didn't know that we need to add Fixes tag too. Alright, I will add Fixes tag in the next iteration of the patch. Thank you for the feedback. Best regards, Robertus Diawan Chris