From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f171.google.com (mail-dy1-f171.google.com [74.125.82.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A14D3B9DAE for ; Fri, 24 Apr 2026 15:31:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777044716; cv=none; b=K2FVIIT5C4wn2dWU3wwa8WOJI53d7WGM6p3QAqIQVy2X5c6LZa2j/cUNJCm1YQPHUUXdcyxnT6E3oPL/1aJZdRBggZNxiW2wMx7cTfoLf/PGoWxhx9LJ4ia36cj5EAXGCOzLUXsrvFbJdt0xI/KMToX9uXcgVsBNApP1gyVKIts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777044716; c=relaxed/simple; bh=otD7jQdcDLxaXX/SFvmfgLVOCJ6x6Ljebj6G+BBXCTw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YJ/wYr8MyMRQHelSi+hgZUDSHgg3twSIPfzbYnFqrnNk8UJOmDo1OzA5IBrVw8T3Wy5Dfl5JSQ5o74tafx/+pWq6X+DCMwUMcq3VSVeidBmmD+blMvJM/aoNisjPyquQgLOdIzKFd321bfwuRvZ+CJFi4LevQSoZojdchcDNmR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fks5Jd4b; arc=none smtp.client-ip=74.125.82.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fks5Jd4b" Received: by mail-dy1-f171.google.com with SMTP id 5a478bee46e88-2ba895adfeaso8794430eec.0 for ; Fri, 24 Apr 2026 08:31:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777044714; x=1777649514; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3J8fVdyPxB0m2xHleeQEB0k0imM/1ZciMz1C7VyY1IU=; b=fks5Jd4b5wx5wDPU3rJvoFnDM2ZhAbwDdNjF7ljO+ZS4UEYddxsmPVeEqgnpoqkZbr PRW967WbdROt/JdZr5JtZZPs1WtZ93XmMP2EMnr/alflntSKpptGgZkNHoWBMe/Zzpj7 GKJG+iL73h4QyolE4p815wrIC79TNWH1R99Vemw4T1+GXIL8wQp2Kbd1UiVq9o99PNV4 Gk9vexxrmaUYNqjxrc/rpU0K1godWNP/pt4BRaBDFUxeEBJDYKuI5nGp3UPB9e0xtN5N gDWCXLFgkAhjKaQbe1mB4EbXYAFG8pVGwQ0/4igiOeanSK0fMK4b2ET9cR0OLgzC+ncZ 2+Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777044714; x=1777649514; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3J8fVdyPxB0m2xHleeQEB0k0imM/1ZciMz1C7VyY1IU=; b=sCo4c8wGfMe7j521Wu1rvkBzWQpG5cWc0e0An6wwxuF5DeHHrGecaPM32Kce9womJc CDiYvurXlFjEsQhlZveoi6o18ycCBH8DOZor60tpWpvivwCZJ86fTa4btG5W94CJ1kgL 4drUaqhFIF0xPzA2gMmqkxR6kMHQ0L78JbVVJqe4Qqnp4SKe3kziggomDah5UXtDsUob 28YT3xv9Hx2L5/UCMSQ+dlEdy8/sJUBOY4QhFIbZqsfyR/Ek9i8AEk9TRuz387MbLh8K ZhcLIPqulShjhfW6V267oJqGfqB6d3Wu1q4j6nZGNBFelWszn75atQqAPcl9hI9veSLv QKYA== X-Forwarded-Encrypted: i=1; AFNElJ9GdTpSCr8bdJ6+JufatsvUtNOHtr9Zw0qZ34CEPPA0Uhu048ICbleQFYn5O+abek9wyt/esfOKtzQXr1Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yz8QtmzNWeoro/1pgBpkXKeirQ7wOWTWJ4LxUJ2bXgI+FOIGTnU UbuzMTQ25aSW//2Z3OBcTwPl0JtQIxV03tAkubhz2nVFli0/36NPRFZx X-Gm-Gg: AeBDietV1ToFCDk/Rh5yV7eZ9SmVXMC3LVnmQCXtFYazqQ1dvR4fkLrEP+x8jPPzeEi FZiBnBcZFhU95LZpe8pBsMRTqswrkZ4GbO6PCLn2/zYJhqSfwC1cfFMs2YJE+lskBf3NA2ADJM1 aD1wqZZo/+cISW43wbTxZvLOsyh/4e/L4W+BV3jYXbHldQjowq8VNFeuJTrS53MW4zMA8B0eqSR RK0Y5WJNFNJ2tRwqndQ6DchZdDzsMW0joJVrB8DrWpYRJMMTinDJYLgMJJypG2q+bS3XzaoRklP ERGDlx5Bq5XVrKtmyber1lj1oS3I4XtT3SUjmSvi3Om/Q+c0Ja3pWEObx0iheQfl46fAR5vfQrN 8v4u0FSjFjCMujARKJLCYLrRnazCw4Ru9ae3i/enU6cvZkswkTyrtJYgUZWGWCbwngnKmgB8dte 3u4JhGcYDdqnhSYX7LdHfCBeHdm6Kht/s3othBPCfJyhVUkllsqHcMaDNF4s6BlYAu9FeJy7NY/ 1s= X-Received: by 2002:a05:7300:b905:b0:2dd:5641:f01 with SMTP id 5a478bee46e88-2e479110b4emr18033448eec.28.1777044713716; Fri, 24 Apr 2026 08:31:53 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:f405:91aa:7e5f:f595]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2e539fa5c86sm38983450eec.1.2026.04.24.08.31.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Apr 2026 08:31:53 -0700 (PDT) Date: Fri, 24 Apr 2026 08:31:50 -0700 From: Dmitry Torokhov To: Svyatoslav Ryhel Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Linus Walleij , linux-input@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 2/2] Input: isa1200 - new driver for Imagis ISA1200 Message-ID: References: <20260424071305.89503-1-clamor95@gmail.com> <20260424071305.89503-3-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260424071305.89503-3-clamor95@gmail.com> On Fri, Apr 24, 2026 at 10:13:05AM +0300, Svyatoslav Ryhel wrote: > From: Linus Walleij > > The ISA1200 is a haptic feedback unit from Imagis Technology using two > motors for haptic feedback in mobile phones. Used in many mobile devices > c. 2012 including Samsung Galxy S Advance GT-I9070 (Janice), Samsung Beam > GT-I8350 (Gavini), LG Optimus 4X P880 and LG Optimus Vu P895. > > The exact datasheet for the ISA1200 is not available; all data was modeled > based on available downstream kernel sources for various devices and > fragments of information scattered across the internet. > > Signed-off-by: Linus Walleij > Co-developed-by: Svyatoslav Ryhel > Signed-off-by: Svyatoslav Ryhel There are a bunch of valid sashiko comments, please address them: https://sashiko.dev/#/patchset/20260424071305.89503-1-clamor95%40gmail.com Thanks. -- Dmitry