Re: [PATCH v1 1/2] dt-bindings: input: Document Imagis ISA1200 haptic motor driver

Rob Herring
2026-04-24T14:58:05Z

On Fri, Apr 24, 2026 at 7:58 AM Svyatoslav Ryhel <clamor95@gmail.com> wrote:
>
> пт, 24 квіт. 2026 р. о 14:55 Rob Herring <robh@kernel.org> пише:
> >
> > On Fri, Apr 24, 2026 at 3:57 AM Svyatoslav Ryhel <clamor95@gmail.com> wrote:
> > >
> > > пт, 24 квіт. 2026 р. о 11:30 Rob Herring (Arm) <robh@kernel.org> пише:
> > > >
> > > >
> > > > On Fri, 24 Apr 2026 10:13:04 +0300, Svyatoslav Ryhel wrote:
> > > > > Document the Imagis ISA1200 haptic motor driver, used primarily in mobile
> > > > > handheld devices and capable of supporting up to two motors.
> > > > >
> > > > > The exact datasheet for the ISA1200 is not available; all data was modeled
> > > > > based on available downstream kernel sources for various devices and
> > > > > fragments of information scattered across the internet.
> > > > >
> > > > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > > > > ---
> > > > > .../bindings/input/imagis,isa1200.yaml | 145 ++++++++++++++++++
> > > > > include/dt-bindings/input/isa1200.h | 16 ++
> > > > > 2 files changed, 161 insertions(+)
> > > > > create mode 100644 Documentation/devicetree/bindings/input/imagis,isa1200.yaml
> > > > > create mode 100644 include/dt-bindings/input/isa1200.h
> > > > >
> > > >
> > > > My bot found errors running 'make dt_binding_check' on your patch:
> > > >
> > > > yamllint warnings/errors:
> > > >
> > > > dtschema/dtc warnings/errors:
> > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/imagis,isa1200.example.dtb: haptic-engine@49 (imagis,isa1200): enable-gpios: [[4294967295, 22, 0], [4294967295, 23, 0]] is too long
> > > > from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer-common.yaml
> > > >
> > > > doc reference errors (make refcheckdocs):
> > > >
> > > > See https://patchwork.kernel.org/project/devicetree/patch/20260424071305.89503-2-clamor95@gmail.com
> > > >
> > > > The base for the series is generally the latest rc1. A different dependency
> > > > should be noted in *this* patch.
> > > >
> > > > If you already ran 'make dt_binding_check' and didn't see the above
> > > > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > > > date:
> > > >
> > > > pip3 install dtschema --upgrade
> > > >
> > > > Please check and re-submit after running the above command yourself. Note
> > > > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > > > your schema. However, it must be unset to test all examples with your schema.
> > > >
> > >
> > > I am not sure what is going on here. I have installed dtschema-2026.4
> > > which seems to be the latest. Running the check with this schema gives
> > > a clean result, no errors produced.
> > >
> > > SCHEMA Documentation/devicetree/bindings/processed-schema.json
> > > CHKDT ./Documentation/devicetree/bindings
> > > LINT ./Documentation/devicetree/bindings
> > > DTEX Documentation/devicetree/bindings/input/imagis,isa1200.example.dts
> > > DTC [C] Documentation/devicetree/bindings/input/imagis,isa1200.example.dtb
> >
> > Let me guess, you have DT_SCHEMA_FILES set? Then you are only
> > validating against the schemas that match and not all of them. There's
> > a single binding target now. See commit 400fbf4b5870 ("dt-bindings:
> > kbuild: Support single binding targets"). Of course, changes in this
> > schema could affect any other example, so you ultimately have to check
> > everything with just 'make dt_binding_check'.
> >
>
> Thank you for explanation. That is unfortunate.
>
> > The issue here is enable-gpios is defined as a standard property name
> > with 1 GPIO. I don't think we want to extend that because with more
> > than 1 you have to know what each signal is and the relationship
> > between them which will vary.
> >
>
> Is it still possible to use enable-gpios for 2 gpios in local cases
> (like this one) or I have to use some non-standard naming like
> en-gpios or control-gpios etc.? This device has 2 pins called hen and
> len, usually they are hooked to a single gpio, but that is not
> universally true.

Just do hen-gpios and len-gpios.

Rob