From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5570A38657E for ; Sat, 25 Apr 2026 09:36:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777109770; cv=none; b=mxEH01vCnmIeuCpgLEG5eo5lLuurbvnW+j6/JUWH/YEjihgsJ9SPqcLMdOvizRJM+EzQENFZ9xZs+A7cPKC3ojL++nSruY0rkV2yz5trYixN0aEEJ+VxQDz19NcvzRoX9lK2UTQAMUzprrwh7rL99XsCMRPwfpEHJ1Q0S2UFqd8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777109770; c=relaxed/simple; bh=5e6fX3sQdFJdLB1VGGOKAwcO2g4TlKf7rIlNNzyiiLo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gBciO2ejejATzVGnvBGKjVktTrxwddmjhNrhx2BZqcb5IPb3/JU/SYWIazJ/ZWsHUF+BR9SyEr9qP+96oheSOM34z+JHdkMfQvcsQd7Pkl5r7YU9YkgGp3ryHC/YE3D6nVWu6Gdj2slANxi59FdFpNpTWBuZvhsATtwVZMylps8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=readmodwrite.com; spf=none smtp.mailfrom=readmodwrite.com; dkim=pass (2048-bit key) header.d=readmodwrite-com.20251104.gappssmtp.com header.i=@readmodwrite-com.20251104.gappssmtp.com header.b=VqPABr0T; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=readmodwrite.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=readmodwrite.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=readmodwrite-com.20251104.gappssmtp.com header.i=@readmodwrite-com.20251104.gappssmtp.com header.b="VqPABr0T" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4891f625344so73575175e9.0 for ; Sat, 25 Apr 2026 02:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=readmodwrite-com.20251104.gappssmtp.com; s=20251104; t=1777109768; x=1777714568; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sSxxsg0M9lsnfvFXhmfiavy25zETA/dru9Yv7zXBB/8=; b=VqPABr0TGjmRPHW80VFyfwkrf1UbdFPHmfRs4WVdvlyQRTjzZCSJ9KTNQHuIqsU+0Z CLHBBZvAsLo9pfykIhvL2lIT51MDVetUBBAhRKNcJHM6M8x/Eb61yLMVHphJ6IZa4R6L 1wsnruiR0u0fGWuukmIUShPR9X5la+xZYsPiZYfZLgzyD9Bx4+F8Cb/LINxHXECOK2Uf Rl2XNE1YKQl5Wvu8qE3Z6/gIwU9+vnfndiEQD5TYH4F01gxwg0Yuu/VwZ7f0qBaEsjhx ZEREJS+tzwzO7n3HoWW9qUC3yWUns4shw2n/FsAYh6B5NBSNl7g92m+wELDoP+CVnVjm RSKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777109768; x=1777714568; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sSxxsg0M9lsnfvFXhmfiavy25zETA/dru9Yv7zXBB/8=; b=hs+z4/Lk3bg5uwHjnSb3dj6ka98bVCQlxfe4X/d0hRp1TqIcM5h6SHzAFu+UwQjYx8 JGKkwZnQQ2aAmiPYTS0uG9q1z67kuXmTLp8iW2cDh2ohjUY3AsKENaJsF0wtHl8QG4P/ pf0tiI7tbWEc6HaCj6N3NgF0eauO4mBjTazQpo10BKyYVBlpfKw0DnQvQ+ONxtneVpuz n7JPSwZ+KZoqsxDgvEbod3GpVHcT2HtpPm7F1k/U6ASkrsMVUs5OG1RoGIfawjCNacT+ IdzLcbwMlI6T9+Q4RrpEGvfYW0jwKpO3ZwxVQzatPTqi28tgzt4kexrwVZfP7qQiyax9 6nRQ== X-Forwarded-Encrypted: i=1; AFNElJ+MaFQ93mwzbyAtVjsDFQ2oWZO4JN2ivIj7bX5Slz2B8sUp4qlZw1822aCEKP1vGl1F+Ol0iivqAYhdaMk=@vger.kernel.org X-Gm-Message-State: AOJu0YweZqOXRV3ojPesrSxFNCMz/1i5uI9yLr2JCK9zsZ2Y79+m6ZK0 sgLiWodao28zljE/MMv9pGNWOmE2/c8J6vrMpGWJRtAqD6uh9/4OYaVoaOJoDr1rbPeBMo91ifp G6DxVPyw= X-Gm-Gg: AeBDievaZVuWoz5/mzJ0ag1gLTubmZrH9RedAG07H89/pt0z6o1ZOYAKB/IJf6hz+gM WLbvqQBhZsmF99hjJsaC0FVT82UnbbvbBtsuiFGgxL+Wsd3nckV1vMgzAgedo5xKnzrCnWw+E+K z6Dk9BdlZO756BO6IOyvgBvLZA/DqVYD7LxXXh4ghDzlMq1aucg72fTMHnvs5cN3ejW98xO92cp PTfbw3U9pBduTOppIugbdwFGhRezMN4xcXRLzjZFtAzIvzPJLiTxujLrTQXEgd1oN29u2/Ow1z5 YyITjLDixvqk045aRLOoa3nCOXSCfKa/xjoMwCU7tNMQvH3dy4KCi9TeHjvmGUIn/eC8Ea4xMdl +ulYrZTCXLp7MvLkQ30Ur2p/Xv3cVPLy6DnpLnLPza3GBy0lD+tUQfxGPAApmwlGf+wS/KG0Jkr 1/4wfpB5jN89J4ODUvggNC X-Received: by 2002:a05:600c:a410:b0:48a:5821:6006 with SMTP id 5b1f17b1804b1-48a5821692dmr228002255e9.4.1777109767130; Sat, 25 Apr 2026 02:36:07 -0700 (PDT) Received: from localhost ([2a09:bac6:37a8:1cdc::2e0:32]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a5aa3ae83sm491347625e9.12.2026.04.25.02.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 02:36:06 -0700 (PDT) Date: Sat, 25 Apr 2026 10:36:05 +0100 From: Matt Fleming To: Corey Minyard Cc: Matt Fleming , openipmi-developer@lists.sourceforge.net, Tony Camuso , linux-kernel@vger.kernel.org, kernel-team@cloudflare.com, stable@vger.kernel.org Subject: Re: [PATCH 2/2] ipmi: Add limits to event and receive message requests Message-ID: References: <20260421132544.2666174-1-corey@minyard.net> <20260421132544.2666174-3-corey@minyard.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260421132544.2666174-3-corey@minyard.net> On Tue, Apr 21, 2026 at 07:42:44AM -0500, Corey Minyard wrote: > The driver would just fetch events and receive messages until the > BMC said it was done. To avoid issues with BMCs that never say they are > done, add a limit of 10 fetches at a time. > > This is a more general fix than the previous fix for the specific bad > BMC, but should fix the more general issue of a BMC that won't stop > saying it has data. > > This has been there from the beginning of the driver. > > Reported-by: Matt Fleming > Closes: https://lore.kernel.org/lkml/20260415115930.3428942-1-matt@readmodwrite.com/ > Fixes: <1da177e4c3f4> ("Linux-2.6.12-rc2") > Cc: stable@vger.kernel.org > Signed-off-by: Corey Minyard > --- > drivers/char/ipmi/ipmi_si_intf.c | 15 +++++++++++++++ > drivers/char/ipmi/ipmi_ssif.c | 15 +++++++++++++++ > 2 files changed, 30 insertions(+) [...] > @@ -410,6 +413,7 @@ static void start_getting_msg_queue(struct smi_info *smi_info) > > start_new_msg(smi_info, smi_info->curr_msg->data, > smi_info->curr_msg->data_size); > + smi_info->num_requests_in_a_row = 0; > smi_info->si_state = SI_GETTING_MESSAGES; > } > > @@ -421,6 +425,7 @@ static void start_getting_events(struct smi_info *smi_info) > > start_new_msg(smi_info, smi_info->curr_msg->data, > smi_info->curr_msg->data_size); > + smi_info->num_requests_in_a_row = 0; > smi_info->si_state = SI_GETTING_EVENTS; > } > Would it be better to move this zeroing to handle_transaction_done()? Otherwise we reset the counter in handle_flags() -> start_getting_events() and the threshold is never reached. Thanks, Matt