From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88798337688 for ; Sat, 25 Apr 2026 12:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777119121; cv=none; b=dQbIixUPz2aPMHSNT/R0L0D+ic2hzbc+klZTNgV6iiDKtqzh4RFE6CVuXNjJr+obPxJ8vTrc9BUzYhL0yYFynzrtmjLoPblKfViCID0wooxvbooyJsC/4usiZrsFJ4jKMGw3fJIYCSta0i7bo3NtG1PIezV9t9FE8qoRX2UBmm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777119121; c=relaxed/simple; bh=6r7ZGIxUJ4oPtUDVKTUyb5Hr8A2W6tx5waz65gG1N3M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D7UYN/B5kGBwFozuf9T0qNLePnUjGY5r6J9YC7eVT0ymxyTVbzmhhESeAvEaLzKXCSWlmx0iLxH5019Hi0CB4REVKMlNDSiVyCqDXVz7Xwshoi0tQ6Jm0j5jWwBvx5Wzghjwr54rZf+bUlW1G/kxm84P3qRpwykH83Ml/lrdCrw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eRfaZNBB; arc=none smtp.client-ip=209.85.219.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eRfaZNBB" Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-899a9f445cbso104616916d6.0 for ; Sat, 25 Apr 2026 05:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777119119; x=1777723919; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6gay/cokIr98J17MOhI34XsPatibDg3KPXl0AYIhu8k=; b=eRfaZNBBoVRZboHnFFWjBZNQ/tvXeUDZmmA3XLp15QzzYykdSn53Oirv8C3e1Vfxul dtdVTcJMen9/tuw6hs6pHqQXvVFroOO4RTBp6kFXVSysivOmstGPXUkZfz5++PQN6rQF XBgQxVu+pRTkOf0Weqx+L7nAdqfj0NpoHgoHHypJlwpcBwwbNtllUaqs3OG5qDez41ki Fxc97Bzm0NyZZuK4qxvA23vAfjvxCtar82HA+C/UNUCriDLExNKKeL1Hfy9cb3M7z3P/ 7U7hDPBuBkd8VceOlSwsulrl15WQlyPsAnZFIYpinHvnRXUbj2uqgwbur9m6CvJZKTKy Th6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777119119; x=1777723919; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6gay/cokIr98J17MOhI34XsPatibDg3KPXl0AYIhu8k=; b=Gjt3TpVRIAf4KaLGWDufBaSAp4948kL51hV7sk8ucZoO0PsqnRwnoOLdkQ5AaYqPqO /CpnFjOKMTWC0aW3aH7k6wTmO9ZnhpscaNVSjO7pMD6prC6k8vxZa1LiPbYd6QG2BytZ sGYNTn7iwjSo6x1hzow57g/JNb/TVBmYOVC2gUTbxxQu7AB4oiH7LkdwL56zti3cQCOg ce1dQWSGQINZqwGhsIcrU01629I1AJSbMAnsWH7rdvjHsudlqxt4OBjQ0qQKKEL+X2I1 Vp5HJN1T2tRZ0dBpmAnO+bGeeqVLSckpsb9YFfKthZ771E/dJEYO/uZe3SqrI5JmD9bu V5kg== X-Forwarded-Encrypted: i=1; AFNElJ9nOqr8/8i+mm9kuGObGEA3WgoSVwnQQaw5DgQXXnw2YYrZaQDgGqD0NDjDGfXWWwvgkgq4Tj/CF3+tnWc=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/cAW03+WCztq2kFq9txiO6reybLR+g7k0zsfKCP9eLf6VaApJ wU5MTYMJshqCLTKPF/tqlkkHCPT9WqiegLj77SIcscPbxV19VjgXXVuzq5girQ== X-Gm-Gg: AeBDiesNWT3mpqP9fCR7+PAnfkvP3x5e8TzYQifZXDPcNhnbMMjzY+7CNjujjlBNjS4 MYE8SgjifHrNeaOk4OOsNAui+hSU3MxqabhUX2GmYv4oQa8WvH3Ohd9mPZP+f8sd7lNk0E4m/RH nK2IBO3SGOQaQHoI1eFst8+r22QiCZ7Dol8AdhM7WGztjiAASOY7Fe6SrprZ1mtkEb2R0H/UIhh sHpxACFrRy6dRM1rJT+Mh4yMcHCSjQ9Vhj+6nHf8MbWerzlwXE8enGrtTIatigbnO1pNdJSKp2F QxCZ/in8mOOhDVFJy3sgbvyCPA24Ae7SvYl16kc/NH9uS9BfuHcKaz7KZqcDIhg0UG2ejkLUxOK qrijZ9IBcPjd2DdPB+xUZ045kkrpVxNm8919t4XKwwJzVejT1EWyCJTxutONts/8DiTvx18S0V0 tByOjS4OhbyFV9qeSoiQRzUnxAhQybcQ== X-Received: by 2002:a05:6214:4f14:b0:8ac:a6f7:8a71 with SMTP id 6a1803df08f44-8b0280ea565mr510769016d6.24.1777119119444; Sat, 25 Apr 2026 05:11:59 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8b02aea5ebcsm212277826d6.44.2026.04.25.05.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Apr 2026 05:11:58 -0700 (PDT) Date: Sat, 25 Apr 2026 15:11:54 +0300 From: Dan Carpenter To: Alexandru Hossu Cc: greg@kroah.com, dan.carpenter@linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: fix OOB read in update_beacon_info() IE loop Message-ID: References: <20260425115936.2899314-1-hossu.alexandru@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260425115936.2899314-1-hossu.alexandru@gmail.com> On Sat, Apr 25, 2026 at 01:59:36PM +0200, Alexandru Hossu wrote: > The IE parsing loop in update_beacon_info() advances by > (pIE->length + 2) each iteration but only guards on i < len. > When a malicious AP sends a Beacon whose last IE has only one byte > remaining in the frame (the element_id byte lands at len-1), the loop > reads pIE->length from one byte past the allocated receive buffer. > > Additionally, even when the header bytes are in bounds, pIE->length > itself can extend the data window beyond len, passing a truncated IE > to the handler functions. > > Add two guards at the top of the loop body: > 1. Break if fewer than sizeof(*pIE) bytes remain (can't read header). > 2. Break if the IE's declared data extends past len. > > Also replace i += (pIE->length + 2) with i += sizeof(*pIE) + pIE->length > for consistency with the sizeof(*pIE) guards added above. > > Signed-off-by: Alexandru Hossu > --- > v2: Replace i += (pIE->length + 2) with i += sizeof(*pIE) + pIE->length > for consistency with the sizeof(*pIE) guards (Dan Carpenter). Please wait a day between resends and resend the whole series. regards, dan carpenter