From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 792E833F5AA for ; Thu, 7 May 2026 22:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778194045; cv=none; b=OvHclHJY+0ZZjNyIdwjF77ecRCbt4QApIak0qL2fIdH4vdf/U02dQee59gIp6yAGws0Q9+gOstVqN7XjMLMPLkMCtnepVzqSzDoNMlbF82PEolGxc1koFyPCsZukZy9/ofjpxl/IET/lZLBrNX9oxVNHc6ltz99In7/5OX1xyao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778194045; c=relaxed/simple; bh=vT1xlYOGQzAE7vqDwWmrOOi6+3ztl7fZzWwFl63Ks7g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BJZ7YEmmK1QBxxoL/k3lZsVuO4AE9ntGhqScN4SfH06YIryUvwdYn/3cjvLQ9oKJMXirlKfUkIgcNhre6CLMuO6RFxQymUEiP+1MIuJMZrmmIE1ke2iJsyO0lbOPmR2j4V6Pk80TBSqb/Q3hcSQh2oebuYApVLcWexRZmRqPsSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=fDqxFGFa; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=N5BeshJU; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="fDqxFGFa"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="N5BeshJU" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778194043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kPx3biXZ5x7Ot03ePSnGmceAWBV5EsYi4yVjJ9EvQ+c=; b=fDqxFGFa2TEJqj8Fg17oFpGGRdnUjtaHGRu+/zKpTCKcnGMiHKr6kwojCHRF4YTpFOBjru T6XO1sYKDk29IefJTmOqVMp3Stmn19Wnl8fs4O13LCEl/5M4hvFV4k676/TPHbkR8gdUKO pBA/uXQH2PRUJkbrfqBUWfKJqJTALyk= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-542-XZAk94NUPVC0ryDi5pYlwA-1; Thu, 07 May 2026 18:47:22 -0400 X-MC-Unique: XZAk94NUPVC0ryDi5pYlwA-1 X-Mimecast-MFC-AGG-ID: XZAk94NUPVC0ryDi5pYlwA_1778194042 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-7bd726a9569so29753687b3.3 for ; Thu, 07 May 2026 15:47:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778194042; x=1778798842; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=kPx3biXZ5x7Ot03ePSnGmceAWBV5EsYi4yVjJ9EvQ+c=; b=N5BeshJUqTXEL88xSZKu9aHUawSGen57MZYcZLDcie4EnpkZ3yflPLzkSlu62xX2Az TL2UhxXh3TqlJPn36BLuef6TBWsmVO/WdDsddjhKrp9CFRXoDR7zKl3DfvjJyUMbqH68 2By8q7YBT+T8IGYLpm90BwRRzsILfuxk9RX1LVzB+CfNaQ3sa5FejotXLhm0WdFgQ+Be px/fIOy6wsbewI7Qa/iCxjUIpmVej9JJkrljVRT3R75fqXbNXgW1NMWbEC76DX5nkg3O utWDONoO2PljSMgz88leWVKJM945UzgvlFBqNgqtAkN90a5aXYfWcadz9822ZlWf55sw qU8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778194042; x=1778798842; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=kPx3biXZ5x7Ot03ePSnGmceAWBV5EsYi4yVjJ9EvQ+c=; b=OBgaVBUM+h1Lf/V/ouRQkSAL5eV+byEw/6BrkpgjUaWBL3YS5LoY/XDKpg1DtvJaZD Y1OpDF7Kx5BaMcr7b5HtKwm/4nheam6jNQ+JtOeKDw10yVVUGp5LoLngo4MfGOs182Q8 kD5JjjIcDt+FDFmR5Acm6pP6BDJXg6ReoWPkVUvgOWqKdSiIFE6W00pwqH+iXCT4yUpy 5yl/MANcGXrSf5DHE+iFuE0Zeba0PTSc+xB/mc/uz/doJ2cGl48oWMzoVAX7M5q2Bp2P xVRXRh58EQCAognpmaWd29SPcRGMrumYKcHa1yITvTszSIvuiTLUuW5/rVJNdRSt7WFd OcQw== X-Forwarded-Encrypted: i=1; AFNElJ8QLytS8M23xcKW6sYot48C35O+d5l1ZN7s4be8+TKYiBIqG3ScsD0HeS+MdFyEIg0R28x3kOnUQxGvqsE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/lvuxQcTpsQ5445dD3aePsyHc9QqXoEQIZsiz+y5obSE73LiS mQoSjMm6bdGwhfQVa0o5niGD1n6F2nbib56e52fKSAYlQ93WGmvqIRer1zRoDMyikUjb95dQXrj hN5cqZyi6UVRCB4xE46rCy5+5KCF3Xa5Bw+B9MMkJqYOBsmZB9tHpIm9HzFiTFL7nys6/Ut9CPg == X-Gm-Gg: Acq92OHI6DRXcIk0tjIqxbPtMFEMpmTaYpcoV0C/qJCgCaryHShGKo4vWFwgQjVbEYn 5kxAsHtO/54mzc68th59i5UUNEbjLlAeh1ACK46JJnxakXSKUKREWQveUqQlPTTjK9MEr0p8SNs GqhsxvClMZcXHTwWko7422wR9MYbVyJvGrblJzFFDnbP8GDXCR+3OFM7KLgTo0JSWGR0ltfl1Up XfWos6ad+Ui6aBewWFg6Se3AeTK7bO6kUMYen9ztP+uImlDb+rApGk1m5SlkfK++WqhqtIyh/CJ lYxa5nlVgJ5viQ7yzvtHlup3YllWebbI65eZcckOJnUflNQwCMWVuEzdoAnblgqnFm6Uqw0DL/3 xhta+VxJ+rYrTc23oak4O X-Received: by 2002:a05:690c:4886:b0:7bd:4792:671e with SMTP id 00721157ae682-7bdf5f0f291mr121682017b3.44.1778194041666; Thu, 07 May 2026 15:47:21 -0700 (PDT) X-Received: by 2002:a05:690c:4886:b0:7bd:4792:671e with SMTP id 00721157ae682-7bdf5f0f291mr121681787b3.44.1778194041269; Thu, 07 May 2026 15:47:21 -0700 (PDT) Received: from redhat.com ([2600:382:811f:130c:1e79:48c3:5ed1:4c22]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7bd6652744asm102657847b3.1.2026.05.07.15.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 May 2026 15:47:20 -0700 (PDT) Date: Thu, 7 May 2026 18:47:18 -0400 From: Brian Masney To: Rosen Penev Cc: linux-clk@vger.kernel.org, Michael Turquette , Stephen Boyd , open list Subject: Re: [PATCH] clk: lan966x: use devm_platform_ioremap_resource() Message-ID: References: <20260506233532.176285-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260506233532.176285-1-rosenp@gmail.com> User-Agent: Mutt/2.3.1 (2026-03-20) Hi Rosen, On Wed, May 06, 2026 at 04:35:32PM -0700, Rosen Penev wrote: > Use it as another instance is used above. This one is optional so treat > it as such. The second sentence show go under the ---. > > Signed-off-by: Rosen Penev > --- > drivers/clk/clk-lan966x.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/clk/clk-lan966x.c b/drivers/clk/clk-lan966x.c > index 3c7a48c616bb..8c7b273eb756 100644 > --- a/drivers/clk/clk-lan966x.c > +++ b/drivers/clk/clk-lan966x.c > @@ -253,7 +253,6 @@ static int lan966x_clk_probe(struct platform_device *pdev) > struct clk_hw_onecell_data *hw_data; > struct device *dev = &pdev->dev; > void __iomem *gate_base; > - struct resource *res; > int i, ret; > > data = device_get_match_data(dev); > @@ -283,12 +282,8 @@ static int lan966x_clk_probe(struct platform_device *pdev) > } > } > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - if (res) { > - gate_base = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(gate_base)) > - return PTR_ERR(gate_base); > - > + gate_base = devm_platform_ioremap_resource(pdev, 1); > + if (!IS_ERR(gate_base)) { The original code makes the gate clock as optional. With this change, if the memory range is not specified, then a warning message will appear in dmesg. Brian