From: Dave Hansen <dave.hansen@intel.com>
To: Elena Reshetova <elena.reshetova@intel.com>
Cc: jarkko@kernel.org, seanjc@google.com, kai.huang@intel.com,
mingo@kernel.org, linux-sgx@vger.kernel.org,
linux-kernel@vger.kernel.org, x86@kernel.org,
asit.k.mallick@intel.com, vincent.r.scarlata@intel.com,
chongc@google.com, erdemaktas@google.com, vannapurve@google.com,
bondarn@google.com, scott.raynor@intel.com,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH v16 2/5] x86/cpufeatures: Add X86_FEATURE_SGX_EUPDATESVN feature flag
Date: Wed, 15 Oct 2025 13:43:23 -0700 [thread overview]
Message-ID: <af0ce2a2-8a7d-4a67-a58b-33d01099e75b@intel.com> (raw)
In-Reply-To: <20251010085346.292287-3-elena.reshetova@intel.com>
On 10/10/25 01:52, Elena Reshetova wrote:
> diff --git a/tools/arch/x86/include/asm/cpufeatures.h b/tools/arch/x86/include/asm/cpufeatures.h
> index 06fc0479a23f..30761c905b7d 100644
> --- a/tools/arch/x86/include/asm/cpufeatures.h
> +++ b/tools/arch/x86/include/asm/cpufeatures.h
> @@ -495,6 +495,7 @@
> #define X86_FEATURE_TSA_SQ_NO (21*32+11) /* AMD CPU not vulnerable to TSA-SQ */
> #define X86_FEATURE_TSA_L1_NO (21*32+12) /* AMD CPU not vulnerable to TSA-L1 */
> #define X86_FEATURE_CLEAR_CPU_BUF_VM (21*32+13) /* Clear CPU buffers using VERW before VMRUN */
> +#define X86_FEATURE_SGX_EUPDATESVN (21*32+16) /* Support for ENCLS[EUPDATESVN] instruction */
Sorry I didn't catch this before, but we don't patch this tools/ file
for individual features. We just sync the main copy over to here from
time to time. This hunk needs to die.
Second, please don't send things during the merge window. That's both
because we're busy, but also because I'm going to merge your code on top
of $VERSION-rc1. I'm not sure what you rebased to, but things don't
apply cleanly now.
Can you please fix the tools/ thing, rebase this on -rc1, retest and resend?
next prev parent reply other threads:[~2025-10-15 20:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 8:52 [PATCH v16 0/5] Enable automatic SVN updates for SGX enclaves Elena Reshetova
2025-10-10 8:52 ` [PATCH v16 1/5] x86/sgx: Introduce functions to count the sgx_(vepc_)open() Elena Reshetova
2025-10-10 8:52 ` [PATCH v16 2/5] x86/cpufeatures: Add X86_FEATURE_SGX_EUPDATESVN feature flag Elena Reshetova
2025-10-15 20:43 ` Dave Hansen [this message]
2025-10-16 6:38 ` Reshetova, Elena
2025-10-16 21:40 ` Dave Hansen
2025-10-17 6:19 ` Reshetova, Elena
2025-10-10 8:52 ` [PATCH v16 3/5] x86/sgx: Define error codes for use by ENCLS[EUPDATESVN] Elena Reshetova
2025-10-10 8:52 ` [PATCH v16 4/5] x86/sgx: Implement ENCLS[EUPDATESVN] Elena Reshetova
2025-10-10 8:52 ` [PATCH v16 5/5] x86/sgx: Enable automatic SVN updates for SGX enclaves Elena Reshetova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af0ce2a2-8a7d-4a67-a58b-33d01099e75b@intel.com \
--to=dave.hansen@intel.com \
--cc=asit.k.mallick@intel.com \
--cc=bondarn@google.com \
--cc=chongc@google.com \
--cc=dave.hansen@linux.intel.com \
--cc=elena.reshetova@intel.com \
--cc=erdemaktas@google.com \
--cc=jarkko@kernel.org \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sgx@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=scott.raynor@intel.com \
--cc=seanjc@google.com \
--cc=vannapurve@google.com \
--cc=vincent.r.scarlata@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox