From: Breno Leitao <leitao@debian.org>
To: Jie Zhan <zhanjie9@hisilicon.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Lifeng Zheng <zhenglifeng1@huawei.com>,
Pierre Gondois <pierre.gondois@arm.com>,
Sumit Gupta <sumitg@nvidia.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
dcostantino@meta.com, pjaroszynski@nvidia.com, Al.Grant@arm.com,
linux-arm-kernel@lists.infradead.org, kernel-team@meta.com
Subject: Re: [PATCH] cpufreq: cppc: discard out-of-range delivered_perf samples
Date: Fri, 8 May 2026 01:17:57 -0700 [thread overview]
Message-ID: <af2cEiouQbdpoavG@gmail.com> (raw)
In-Reply-To: <26deca86-44e3-4fd5-950e-59f913d9ee37@hisilicon.com>
Hello Jie,
On Fri, May 08, 2026 at 11:23:18AM +0800, Jie Zhan wrote:
> On 5/2/2026 12:32 AM, Breno Leitao wrote:
> > cppc_cpufreq_get_rate() derives delivered_perf as:
> >
> > delivered_perf = reference_perf * delta_delivered / delta_reference
> >
> > over a short udelay()-bounded window between two cppc_get_perf_ctrs()
> > calls. Per-read latency jitter on the underlying CPC register access
> > can skew the ratio, occasionally producing delivered_perf >
> > highest_perf. cppc_perf_to_khz() then linearly extrapolates above
> > (nominal_perf, nominal_freq), so the value reported via
> > /sys/.../cpufreq/cpuinfo_cur_freq exceeds cpuinfo_max_freq.
> >
> > Observed on an arm64 host (governor=performance,
> > cpuinfo_max_freq=3339 MHz): 15 back-to-back reads returned values
> > between 2997 and 4230 MHz.
> Hi Breno,
>
> Frequency sampling discrepancy through 'cpuinfo_cur_freq' in the
> cppc_cpufreq driver has been an issue discussed for a very long time.
Thanks for the heads-up.
> If the CPPC feedback counters are FFH on your platform, can you have a look
> at [1] and see if that helps?
Have you forgot to get the [1] link here?
Thanks for looking at this,
--breno
next prev parent reply other threads:[~2026-05-08 8:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260501-cur_freq-fix-v1-1-f84c9a423366@debian.org>
[not found] ` <7e55dd1e-2841-4918-8e3d-82203a70451a@arm.com>
2026-05-05 12:52 ` [PATCH] cpufreq: cppc: discard out-of-range delivered_perf samples Breno Leitao
2026-05-08 3:23 ` Jie Zhan
2026-05-08 8:17 ` Breno Leitao [this message]
2026-05-08 8:55 ` Jie Zhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af2cEiouQbdpoavG@gmail.com \
--to=leitao@debian.org \
--cc=Al.Grant@arm.com \
--cc=dcostantino@meta.com \
--cc=kernel-team@meta.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pierre.gondois@arm.com \
--cc=pjaroszynski@nvidia.com \
--cc=rafael@kernel.org \
--cc=sumitg@nvidia.com \
--cc=viresh.kumar@linaro.org \
--cc=zhanjie9@hisilicon.com \
--cc=zhenglifeng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox