From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A87013D47DE for ; Fri, 8 May 2026 11:33:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778239984; cv=none; b=JNqJqpz2GIY7O1PLcxSO/UUm1Q8N7dUPqjSeEvmNXu0uI8+cFZb3r0Q2qFMPonjqWKZvd761+Ib6Q6NT56nQSFvriX7TG/QNfDRtLHnYAaqBtMUJWqKq2LKbB6DbM+Z+5PfExiPyPXiEyRA8yzXbAjeJcCaPkgox3YxZIohzLOY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778239984; c=relaxed/simple; bh=0hrQlW5FpcXozs6wxkIBzDktzohYeRr936w21ThvyGI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ch2ftHuw7xrcwWRUYBCWmT/lBjPPqEqQeze4VyP68/SCrmfvHcNnFpLMx2mxyIzaeoZ+WSoIytdomEP+E0bPBRpdnbQi3WKqf1t1nT0PD/5ae9AwyCS1njlaKju+S2wTUE7Se+7i5KTo6nHfkj8PHMNObiC9KHwgFHmTw7aeHMs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=Vn71l7Fp; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="Vn71l7Fp" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-38a01c80c34so15047101fa.0 for ; Fri, 08 May 2026 04:33:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1778239981; x=1778844781; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=i3oCf6JjY2k4f2DdZmgb+d8lKs1DeUt4qK3/lGPB5dQ=; b=Vn71l7FpnSIU0F2hPUt39/RHKZQ/QE+lfppbrXyh7yvnN/ZaXuV+oro8PzjQB36fR+ PE5YH4couzw0R0XsxK3Ksabmcqm0Z/vzRtNAwLcisSf84Iilnnzwuy7tUoBDQf2f6QDv 2xRP+3e/lGQ3hBPD2WgzwR5zWHTKnV0G9UZ8bQYnb0QvY8J/M6+q0NygQ0PofggBvxVI Yyfh2dkAZTmCteBTNRXB5QF4c6TNbf5KoE27DT+yIVdjRFx4x/S4kYWUBq/IapgJwEZR avnnKMJBFp4/hVcIoSOvsCYCaGjnFSfGomiyCmt7q0hg+4W2uv4v/b4nw0mjmA0ZOe4p PNxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778239981; x=1778844781; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i3oCf6JjY2k4f2DdZmgb+d8lKs1DeUt4qK3/lGPB5dQ=; b=akNuAfWq/W8IjieLapG1X75z2zu6RC6hjGX1bEnjfM7njQsX3/YCxvf1FHJ1jnrk3V BEZisgmGIMlWW6ouTHiTl8OqEQddjvIN1+XsJ7ntFDE+z8fwxVsaxBY07ZOPRqzePJTJ ZL8Uwmh6qyimwDyGQ/nnVoCCy/gNJ18r+OHBnbvEwqHkjttSIgAAtGH7XuE7B8TzmKxB 6QrfP+thJ7+uI00ogkzpXuLw7erC0ISaAOtImQRQ1E91VF3DsPrsFCoBQ0Kzjgvx3JfA caLXeFDnzWoYfmjImbkGwcpJc+RN8dgYPvmzQ1tI5/hk6ZQEosrY4wskkFEj3tVFCEN+ fz8Q== X-Forwarded-Encrypted: i=1; AFNElJ/+lj4TMRWfFX1KLJbEJ72UFE6E0JBQM4NYUzrnoOf7DqFJPLb1osvnTvJoKOI7awSGRl8mFzGVIShQJsQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzlgaNp8C/xVS640tf1yAQrcZJPB9ayJpDgcL2Q9WoY1oKPw4Sp TXLs9XXX/Iko6PODHoWu6Pv+GJD86981xb27nkmCPA6zRiviMaI40yUxgdHiKujmOP3krGJ4tx7 HUn1lxE0= X-Gm-Gg: Acq92OGT1jVnxsZmQj+hpWJaWuA5WIEXBUDGbiTLxNUef19wYeBvf0HH4JFEeyp9XdF 0Eh+CgVr7NXqpjiW5/Thr2vtFb2ljamSA71hbrB731oqgsB/yDRfB2cI+iRjrfOeCQqtqLANldY PnjWXnPuwKK7iWvPpzxhPoGqYTEOoZV8hea38qu5c/SffFOhU/4KkRoMVZM6ToYXRzKPhoym+ew Nj077TU1bhLpAgV2hopmcOfLRt3OOTHUzKRgtcEhKNxJHIzDBztxMSrrBjQAsx4qOZeXgsGK9GF xLxns9+YT47PBs6J2v+/m0BbpcsbGfRUBLMRgG4sT74kNjgX28IU7id8NBBRTQdP4Of8BeSmZa0 uQfuozfLAU5V14inK2dktQht4I4LiBxfD/nA5aiOao2JWumJfQNw/g8C+xcpKDCDkeHk4kibkX7 6i/C9JYVk6/j54/ntGHG6kfCNn9GDsmqpXdC7vsNnZxVT000w1J2lexMjhlksMNU8DsZU8XCJxI FNH0eXXCRJUQUjADkB7Sci+I4coz69d+OTRixifRJwjCLlIDCzb8ewrtqHeHIuN2PPw1VXGROzL dJ2flNutecsTnmFA18o= X-Received: by 2002:a05:6000:26c9:b0:43b:3b80:6776 with SMTP id ffacd0b85a97d-4515d3dc30emr18803689f8f.30.1778239532551; Fri, 08 May 2026 04:25:32 -0700 (PDT) Received: from aspen.lan (aztw-34-b2-v4wan-166919-cust780.vm26.cable.virginm.net. [82.37.195.13]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-454917d57aesm3814079f8f.26.2026.05.08.04.25.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 04:25:31 -0700 (PDT) Date: Fri, 8 May 2026 12:25:28 +0100 From: Daniel Thompson To: Andrew Lunn Cc: Alex Elder , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org, mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, julianbraha@gmail.com, livelycarpet87@gmail.com, matthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 10/12] net: stmmac: tc956x: add TC956x/QPS615 support Message-ID: References: <20260501155421.3329862-1-elder@riscstar.com> <20260501155421.3329862-11-elder@riscstar.com> <2ce5897d-5bbb-486a-b0f0-0e30e54b451a@lunn.ch> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, May 07, 2026 at 06:29:15PM +0200, Andrew Lunn wrote: > On Thu, May 07, 2026 at 05:03:46PM +0100, Daniel Thompson wrote: > > On Fri, May 01, 2026 at 09:04:58PM +0200, Andrew Lunn wrote: > > > > +static struct tc956x_mac_speed mac_speed[] = { > > > > + { PHY_INTERFACE_MODE_2500BASEX, SPEED_2500, SP_SEL_SGMII_2500M, }, > > > > + { PHY_INTERFACE_MODE_SGMII, SPEED_2500, SP_SEL_SGMII_2500M, }, > > > > + { PHY_INTERFACE_MODE_SGMII, SPEED_1000, SP_SEL_SGMII_1000M, }, > > > > > > That looks odd. Some vendors implemented 2500BaseX using SGMII > > > overclocked. But that is not strictly 2500BaseX. Having the 2500BASEX > > > entry suggests you have real 2500BASEX, so why have an SGMII entry > > > with SPEED_2500? > > > > This is a consequence of the code that uses this lookup table being > > called both during initialization and from the fix_mac_speed() callback. > > > > During initialization we only have the value in plat->phy_interface to > > go on so we run the lookup table using plat->phy_interface (which is > > typically PHY_INTERFACE_MODE_SGMII) and with the maximum permitted > > speed. > > Something sounds wrong here. SGMII only supports 10/100/1G. You should > never be asked to do SGMII at 2500. It should ask for 2500BaseX. We weren't being asked. It was just an internal driver trick to common up some code paths. However I did a few tests and the internal driver trick doesn't actually do much we can't achieve a different way. With that changed I can (and will) remove the PHY_INTERFACE_MODE_SGMII/SPEED_2500 entry from the table. > > I haven't got detailed enough notes to allow me to double check but I > > think there were problems completing the initial MAC reset if we didn't > > write something sensible to the hardware during initialization. > > > During fix_max_speed() we get told to adopt 2500base-x. Reviewing the > > code I can see we don't propagate that and just use > > plat->phy_interface for fix_mac_speed(). I will fix the code to that > > the requested interface propagates properly to the lookup table but I > > think we would still rely on the SGMII entry to get sane initial values > > to write to the hardware. > > Getting sane values into the hardware is good, but 2500 SGMII is not > sane :-( BTW if you are bothered by SP_SEL_SGMII_2500M, that name comes directly from the TRM and I'd prefer to keep it if I can. The enumerated value we have to write into the SP_SEL for 2500base-X is "SGMII 2500M". Daniel.