From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.ilvokhin.com (mail.ilvokhin.com [178.62.254.231])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 179C33876B9
	for <linux-kernel@vger.kernel.org>; Fri,  8 May 2026 12:55:51 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.62.254.231
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1778244953; cv=none; b=jIHTK73rcO+YF9QbEHp+xlVJ3NbJ9e06Fh0qYNqrbIqQig1FuJ6sUgSFdoal0mfz7Y1pkalsyOmoluTT5tBzQAXL2CYMWS6iUaKbPl1hM0XcPV/XoidlMp1RiMwIKau9gppNg/ANx/gxgdJ8GOYstIxbZ7YRS+YEZr7naCuYFEM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1778244953; c=relaxed/simple;
	bh=S/vyKUH26+olahS4gpZHkxgMvnKWL/jrgRpl3EpUNRs=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=dsImL0CjMuJ0HdOILRK38fMbJoEuMSMLr01UJcUQWkal/uY16Pw9c7VJ+D8FziIWIP+CHVY380DDVuaKT5rIBUrxBPXRQ0FDzvrD15vUN0G1AWgk8cClDWXGOsxEdhHENr18qyacrnar2pC8/JnCNj0cxLcNjrRQUoi/K17eOhE=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ilvokhin.com; spf=pass smtp.mailfrom=ilvokhin.com; dkim=pass (1024-bit key) header.d=ilvokhin.com header.i=@ilvokhin.com header.b=FX5tuxwn; arc=none smtp.client-ip=178.62.254.231
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ilvokhin.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ilvokhin.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=ilvokhin.com header.i=@ilvokhin.com header.b="FX5tuxwn"
Received: from shell.ilvokhin.com (shell.ilvokhin.com [138.68.190.75])
	(Authenticated sender: d@ilvokhin.com)
	by mail.ilvokhin.com (Postfix) with ESMTPSA id E1C73D0175;
	Fri, 08 May 2026 12:55:49 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilvokhin.com;
	s=mail; t=1778244950;
	bh=L9LkP6IfnwuKgt1YNp8V3Dt/LBOhrd1qXUDJMhw/7h0=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=FX5tuxwnivsbvqENwf3dClXXsMHLdk4v/lilJMPu/NpBR/HTNXPwaDOL6QG30RXr0
	 IdEv1gxNFGjPmslIbzyUIsXaoemqsXLPjLZXz9ig0+tzSsIG9E2F4r40tKksc5p4jg
	 UNVUsR8MyOZK5TF6Ou728b8a8cSHLNtlwQ4q4OXE=
Date: Fri, 8 May 2026 12:55:46 +0000
From: Dmitry Ilvokhin <d@ilvokhin.com>
To: Mike Marciniszyn <mike.marciniszyn@gmail.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	Javier Martinez Canillas <javierm@redhat.com>,
	Andrew Lunn <andrew@lunn.ch>, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, Mike Marciniszyn <mmarcini@meta.com>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] drm/fbdev-helper: Fix deletion of stub for
 drm_fb_helper_gem_is_fb()
Message-ID: <af3dUohsYKMSZK6V@shell.ilvokhin.com>
References: <20260501204313.127616-1-mike.marciniszyn@gmail.com>
 <afzVhCHu3FTwn9w0@shell.ilvokhin.com>
 <afzkApARAHVuAcLW@PF5YBGDS.localdomain>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <afzkApARAHVuAcLW@PF5YBGDS.localdomain>

On Thu, May 07, 2026 at 03:12:02PM -0400, Mike Marciniszyn wrote:
> On Thu, May 07, 2026 at 06:10:12PM +0000, Dmitry Ilvokhin wrote:
> > On Fri, May 01, 2026 at 04:43:13PM -0400, mike.marciniszyn@gmail.com wrote:
> > > From: Mike Marciniszyn <mmarcini@meta.com>
> > >
> > > When CONFIG_DRM_FBDEV_EMULATION  is not defined this error results
> > > when building amdgpu_display.c with CONFIG_DRM_AMDGPU:
> > >
> > > error: call to undeclared function 'drm_fb_helper_gem_is_fb'; ISO C99 and
> > > later do not support implicit function
> > > declarations [-Wimplicit-function-declaration]
> > >
> > >  1777 |  if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) {
> > >
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Mike Marciniszyn <mmarcini@meta.com>
> >
> > Just hit the same problem, thanks for the fix.
> >
> > Reviewed-by: Dmitry Ilvokhin <d@ilvokhin.com>
> 
> Thanks, but actually there was already a fix.
> 
> Take a look at linux.git/master:
> 
> commit 927011b65a875302d08709bbe82eaf4d0d96c5d5
> Author: Yury Norov <ynorov@nvidia.com>
> Date:   Mon Apr 27 22:49:41 2026 -0400
> 
>     drm/amdgpu: fix build for CONFIG_DRM_FBDEV_EMULATION=n
> 
> I encountered this in net-next, but the above has yet to be put into net-next.
> 
> Mike

Indeed. Thanks, Mike.