From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59EB2C433FE for ; Tue, 22 Mar 2022 18:12:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240219AbiCVSNl convert rfc822-to-8bit (ORCPT ); Tue, 22 Mar 2022 14:13:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240201AbiCVSNj (ORCPT ); Tue, 22 Mar 2022 14:13:39 -0400 Received: from eu-smtp-delivery-151.mimecast.com (eu-smtp-delivery-151.mimecast.com [185.58.85.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4C5E569CD9 for ; Tue, 22 Mar 2022 11:12:11 -0700 (PDT) Received: from AcuMS.aculab.com (156.67.243.121 [156.67.243.121]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id uk-mta-116-Y9JyBsN6MQCkC0PcUTDBfg-1; Tue, 22 Mar 2022 18:12:08 +0000 X-MC-Unique: Y9JyBsN6MQCkC0PcUTDBfg-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) by AcuMS.aculab.com (fd9f:af1c:a25b:0:994c:f5c2:35d6:9b65) with Microsoft SMTP Server (TLS) id 15.0.1497.32; Tue, 22 Mar 2022 18:12:08 +0000 Received: from AcuMS.Aculab.com ([fe80::994c:f5c2:35d6:9b65]) by AcuMS.aculab.com ([fe80::994c:f5c2:35d6:9b65%12]) with mapi id 15.00.1497.033; Tue, 22 Mar 2022 18:12:08 +0000 From: David Laight To: 'Alexander Lobakin' CC: 'Wan Jiabing' , Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Jakub Kicinski , Paolo Abeni , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2] ice: use min_t() to make code cleaner in ice_gnss Thread-Topic: [PATCH v2] ice: use min_t() to make code cleaner in ice_gnss Thread-Index: AQHYPSxszwX/VYzTWUmJ1ZXJKTtOx6zJ/3twgAGw2QCAAAVpMA== Date: Tue, 22 Mar 2022 18:12:08 +0000 Message-ID: References: <20220321135947.378250-1-wanjiabing@vivo.com> <20220322175038.2691665-1-alexandr.lobakin@intel.com> In-Reply-To: <20220322175038.2691665-1-alexandr.lobakin@intel.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander Lobakin > Sent: 22 March 2022 17:51 > From: David Laight > Date: Mon, 21 Mar 2022 16:02:20 +0000 > > > From: Wan Jiabing > > > Sent: 21 March 2022 14:00 > > > > > > Fix the following coccicheck warning: > > > ./drivers/net/ethernet/intel/ice/ice_gnss.c:79:26-27: WARNING opportunity for min() > > > > > > Signed-off-by: Wan Jiabing > > > --- > > > Changelog: > > > v2: > > > - Use typeof(bytes_left) instead of u8. > > > --- > > > drivers/net/ethernet/intel/ice/ice_gnss.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/net/ethernet/intel/ice/ice_gnss.c b/drivers/net/ethernet/intel/ice/ice_gnss.c > > > index 35579cf4283f..57586a2e6dec 100644 > > > --- a/drivers/net/ethernet/intel/ice/ice_gnss.c > > > +++ b/drivers/net/ethernet/intel/ice/ice_gnss.c > > > @@ -76,8 +76,7 @@ static void ice_gnss_read(struct kthread_work *work) > > > for (i = 0; i < data_len; i += bytes_read) { > > > u16 bytes_left = data_len - i; > > > > Oh FFS why is that u16? > > Don't do arithmetic on anything smaller than 'int' > > Any reasoning? I don't say it's good or bad, just want to hear your > arguments (disasms, perf and object code measurements) etc. Look at the object code on anything except x86. The compiler has to add instruction to mask the value (which is in a full sized register) down to 16 bits after every arithmetic operation. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)