From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02B0A3E0238 for ; Fri, 8 May 2026 13:12:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778245925; cv=none; b=L7CcCV79ZgKmRdBkExRAGuo2RUZju9TzzjYz1lkNMhaMGekCwZMK9jc3jBwn0tEx18d9vCnFWFfaGP/zAWn1ulRSlbw+uAMNCwdc1mhcYYKJ6A0Qz05QadWhf5FNAZSY2fXS3V6XseZkYpbRT2IelztAKSC98R5n8g0ZOHGleAo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778245925; c=relaxed/simple; bh=FYfQBWXoI2SOwhI3/+KF/bHfaoZ7TvjdrPVMKD3eI6A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fZs6xRk/pJNtWly/S0muJAm971vIIMl8EhMZLHYFIwUSz0iT81tovewLBubep8GkbB/r76XdEiBmwm79jBAkolHdZtCM6EEldMzNTwde4OIYbGcZ2Yk170mV6DMRFDKbD/yrDIIwcWcHe/TaWALm0V4CmgjUAablv9dS+Zd78QY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CcNRnVik; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CcNRnVik" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44C8DC2BCB0; Fri, 8 May 2026 13:12:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778245924; bh=FYfQBWXoI2SOwhI3/+KF/bHfaoZ7TvjdrPVMKD3eI6A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CcNRnVik7tStztA4YNvBkXhij8kBGCaTiuoqXL5vpPQLQ3oz/7w9AfrUle8OLzVdE +p97tmYpulnTlzPcEmoYp9+HOL2NO7Vv/ZhwWSmOBrXfAajIIlRyXnnCEKzkq7oh7d Xx1krynH20WqQkWtRHs338KuNlNggCMeBxN3eZlMlN6GHen807Ui9whzWsHBEE4ZrJ C1PlYhaeXKQw44rz7QY86dvusS+T/a5e5VHyBFxWMxkrFqJPGiw2SToxB0LTTJx6uf FK0OvmKE1E4OM83oIjD194EGWYwcsQvOy+k1oAEmQLMEo/fSE+za5KVymMZdI1wXyU Pbr/+CPBEQT+w== Date: Fri, 8 May 2026 14:12:00 +0100 From: Lorenzo Stoakes To: "Michael S. Tsirkin" Cc: Dev Jain , linux-kernel@vger.kernel.org, Andrew Morton , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Barry Song , Lance Yang , linux-mm@kvack.org Subject: Re: [PATCH v5 09/28] mm: vma_alloc_anon_folio_pmd: pass raw fault address to vma_alloc_folio Message-ID: References: <96a2f5a938bf65315ac95e75b4e7741bae018cdd.1778192416.git.mst@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: -cc incorect email addresses On Fri, May 08, 2026 at 09:06:22AM +0530, Dev Jain wrote: > > > On 08/05/26 3:52 am, Michael S. Tsirkin wrote: > > Now that vma_alloc_folio aligns the address internally, drop the > > redundant HPAGE_PMD_MASK alignment at the callsite. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > Hello Michael, > > Could you please send the whole patchset or at least the cover letter > too, to everyone CCed on at least one patch? I only got two patches > from the patchset in my inbox so I have no context :) Please resend this with the right people cc'd on everything. You're using an out of date email address for me and Liam (at the very least), I mark all mail that ends up at the old address read without touching it, so saw this by chance only. It's been a couple of months now (predates this cycle) so I'm getting a little less patient about it, people do change their email often enough that it's something you should really be on top of for a non-RFC series especially. I co-maintain THP so would prefer to see this in context please. Thanks! > > > mm/huge_memory.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > index 8e2746ea74ad..f51c0841ce91 100644 > > --- a/mm/huge_memory.c > > +++ b/mm/huge_memory.c > > @@ -1260,7 +1260,7 @@ static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct *vma, > > const int order = HPAGE_PMD_ORDER; > > struct folio *folio; > > > > - folio = vma_alloc_folio(gfp, order, vma, addr & HPAGE_PMD_MASK); > > + folio = vma_alloc_folio(gfp, order, vma, addr); > > > > if (unlikely(!folio)) { > > count_vm_event(THP_FAULT_FALLBACK); >