From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2197C32C923 for ; Fri, 8 May 2026 13:13:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778245985; cv=none; b=Hqy3cQADT34dEX+En7aR26c2dK3CmkYWJ9Nv3b9QtIePQrI2UONkIBoDsJEEwxTtlIpRKMivGPFXm9MnYb9yyy/xGQGA1XKywFvP1Y2VOrrDotlp/Tnh2s1XFVH8MQ7K03PbaRYI3Ch4AbhtMugiubZfOxhvx5dLOPQ88AltcI0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778245985; c=relaxed/simple; bh=8SfbiGMsgZU5QY1nGIgVC/Y47n2mBdUgeSCINMu1Odg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LQfvk7bawk4Lw94sowp8wmQmaoKT+k5f8dEOj9skeIhxhjGt7j4BFonTxO4dPbL+wUDP6PT5wo2ZyVtAXrgowmsklb/ddapVT5KGH9yTiOiKG+EjF/fKwjhOiDDEMjyVTilbpG9elDKKk5RcO3DexcXsOirpBrplVZk+0tFRHc8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=hzgYEaBy; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hzgYEaBy" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2ba180a022dso82455ad.1 for ; Fri, 08 May 2026 06:13:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778245983; x=1778850783; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UfeHoHYCg5PRUJUcmkq+tWEtCYTcqi8Exur8keQ1cXQ=; b=hzgYEaByRfTOYjUOpDOIsjkb9n/Me2/dHLARC1FhBk0Adz4fA+R7Ud6GG5E/zzXYjt +4ulqqkTSIkFFDdzTpRYuMxg7MVNbl8TaFdSA6vZLqkcIWUt0Q8aN6RmP3D2uG+z2+k0 0UDS4uwTInPQk5g5zM5qNMr+1bhKNYS7k/oPLVCpKh8/HWgqbL+PIdoCfqmzOmdCiZHb 29Qnh6W1Xucl1QIl62r0cxD+2m4SbC7QWhJgV0F8ze9sEP0BG/EQvIlruf+BOaON6Zb1 KR2leqCHRH0ZQV7lbkahMbI/9OjADS+l8JzqjC3iEzCcGJ+IiXtMvRKO7hABNOYUa0Xa IpRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778245983; x=1778850783; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UfeHoHYCg5PRUJUcmkq+tWEtCYTcqi8Exur8keQ1cXQ=; b=IAHmrVYirHP3dct40+djtldl1Kf3eT1OumeZ/VaM5Yj5ColiR0W7pdXx2STHDGWh8R hGuZt5b7i7S0scOcdSDu2rPNtNBxwyvnrQM8wGc05TcKdyApC728d2NYblFj/QzxEGbB EC2O1R4SOMbXh66IJQJi/alHBdAjUSrt9uTkmvB+DKzymQ/B9TVZAViHRhZ7kkxdx6wy +SszZUpIhZfhzNYa93LWP5llaFCR+DqpyMxcc0QjFctzOr2PuKHrrzedI1yFa2U9t9pI cEb2oejGKVQRgu9wUkMWzFOK6oZO1MMOYp+kQnYCgetOApcJV1vHrddCy1IaxUZzmvfg f2bg== X-Forwarded-Encrypted: i=1; AFNElJ+7ML9iH8NX+P8o+0OC2VPMibwW/wRY/336TICPm6lL+lBiq+riLhE/lLtqFsMRHw18fMMjRF5sMMF6eIU=@vger.kernel.org X-Gm-Message-State: AOJu0YwYorAGvPz/VqgME4H7e9pMALmKE//Ql6omD8U6Yhf+LNglkrT1 PeiwLYbt/Oc7YO5bXF/VJAcgwv0AHPnr5EDOqsKIHYF8A8c80FH7JkZzzltdU7g8xg== X-Gm-Gg: Acq92OFJtk9AaXyyeHwUFbrwV3ZnzklpNkSrt8T9NZ1Nr2IHpCjkrzVDRH2y3itmBGW h57Q5k3IC1vx6zYbmLY1KZ5IrDyTVosF7Z7zu3OXZ4w27rR/o4n4GaVmm0f6c/+JzWToHVnTutZ dqF30ziIP2LKv69r8EYitVGkoeYOIJrO9xvbWOynEZIO74T/hFRYgGl1InMh/bdkc3ih/RQ48aB QYGrpHbnfXI6HldV1ud07UZLTJb6EF/AIss1SGzMb4tX7yRkswrDyzoTLaRW7AyUUeUQ0/mlnPR 1/WIKOFk3hd/curoBRbjESIiOwUjQmZIfasij4vklDt+B0IPPVs4sYozidEI8EuDS/JFyliFgwV z0/fFDxm+x5Xx1UtwKjPho4LCNRdWvsqFbI/naFlZkY5lP1D7RGkRgC1Zj0u6Z5hLocCva+oZnF JUperlQtugL6cM0kd6khTe/Rpc+lR97uOQ6naj2EWqR/84vo71z7A/4ntVoPqIr2gcrOhN3qXhJ yxfWhQ= X-Received: by 2002:a17:903:388b:b0:2b9:e831:5e5c with SMTP id d9443c01a7336-2bae9ab0216mr3382075ad.4.1778245982914; Fri, 08 May 2026 06:13:02 -0700 (PDT) Received: from google.com (44.234.124.34.bc.googleusercontent.com. [34.124.234.44]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3664db4f5fbsm2341255a91.15.2026.05.08.06.12.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 06:13:02 -0700 (PDT) Date: Fri, 8 May 2026 13:12:56 +0000 From: Pranjal Shrivastava To: Jason Gunthorpe Cc: Nicolin Chen , Will Deacon , Joerg Roedel , Jean-Philippe Brucker , Robin Murphy , Catalin Marinas , =?utf-8?Q?Miko=C5=82aj?= Lenczewski , linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/arm-smmu-v3-sva: Enable Hardware Access and Hardware Dirty bits Message-ID: References: <20260503135413.1108138-1-nicolinc@nvidia.com> <20260508123550.GB9254@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260508123550.GB9254@nvidia.com> On Fri, May 08, 2026 at 09:35:50AM -0300, Jason Gunthorpe wrote: > On Thu, May 07, 2026 at 10:30:14PM +0000, Pranjal Shrivastava wrote: > > > @@ -92,6 +92,16 @@ void arm_smmu_make_sva_cd(struct arm_smmu_cd *target, > > > > > > target->data[1] = cpu_to_le64(virt_to_phys(mm->pgd) & > > > CTXDESC_CD_1_TTB0_MASK); > > > + > > > + /* > > > + * Enable Hardware Access and Dirty updates (DBM) if supported. > > > + * This is safe to enable by default, as PTE_WRITE and PTE_DBM > > > + * share the same bit. > > > + */ > > > + if (master->smmu->features & ARM_SMMU_FEAT_HA) > > > + target->data[0] |= cpu_to_le64(CTXDESC_CD_0_TCR_HA); > > > + if (master->smmu->features & ARM_SMMU_FEAT_HD) > > > + target->data[0] |= cpu_to_le64(CTXDESC_CD_0_TCR_HD); > > > > IIUC, we should be setting these if IO_PGTABLE_QUIRK_ARM_HD is present? > > SVA does not use IO_PGTABLE at all, and it directly constructs its own > CD. > > No relation between those two flows. I understand that but I mean we need to know if the system supports HTTU ? Like for SMMU we use the IO_PGTABLE_QUIRK, shouldn't we be checking if the CPU's tables support HTTU? Are we assuming that if the SMMU IDR presents HTTU capability the MMU would also have it? I think an unconditional enablement is risky as we may not have system-wide HTTU support. If we look at arm_smmu_master_sva_supported, the driver already maintains a strict agreement between the CPU and SMMU for SVA. It checks sanitized CPU ID registers for things like PARANGE & ASIDBITS, and it uses system_supports_bbml2_noabort() to decide whether to enable FEAT_BBML2. Shouldn't we follow this exact same pattern for HTTU ? We should probably be checking cpu_has_hw_af() (from asm/cpufeature.h) in the SVA support check or here if we wanna enable HTTU. Thanks, Praan