From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ACD5CA9ED0 for ; Fri, 1 Nov 2019 17:21:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D588B2085B for ; Fri, 1 Nov 2019 17:20:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="l+1zCDXL"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="cLhqmYFG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727770AbfKARU6 (ORCPT ); Fri, 1 Nov 2019 13:20:58 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:37364 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726866AbfKARU6 (ORCPT ); Fri, 1 Nov 2019 13:20:58 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0EDD260FBA; Fri, 1 Nov 2019 17:19:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572628742; bh=vay1cC4Y6XG5HFwL0eefjYJon6gcGVMawCFumaTPMQY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=l+1zCDXLKatvwd7SjcQumNDpR8dXybAZbTOKm+Fav1cRRFOkW0acNq7S96+JTFpxd agWBXjrtaXKHQ6ikms4IvJ3zo1AFzrIPdQdPl66ZYi1etAG0ORPUBompNc2Iy+AMfw jvglT9ADF8ECBunuI6aFO6SD7Tbj6m+HqKoqhLcM= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id F1FB461065; Fri, 1 Nov 2019 17:19:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572628741; bh=vay1cC4Y6XG5HFwL0eefjYJon6gcGVMawCFumaTPMQY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cLhqmYFGxliSdKkO1EA+sR8KIzjuO5h+4hlvqhyoOHWMF7QaXo27oqt8dx2Pw5luL 3/njb1LOjlLuEAP4G7jmyQbt0g7/Qb28j/tmjEGVmaPHaPnc+UzU85mP1oD+q6ioMS oYLlgRmgLQQteUEEz1idHNTBT3TUFL4bxSqzzEdA= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 01 Nov 2019 22:49:00 +0530 From: Sai Prakash Ranjan To: Will Deacon Cc: agross@kernel.org, Robin Murphy , Joerg Roedel , iommu@lists.linux-foundation.org, Stephen Boyd , Vivek Gautam , bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Rajendra Nayak , linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCHv7 0/3] QCOM smmu-500 wait-for-safe handling for sdm845 In-Reply-To: <20191101163136.GC3603@willie-the-truck> References: <20191101163136.GC3603@willie-the-truck> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-11-01 22:01, Will Deacon wrote: > On Fri, Sep 20, 2019 at 01:34:26PM +0530, Sai Prakash Ranjan wrote: >> Previous version of the patches are at [1]: >> >> QCOM's implementation of smmu-500 on sdm845 adds a hardware logic >> called >> wait-for-safe. This logic helps in meeting the invalidation >> requirements >> from 'real-time clients', such as display and camera. This >> wait-for-safe >> logic ensures that the invalidations happen after getting an ack from >> these >> devices. >> In this patch-series we are disabling this wait-for-safe logic from >> the >> arm-smmu driver's probe as with this enabled the hardware tries to >> throttle invalidations from 'non-real-time clients', such as USB and >> UFS. >> >> For detailed information please refer to patch [3/4] in this series. >> I have included the device tree patch too in this series for someone >> who >> would like to test out this. Here's a branch [2] that gets display on >> MTP >> SDM845 device. >> >> This patch series is inspired from downstream work to handle >> under-performance >> issues on real-time clients on sdm845. In downstream we add separate >> page table >> ops to handle TLB maintenance and toggle wait-for-safe in tlb_sync >> call so that >> achieve required performance for display and camera [3, 4]. > > What's the plan for getting this merged? I'm not happy taking the > firmware > bits without Andy's ack, but I also think the SMMU changes should go > via > the IOMMU tree to avoid conflicts. > > Andy? > Bjorn maintains QCOM stuff now if I am not wrong and he has already reviewed the firmware bits. So I'm hoping you could take all these through IOMMU tree. -Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation