public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Johan Hovold <johan+linaro@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] arm64: dts: qcom: sa8540p: use sa8540p gpucc compatible
Date: Tue, 26 Mar 2024 17:02:43 +0100	[thread overview]
Message-ID: <af7ef0d4-031d-42ac-aad5-c8ce86deff96@kernel.org> (raw)
In-Reply-To: <20240326140108.21307-3-johan+linaro@kernel.org>

On 26/03/2024 15:01, Johan Hovold wrote:
> The SA8540P platform is closely related to SC8280XP but differs in that
> it uses an external supply for the GX power domain.
> 
> Use the new SA8540P compatible string for the GPU clock controller so
> that the OS can determine which resources to look for.
> 
> Note that a fallback SC8280XP compatible is added temporarily to avoid
> any temporary regressions for sa8295p-adp.
> 
> Fixes: fd5821a1a83c ("arm64: dts: qcom: sa8540p: Drop gfx.lvl as power-domain for gpucc")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>  arch/arm64/boot/dts/qcom/sa8540p.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8540p.dtsi b/arch/arm64/boot/dts/qcom/sa8540p.dtsi
> index 23888029cc11..3b31a9ea3492 100644
> --- a/arch/arm64/boot/dts/qcom/sa8540p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8540p.dtsi
> @@ -168,6 +168,8 @@ opp-2592000000 {
>  };
>  
>  &gpucc {
> +	compatible = "qcom,sa8540p-gpucc", "qcom,sc8280xp-gpucc";

This introduces new dtbs_check failures. Please fix the binding and drop
the last patch in the series.

Best regards,
Krzysztof


  reply	other threads:[~2024-03-26 16:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-26 14:01 [PATCH 0/5] clk: qcom: gpucc-sc8280xp: fix GX external supply lookup Johan Hovold
2024-03-26 14:01 ` [PATCH 1/5] dt-bindings: clock: qcom: add SA8540P gpucc Johan Hovold
2024-03-26 15:59   ` Krzysztof Kozlowski
2024-03-26 16:40     ` Johan Hovold
2024-03-27  8:54       ` Krzysztof Kozlowski
2024-03-28 15:43         ` Johan Hovold
2024-03-26 14:01 ` [PATCH 2/5] arm64: dts: qcom: sa8540p: use sa8540p gpucc compatible Johan Hovold
2024-03-26 16:02   ` Krzysztof Kozlowski [this message]
2024-03-26 16:48     ` Johan Hovold
2024-03-26 14:01 ` [PATCH 3/5] clk: qcom: gpucc-sc8280xp: make cc descriptor const Johan Hovold
2024-03-26 20:45   ` Konrad Dybcio
2024-03-26 14:01 ` [PATCH 4/5] clk: qcom: gpucc-sc8280xp: fix GX external supply lookup Johan Hovold
2024-03-26 14:01 ` [PATCH 5/5] arm64: dts: qcom: sa8540p: drop fallback gpucc compatible Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af7ef0d4-031d-42ac-aad5-c8ce86deff96@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=johan+linaro@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox