From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF701800 for ; Sat, 9 May 2026 10:37:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778323078; cv=none; b=nmDoUrOsG5hFnmta8jMYk1czk00fCkQvT+Ipauj+tJhlW2jGZzebLTEeSjFWSXPpzS9Y1gRy9r0H4PMVIXTgdO9UsV+gsr8SHQzZjpcLfY1vCHUyK7krFUMRwGoxULPB/+lebmji8yBR++Ro+DHWjXTd1fM8k3QXQgcI1X0UD5A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778323078; c=relaxed/simple; bh=K5jOAjXnEFl+WnEbY8D+qdajq8wlKbA6J8UiAdWgo5E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=StNA9Qj6zZVmr2kcmqM5SOcwNqffbxv89Ev1CnEdwUe4tZ+VlAzwFOxbnRSl+5y2dflgTtJP8IdZr18pZeFCG1u2WfPOzZVVxeSjCKIsl2T0CbEeFjAvpFQMXY44GsKx4lXpfeqDjBdyOFsLvxtVkblfVrLIuxKJs9gpEZBbK+Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ZcmMzidT; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZcmMzidT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778323075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Zws/UsYPDTE2f+Lv8npjbyjMyTWAVxyY3Gq8ji+FH2w=; b=ZcmMzidTzP578qazjwPJhNpqdSdN6nkgMURNalpsE/V5df2YBqJOC+hxNeX0e65VvU57lU p6YT+C20Hz5lNrh3mc54d0VV/w7Dcen8ZGfGQxCq6KcdBBdo0Po+Gbx8zewrfZztbQmH0u 2G5r/soGsyrHBgQNJm1euJIPexhpQQk= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-356-KDyijDIWOVaiDdBcaNhOxA-1; Sat, 09 May 2026 06:37:53 -0400 X-MC-Unique: KDyijDIWOVaiDdBcaNhOxA-1 X-Mimecast-MFC-AGG-ID: KDyijDIWOVaiDdBcaNhOxA_1778323071 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8AE0B1800451; Sat, 9 May 2026 10:37:51 +0000 (UTC) Received: from fedora (unknown [10.44.48.223]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 32F653002D31; Sat, 9 May 2026 10:37:48 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Sat, 9 May 2026 12:37:51 +0200 (CEST) Date: Sat, 9 May 2026 12:37:47 +0200 From: Oleg Nesterov To: y2k , Andrew Morton , Deepanshu Kartikey Cc: brauner@kernel.org, linux-kernel@vger.kernel.org, syzkaller@googlegroups.com Subject: Re: WARNING in do_notify_parent (kernel/signal.c:2174) Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On 05/07, y2k wrote: > > 7.1.0-rc2-00099-gadc1e5c6203c > arch: x86_64 > preemption: PREEMPT(lazy) > > > REPRODUCER (syzkaller program) > ------------------------------ > # {Threaded:false Repeat:false Procs:1 Sandbox: SandboxArg:0 Sysctl:true HandleSegv:true} > syz_clone(0x200080, &(0x7f00000003c0)="9562597ade4c359303b4585229dfcf8a12e5a172b6bfeb0d6d973e21df1c19605d9eb45142bd770cb6310057f646adcbde17681e392e8c11af0836a4ffff47c8c083fd4da4af3fdaa71e8a42df556d90bfb7e2511aac2628e271cddf224733c2881a422684cd3c7033fd24e00b205efdd94ece24e22040e80a310fb8cfaafecb00e067c5c2dfc13181c8773d3a37aa7635b8da5dbf2c9b25a7192f3861c442929542a4a564920eb870a06b383e781fe0d54d05275c7e2cd2f901c72c8270308a5db0adbed89176bac1122b21cb2e2d202569ae8d5a97cbce75aff3444207cb68bfcf", 0xe2, 0x0, 0x0, 0x0) ... > WARNING: kernel/signal.c:2174 at do_notify_parent+0xfef/0x11c0 kernel/signal.c:2174 ... > Follow-up: I found that commit 0f8e38eeb995 by Oleg Nesterov > ("do_notify_parent: sanitize the valid_signal() checks") appears to be > related to this WARNING. >From the changelog: Now that kernel_clone() checks valid_signal(args->exit_signal), the "sig" argument of do_notify_parent() must always be valid or we have a bug. This patch depends on [PATCH v3] kernel/fork: validate exit_signal in kernel_clone() https://lore.kernel.org/all/20260316151956.563558-1-kartikey406@gmail.com/ Was kernel-fork-validate-exit_signal-in-kernel_clone.patch in mm-tree So it seems that my patch is already merged, but the patch from Deepanshu is not... Oleg.