From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD4EB27603A for ; Tue, 28 Apr 2026 04:14:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777349684; cv=none; b=rB9vXJyf9H92Tk9Kc+9Ao0d4JJtA2MEolhYNIhjBvXwFP1lrW8qZA3YNDAtQ8b73mk5kEWbmvtQE0SKSnFVZQ8VfEcF4R7jdr933ADYDMcB50RhnJrr4SK4hJI0zKoKSMbaJb1J92XI2+lww+6ltJg/IOBHSL6PhjzRZ5dXZHgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777349684; c=relaxed/simple; bh=dIyVXV1vWjWkWQ8ruG4jjcBiCKLroMm3AaMH2Co8U/o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BvjOoI9DiBM1D31olE4qXg8VN6R187dH0zsgAzBvE5dE2EOeZEFbvTNTLeSVsGrKOzTXPG8psQuCFJyAZ0h047oIXtF+Sjw2ccYb5gocPMz/1W/mSyb1QOykVa3zBPkqJl7h2hw818jksGJ4HvESfobq8Yb82QO2HU4BX4T6+ho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZfC4WT/f; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZfC4WT/f" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-12c726f46baso13852928c88.1 for ; Mon, 27 Apr 2026 21:14:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777349683; x=1777954483; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=kEz0oDUdcTpFuThs6YX23JY5C5KbjbJBY3HgDPzdlsM=; b=ZfC4WT/fJJpZvEc6wpGFwfi8GMKcAJybsGz7JqB8sk40gvTnEA47n0HZI/HVh5d5ZC W7g1VoPQ9oBNjlXolezxvo5Al9HBTooTJsLe/IqRoRDPWnUOHJwJpiKh4TQtYgTQxyPb CcgRs18UAQj/MgVkorkqsUJLNNs5w/sZMlYf47ZKYeO5NQgcjUj17eY56ILgWYsoRK1F eAso6/f5UBe6H1p947qiD4AXYcLYrE7EwuE9X9o3vzuQXHwmdht1hfbKBo8Beu5Aru/Q RzARFFXZ1WVkt7mxmsDBgAH3Ikrf9+qmVfJndoCEvmTFktWVAqvRngXtXdsI6dVIDBr7 my0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777349683; x=1777954483; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kEz0oDUdcTpFuThs6YX23JY5C5KbjbJBY3HgDPzdlsM=; b=ZDOZEdg2V8/oqFMhhXdTMbmOl0dlm4PNRQ1noX079ADIpCPrDONacLaEvR7FohM2X7 J4MEs+fZ0jrAEBn0iVxfruNr+Q+Nm9KEcHD4k6MD+pm/Ph5rYBoBhQObejG7c8/qxW/v g0gKS/1bDQiWKx53z6x2HdpSWd15XomKuDOq2eYz2aPxyuUMEa+djN/mHULKUkC0GklU qufA+D98PDuAAfZ/p85ScI/AblEWDtwhgUx/GCAGIsfPCnSaUCfeEm4cafAlYLfGlmRA wDDqvGTtbbanlC9km0XILyUGyFRtjTdLBeo9BKJ6q2Z661r0zI/QmicadQ+0iOyWmJGj 8nLA== X-Forwarded-Encrypted: i=1; AFNElJ8JfMpv/gM+a/NC+sym1+wqZaq9p1hWqcRXILXg69qPlRR3b2w3XcB3a73GgpOy1876xAFITf00/6bJRG8=@vger.kernel.org X-Gm-Message-State: AOJu0YxUZ0nCsK+pvrrr5aEjAPagqEUSVGxeiV35A4lJc7rn1aXsZetD 4d6fIUGPRcmlCfrqodd1b3QUUL3wESpyHx5FFrcMKx18SX8QI1MHUtZS X-Gm-Gg: AeBDievGJdBL1CMB075sg3v3OIxbgGCOx33tI/VYc6NNjTo1Va6dCQjM0sR2XjYK8g6 4dQ8fpvvEgu1uGrnO60/YyZ+VsQ4uv3pgaOFit35KhoSjUll5Hc5l3TEVyP/3ZWIn7oAIUzyIlK WcI8cawOQBNIgAcjmyak+iKE14HO+ksCgbHmVXqRzJUxm54kvL6FZZITlXWOnt4XTb7CXmn/ELs 3/zQYFFtkLTpxeGAXAgiD2/QtRuvgy+shZQvlADNB2GsR7Z7tzxH/ggj1ntlYO1fvRzZN3XQzPd XNRymDV2ekJK6emoUgXDXttc5C006EvZc/gPM/LB9YbyaVjVvhTJCY6flnXaPfR9Piyo85Jvgm6 l+yGBgOiadlHgS3I05Z/t7LGfUTkn6Xu9lXjQxdn6QYizbdH94QU8zKOefxs4u+ecuPXn4/JoJ+ k1iCHcygg4UjI8ncWZ+/6x1dyDVzgpcsNqm1IEfVdYc27XVrFo6QOr0ci4C6/OngFeUPGLVs9nE tNx2YLP7y+MVg== X-Received: by 2002:a05:7300:6147:b0:2c1:7afc:df06 with SMTP id 5a478bee46e88-2ed09f92a3dmr773004eec.5.1777349682735; Mon, 27 Apr 2026 21:14:42 -0700 (PDT) Received: from google.com ([2a00:79e0:2ebe:8:e678:f42a:a63c:516c]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ed0a10650esm1250234eec.22.2026.04.27.21.14.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Apr 2026 21:14:42 -0700 (PDT) Date: Mon, 27 Apr 2026 21:14:38 -0700 From: Dmitry Torokhov To: Arnd Bergmann Cc: Matti Vaittinen , Lee Jones , Arnd Bergmann , Gatien Chevallier , Marco Crivellari , Fabrice Gasnier , Andreas Kemnade , Krzysztof Kozlowski , Charles Keepax , Christophe JAILLET , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [v2] input: gpio-keys: make legacy gpiolib optional Message-ID: References: <20260427143406.3020992-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260427143406.3020992-1-arnd@kernel.org> On Mon, Apr 27, 2026 at 04:33:49PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > Most users of gpio-keys and gpio-keys-polled use modern gpiolib > interfaces, but there are still number of ancient sh, arm32 and x86 > machines that have never been converted. > > Add an #ifdef block for the parts of the driver that are only used on > those legacy machines. > > The two Rohm PMIC drivers use a gpio-keys device without an actual GPIO, > passing an IRQ number instead. In order to keep this working both with > and with CONFIG_GPIOLIB_LEGACY, change the gpio-keys driver to ignore > the gpio number if an IRQ is passed. > > Link: https://lore.kernel.org/all/b3c94552-c104-42e3-be15-7e8362e8039e@gmail.com/ > Signed-off-by: Arnd Bergmann > --- > v2: skip the fake GPIO number passing from mfd > --- > drivers/input/keyboard/gpio_keys.c | 7 ++++--- > drivers/input/keyboard/gpio_keys_polled.c | 2 ++ > drivers/mfd/rohm-bd71828.c | 1 - > drivers/mfd/rohm-bd718x7.c | 1 - Let's see if my patches to rohm drivers will get accepted and then maybe we can remove legacy gpio API from gpio-keys altogether. Thanks. -- Dmitry