From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A38A265629 for ; Tue, 28 Apr 2026 09:14:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777367696; cv=none; b=fZNuIeLOhceZ4IXGF/tB2DUC2e5oCx29GHFLESM1obPFFFl7SH0cWrg4QPjpSECINsp7Dq3iO65xKEiwcZoAuRZQvvltkFEjRlD26+Lg0ISCYBdDZjGNCRN6glzylk0Xr3h6MWFOnsdVjjLjdJt5Yuo/9NHDV3uuqDOpEuU3Hk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777367696; c=relaxed/simple; bh=8AApnqTTa/y5FGl+Pf2GwXQp/b/aY7JipPnmTvGV824=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gd617Q0bmMOjvaQCrpGA7s78corB35oAbhJY6W9w0NwaUurr1PgqUfmytbBsX8cQShMUmWrRTEF3Sk8I9xCu/8gHVzhrvb0o/x3ek0DUHw0FOgFd5E+SNXq6cEee/vwQkV9Rx8wAu1y8YVr46ghiTeDMbOWwF+no690aJYZVCoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Lb6jkpx0; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Lb6jkpx0" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-488e1a8ac40so137766425e9.2 for ; Tue, 28 Apr 2026 02:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777367693; x=1777972493; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qNOsPKOzldEqNG1+DveJbYY2Z5WlvWIU1aJujOgzo5U=; b=Lb6jkpx0EGwXGoFrv4c3ayAmYa+cxpwMAu87ONgRkkMgRiKIUsr6/Gh9HXaUVQXJJF +oWQ8XWEG0l08iiqwukBbRs0XAWVubRCJYOa5vVkz9nyZ507HRm0iDTOp8ZozDAKcJMY qIc872DOPdjsLezbPQ4gQ7/4sAM0ypsPBg9uFNYWZ8kSZYMXJH0n7iG8wPtFeRzhi+KB WjIUoW3B6MuSvsq+6g9q9x6HrHq6o82G3Yg+0vdnz0T6PvwhZw+x9zEiCekeXTk0Sgo7 UKy0Xls161AUSurikuIUVW6oFARq3vyjZbyejVw2SYWGLZZVXhP2SEDdsAd17P0ixr3G Ujhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777367693; x=1777972493; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qNOsPKOzldEqNG1+DveJbYY2Z5WlvWIU1aJujOgzo5U=; b=lMr9m+AI4R8yjyD4JrfeVBb10MaVcNfRDnNa50ERpFXEgA4nn05hd6u2ZKY1W65yAr 3yNp3LNZiOgtvfxXj65lXGL+fMRiu4I1Yd6k6miwzYxjmEmDG8s1FBdQAfaHFf96SaQI hlXkxHy0Dgcw7x5kRj16JeUPQjavobJ4VoKVBIkycbY3/Z38GBw6DcmETQ9CoNd4PuX7 S5s0X9NTNu/WhuxoLg+X9Ux3pWnlMjLRveZ+671aE9OdNiWB8Wc9HbVGALTJ13yCAQYn AwiBBNpLCLOBVdZYaJLEVvg8ShI86vCebD2RIUZHl6cpW3qgI/6Nvi+vI4tYwfsouxAB 2x2w== X-Forwarded-Encrypted: i=1; AFNElJ/SFuy5quFx8RE72AI+g6avjuWpfO1o3ETWGcKG28h8FdzU09t/s0KS85R/u49V5+SW9KC4QeIXrgjqjsQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yy7cNIKu1Dh3XSiRc8mSTXgslBVQkOdDXXaOVsQ+q/qjXAVZEoQ tHDkQB9F6itpIiOTeEpZ+PU4oEsc26t1LqHrNhgPbkGBE889GJCRvKNz X-Gm-Gg: AeBDietlkEEkAoh0ejZHZR8xFTG2EeU/lNKiFse8J0Zhm3WrT7G+M4ZDqLsuTS9Fl8d W14Urjytp62IsU+jyQSI5QVTqpxJ4634+V+3HDpyy40FNzoKu+VCPYJMMnkx0SavmCubUtxq1yf 7SMn3OarBasuEaos57ewlqrqY81f2C0cjnlSsnvNffmQeJ19xD9YoWhrzC6FicJhquxdtkmf+GD G1tYSkMBTtnvutEHNhgQV4wRXQpoBisVHmlFHO65IzLJ2/bt8Bdf804HJWYItD9jpOx2QFeWhyo TMtjO0sNF2/OfIP683tMux/V2dz9DOgWQ2s6AHzBWLtRblWDJTiWeKRm0zLus+lziRCkHVk8pJt /QPkT0dJv6uBrqnX+1gOlgvo3iLKw2pLHekLiL+qfscF/1fxOKAos83t3mBXaAzNymMpcb/vZON COOJXRnU/z1Ag6Ep4mBwM6sbYXXqk3Fg== X-Received: by 2002:a5d:5f51:0:b0:441:1df5:480c with SMTP id ffacd0b85a97d-4464a070032mr4187168f8f.42.1777367693356; Tue, 28 Apr 2026 02:14:53 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4463cb59e5asm5190266f8f.5.2026.04.28.02.14.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 02:14:52 -0700 (PDT) Date: Tue, 28 Apr 2026 12:14:49 +0300 From: Dan Carpenter To: kernelcoredev Cc: gregkh@linuxfoundation.org, vireshk@kernel.org, johan@kernel.org, elder@kernel.org, greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: bootrom: replace dev_info with dev_dbg for firmware name Message-ID: References: <20260428002448.4829-1-sonionwhat@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260428002448.4829-1-sonionwhat@gmail.com> On Mon, Apr 27, 2026 at 08:24:48PM -0400, kernelcoredev wrote: > The original dev_info call was intentionally temporary, with a FIXME > comment noting it should be downgraded to dev_dbg once modules with > valid VID/PID values were common. Project Ara was cancelled in 2016, > so that time has long passed. > > Remove the FIXME comment and downgrade to dev_dbg as originally intended. > > Tested via code inspection only, as Project Ara hardware is no longer > available. Put this meta commentary > > Signed-off-by: Bentley Blacketer > --- ^^^ Under the --- cut off line. > drivers/staging/greybus/bootrom.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/greybus/bootrom.c b/drivers/staging/greybus/bootrom.c > index 83921d90c..757460c8b 100644 > --- a/drivers/staging/greybus/bootrom.c > +++ b/drivers/staging/greybus/bootrom.c > @@ -168,12 +168,9 @@ static int find_firmware(struct gb_bootrom *bootrom, u8 stage) > intf->ddbl1_manufacturer_id, intf->ddbl1_product_id, > intf->vendor_id, intf->product_id); > > - // FIXME: > - // Turn to dev_dbg later after everyone has valid bootloaders with good > - // ids, but leave this as dev_info for now to make it easier to track > - // down "empty" vid/pid modules. > - dev_info(&connection->bundle->dev, "Firmware file '%s' requested\n", > - firmware_name); > + > + dev_dbg(&connection->bundle->dev, "Firmware file '%s' requested\n", > + firmware_name); Please run your patches through checkpatch.pl. https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ regards, dan carpenter > > rc = request_firmware(&bootrom->fw, firmware_name, > &connection->bundle->dev); > -- > 2.54.0 >