From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C10023AA18B for ; Tue, 28 Apr 2026 07:17:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777360644; cv=none; b=kKeFfi+IJDpg5wZRclsbzfM2AYPneL8C5LrToRgezEigCzprGkNLarUq/0/VypduQDIMz2wGRMRJoZslYWLQ6TC3WhSd05ISYE2PSQ+0SeZPaJLu/R9rZ04rK+PyXzRNwhMON8hi7DE9fJ6qLLb3bwAjk8p3DjWbcGra03dAvMs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777360644; c=relaxed/simple; bh=x9qJIinO1nbogO7nsvx80qmxge1hX/VRXXcguBHeeBU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=guBK7YZq0DM2nql6SXyvdWFhGObuFscSjcwOTEuUOymQJ5LAcRjGrKlv3G/xTshuv00509CqeVPKAKAJxpbeftAdKRL2NVmHmr0kUz9muGrcU1blHOt37pUF3q8akvFBA0HDGagEyf6ndLtRJaxlGLviqZzgORi4qFWD5H1cB8w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s/Sw97Dt; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s/Sw97Dt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CB853C2BCAF; Tue, 28 Apr 2026 07:17:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777360644; bh=x9qJIinO1nbogO7nsvx80qmxge1hX/VRXXcguBHeeBU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s/Sw97DttDLFUyysya55VdNHbAtjN6EvA/HnLuN9KLgoGNh+23d7x61vhdm0euIMp UtSXK5R3sBkVa52RpDSncu4CcnwlAvWaOAvF4ysfEkiAbr3ZrhqAEkOPxktj8km0iT EVbPcP/JxmKJmM1AqwyePCkw5W7yE7sy/FPMphWhHLoxQYXxn5t/dNAQ7hvsV6lLBo sTYTon165DhK9vFnkcBR+vWM1y8XR/qkviuBmKThOZKLPE80Lkbsjqp/9riIlyql5c VLQEk+0sbjAcGXGxvoXV8t7QokdfpoCQ5120+J4235p/yyVccZLhosagV6hsaT/sTC VV4jjZfM/mCAQ== Date: Tue, 28 Apr 2026 09:17:16 +0200 From: Mike Rapoport To: Muchun Song Cc: Andrew Morton , David Hildenbrand , Muchun Song , Oscar Salvador , Michael Ellerman , Madhavan Srinivasan , Lorenzo Stoakes , "Liam R . Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , Nicholas Piggin , Christophe Leroy , aneesh.kumar@linux.ibm.com, joao.m.martins@oracle.com, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/49] mm: make set_pageblock_order() static Message-ID: References: <20260405125240.2558577-1-songmuchun@bytedance.com> <20260405125240.2558577-13-songmuchun@bytedance.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260405125240.2558577-13-songmuchun@bytedance.com> On Sun, Apr 05, 2026 at 08:52:03PM +0800, Muchun Song wrote: > Since set_pageblock_order() is only used in mm/mm_init.c now, make it > static and remove its declaration from mm/internal.h. > Signed-off-by: Muchun Song The removal of set_pageblock_order() from sparse.c should be moved here as well :) With that Reviewed-by: Mike Rapoport (Microsoft) > --- > mm/internal.h | 1 - > mm/mm_init.c | 4 ++-- > 2 files changed, 2 insertions(+), 3 deletions(-) -- Sincerely yours, Mike.