From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Cc: jikos@kernel.org, jic23@kernel.org,
srinivas.pandruvada@linux.intel.com, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org,
sakari.ailus@linux.intel.com, linux-input@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] iio: orientation: adapt to hid_sensor_remove_trigger() API change
Date: Tue, 28 Apr 2026 11:22:48 +0300 [thread overview]
Message-ID: <afBuWAElmx7t7FcB@ashevche-desk.local> (raw)
In-Reply-To: <20260428071613.1134053-3-sanjayembedded@gmail.com>
On Tue, Apr 28, 2026 at 12:46:05PM +0530, Sanjay Chitroda wrote:
> Update the driver to match the updated hid_sensor_remove_trigger()
> prototype, which no longer requires struct iio_dev.
You haven't compiled the previous patch, right?
This is not the way how all this should be done.
Also NAK to the patch 1 as even unused parameter is there for the sake of
consistency. The prototype to allocate and other in the similar group all
have it.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-28 8:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 7:16 [PATCH 00/10] iio: drop redundant iio_dev argument from hid_sensor_remove_trigger() Sanjay Chitroda
2026-04-28 7:16 ` [PATCH 01/10] iio: hid-sensors: drop redundant iio_dev argument Sanjay Chitroda
2026-04-28 7:16 ` [PATCH 02/10] iio: orientation: adapt to hid_sensor_remove_trigger() API change Sanjay Chitroda
2026-04-28 8:22 ` Andy Shevchenko [this message]
2026-04-28 12:06 ` Sanjay Chitroda
[not found] ` <39108D2A-3C3F-40B5-9A9B-5B3572A63922@gmail.com>
2026-04-28 16:12 ` Jonathan Cameron
2026-04-28 7:16 ` [PATCH 03/10] iio: gyro: " Sanjay Chitroda
2026-04-28 7:16 ` [PATCH 04/10] iio: pressure: " Sanjay Chitroda
2026-04-28 7:16 ` [PATCH 05/10] iio: temperature: " Sanjay Chitroda
2026-04-28 7:16 ` [PATCH 06/10] iio: humidity: " Sanjay Chitroda
2026-04-28 7:16 ` [PATCH 07/10] iio: light: " Sanjay Chitroda
2026-04-28 7:16 ` [PATCH 08/10] iio: magnetometer: " Sanjay Chitroda
2026-04-28 7:16 ` [PATCH 09/10] iio: position: " Sanjay Chitroda
2026-04-28 7:16 ` [PATCH 10/10] iio: accel: " Sanjay Chitroda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afBuWAElmx7t7FcB@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sanjayembeddedse@gmail.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox