From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 904FD3DE427 for ; Tue, 28 Apr 2026 13:49:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777384195; cv=none; b=nR+Lkd+RgMPHvwE3pm1xKfMLMT0WNDAbuq8dEGxPD2KOO8eaKkfErialkpwfyQw2yHp5YAnLkTEMfK+KZfrCFNuo9ECdnVT+3uCAYkd0O0vEtg9/kOfT9ESutJ80leLZ/SWsl4ejDDwFxWTM7RCyASMpSXkKSDBuMkpzLOuYB+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777384195; c=relaxed/simple; bh=i+nKcGjkS/5Tczt523KayzkEsOUyVHbiSfY3f11u3hY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=b2J+vKbo+e6fsGiivjcrAfmtf26BDNJhNpJN8q3uJtoQuKJRbN7TcJesQjsmk38bn4pC60TIii4aN40+e7dGKNmSONicFjXn21l/Gom9bFDvhdXxWZu2KG0JqGJ6qNt9+magy+G6U48lLQUycspiORUNX4OC+cJa1JRKWNoVcFk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pi5cKqt5; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pi5cKqt5" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43d0deb7ad5so9386972f8f.2 for ; Tue, 28 Apr 2026 06:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777384193; x=1777988993; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yMSrgBhN+mHfZpVt9bh3H6mTLY0wCmlOX7rIndgq/38=; b=pi5cKqt5VZ8OyWIWcOqAL4vWNV+C9+vbi7mV/wrjeeKIQnHC35ispLokP6YULp4fku vvEOg+H25XSVtwtW60Ox89K181iaxz1fyx2WDZYl5vKSWjBd13XGbU6ngp7Kmzm/o/ln 15tizZCKOI2nAEn1pVo4c+KuOQ5XkLFm+pZY7GCHnuZWytnI8E6GSMa0YRNhsddDN+SS ZEmfK4OghiZOPOWiC816YeM3rcqh5lM7cWsKzz4ekGQRjknLJds6DTfe+OClK+xois0f NpgPSh/mlI5HBZsaV/grbUewvzQf6QKGWoZCvbCS+BaxD329jub02EXkcLFTjVuWiS03 weLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777384193; x=1777988993; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yMSrgBhN+mHfZpVt9bh3H6mTLY0wCmlOX7rIndgq/38=; b=R5ATuPq+LouzqUCxsZRupxnZmlA+qiL0pBphN2t3B0WP6byHoddL+cVm0rCzrX1LvQ 05fxUow8z3PpL6O7zEKBeQ90duBgIn+ZmKwsaf43E7++Kte9LraNNrfo8imVnH4DKPt9 ewMU8cUW8YV2TF1IMbhrKnoljOpJeqYWQq8vj5WZ0ga74FEnurJIQ8kkx8yB13BJA7Fp Yq6BRUv5+nMDr7KDg1v+AhBsl5cVUykZxYq12tecn7V5msLypF1WfLubsXNlo2qGGIg5 S6WITiSI6Oucm0jceTFKscAhToxzIXaQ3sMy3hOji0hCDGG5sUGXCWhQT4mXJYpWFVuK 8r1Q== X-Forwarded-Encrypted: i=1; AFNElJ9FphRhNhSJvnT7WqQgbzm9tEe91VIcG82UjViZTUpnIsSikawDkkwZ1j5Pbzpn/4RMFLg1Ic8uQ9xVx1Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3of3LwB54QTI2mSLWOoWpEkbTNdEVij1Vkw1Fkm6b+pb8FUVo kXiA15NUxoI2j/eXUG6A1pes9+wNMtvoqUmV239GmOAPLdjJQwUSKPoz X-Gm-Gg: AeBDietKoCkJkhFL4DST96Vxi1ws5YNxxBYDMnz0QPMcYD1cl7vcMCsG0OTp7x7Btca XH/7TKJ3BVkeJlbJeC3C9Hb5crUMrPZBg2j89GdXOJ1km85fabVuHzEp84vrUOfjqow8jxVxkM+ mKPtlGsSl3s3/udybCkpZn6MoNqCAvPwOEXX6VgCFa6ex4tNSmQOkllMGwGWRCFZL70ZvcJc27o pmw0oCTiIYK2LtYxjkJDoRTHlxirxwKAM61dcG5btb7Xj5HRuKen1r9O7Yn5oBpw+9b/T3DlY6P KvnDxistO8Cvfr1Tt5Qwzl2+YhIB/UA4Q9A/gLkK9KAJJXHawj0ObXNu9ItwKA/841h9FcmKnbx bFSWtfCfMcj/AiaIzsvsKyF6iJMeuyrcyw2k9epoQcG3Ev0Wb2ieK7J5aBIxHxQvd6nLPS47pkF oA/ybPJmV/DACq+XDnlTZxz8/t0uQFIg== X-Received: by 2002:a5d:5f96:0:b0:43f:e413:e5ad with SMTP id ffacd0b85a97d-446448b87f3mr5644612f8f.0.1777384192756; Tue, 28 Apr 2026 06:49:52 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4463f994a3fsm6535789f8f.25.2026.04.28.06.49.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 06:49:52 -0700 (PDT) Date: Tue, 28 Apr 2026 16:49:48 +0300 From: Dan Carpenter To: Edward Cree Cc: Alejandro Lucero , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Martin Habets , Jiri Pirko , netdev@vger.kernel.org, linux-net-drivers@amd.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net] sfc: fix error code in efx_devlink_info_running_versions() Message-ID: References: <0dd0c884-c846-4f17-986d-fb24b21a836f@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0dd0c884-c846-4f17-986d-fb24b21a836f@gmail.com> On Tue, Apr 28, 2026 at 02:36:55PM +0100, Edward Cree wrote: > On 25/04/2026 10:09, Dan Carpenter wrote: > > Return -EINVAL if efx_mcdi_rpc() doesn't return enough space. > > > > Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100") > > Signed-off-by: Dan Carpenter > > --- > > drivers/net/ethernet/sfc/efx_devlink.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c > > index d842c60dfc10..45f412bb9b5d 100644 > > --- a/drivers/net/ethernet/sfc/efx_devlink.c > > +++ b/drivers/net/ethernet/sfc/efx_devlink.c > > @@ -531,7 +531,7 @@ static int efx_devlink_info_running_versions(struct efx_nic *efx, > > if (rc || outlength < MC_CMD_GET_VERSION_OUT_LEN) { > > netif_err(efx, drv, efx->net_dev, > > "mcdi MC_CMD_GET_VERSION failed\n"); > > - return rc; > > + return rc ?: -EINVAL; > > } > > > > /* Handle previous output */ > > Usual practice in sfc is to use -EIO for 'MC response was too short'; it > signifies misbehaviour from the hardware, not any invalid input argument > as -EINVAL would suggest. > Other than that, looks fine. Sure, I'll send a v2. regards, dan carpenter