From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C4FB73D5252 for ; Tue, 28 Apr 2026 09:48:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777369716; cv=none; b=tZyMIxaROo1dih3ulPoOStIJENjPddimvgxlYg2A8LjIRCdx+q/yAT0whFuI/ziW/aOH36wTXpjdTmmq5h0RoBnD0+W5KI9UBX/PyiXVyAxlX4zmABks+ZDLS3yJj5/MTMBT4vPg40oMcmyE6gb0d6TiEInxc94fUcnJnAXsTtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777369716; c=relaxed/simple; bh=W8HGzQJFGOvOk1Wnj506pBzw5Rf/xaX4Wio8E6icdxs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KIKY9HZDT2fIIIhQIwH31k6qfYPmMP1bVfaZc4ZzMfualC8jiDRWIY/pJFeiXEJgPmheSUGFyPK0JjjAi7HLGMv03SNKPF0jMh4+RxWRWZmzGEWZCZ59AGZiZfTzzcKBhrcwl13qXrt8b1Lk5SovFh/Gdzng/tJQJwsgBe1Wgsw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VnM3nh74; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VnM3nh74" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-43d0deb7ad5so9182991f8f.2 for ; Tue, 28 Apr 2026 02:48:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777369713; x=1777974513; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qO9AMiD4sJRw4hR2b81vFZ+0BepqwH69J84Nu4gaIE4=; b=VnM3nh74NQBcMW6RMAWBzTVodvm/43hojmR8GMC0WOB1UkbSKd5jhT40ipH7AXxkOf jP107Hy3Gs+lcqKcf5i9/a9iKPFQQPhPiWxW/nAr7pj31R2ZGB/cSzVi0IdjZL2Ej1Uy dZQauPPU9b7Lq7jRd4rtfhpbURKXYx+Ab1fxTH4fnRrHDHfxWZ0G7fJSAOA2UdvS0t2q THIdujf1lAq3wNpNDIr+FQR1MPnlI8zKC0fobqUZ3SNTQSKYUteSJs/DWZSV4oGjTeE/ D9tIyMytCR3HbL6x3K65TrxKFlA348e5hMrg9/cqeiaH17qkZz1WkotnSkrOTYXbPSBB 8rOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777369713; x=1777974513; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qO9AMiD4sJRw4hR2b81vFZ+0BepqwH69J84Nu4gaIE4=; b=mAZVkIb+rlEW+2L3N6q6iXSfCCx9ysMQdFJbEQudDHKKMoKpXI7Vi+eQMQDlUZVWK5 lvnURaQHjIzcEbFwvajc05DD7rp6Z/jzWUm7R5Ea7FKY0DXmW6zReVZgQ4OCacu5UQPJ g2BdX+t9qND9z54hpChVFXZaSsUAGafIORh652JeBowDLloa+aK6A+s3FVr6A5o8WNnz 11nwLeqNSSTSyS3CBk2Ah7WaNDC8vxhqdQVuj8hBnUypeYoNAHaKbZK8OE+1z57XptPm rdyjjIBri3yDiWdr4oF0cCMxnKjAV7t8Mo948784hB9L99ageA51WZko3jDO78BZYHZ+ Gp2w== X-Forwarded-Encrypted: i=1; AFNElJ+rhEbybwOAClPM3u1lAKawiReFpAWClL/pafSQyEtSYK3Zv7VEJ8EjqB3o451vG67TksbJ4K/khjIM8b4=@vger.kernel.org X-Gm-Message-State: AOJu0YytuWTi0C9FGGNZLWy7Twjrc2fXNY+lUcH7QS1TjJ/5cdueQhjx 6CDxP7Nfnq8Lwb2g40cBwff87PI4YCy163J60OERHdVozDbQkYwgdWrP X-Gm-Gg: AeBDiesCCVfxIcsZVb1LMp2uAd8rZ7cjuk0QW4WthNX3x5lU8Fs9plD42hbsTI2tFna GwrvD7RbAlv3PK6URJwF1TlIeP6jk+1+y0k/x38qWP+ZGptFW61wutg+W+nhqmBeowYQRBoYtSF meWDDCjpaK3qIrIdVmQ6q0xC8HB/A8EpdDlSDx1hJXlnMDP1ktM6uJw+uf67aJnsQatjpdLd4el iuMN+7i4I+ZFLjBsV750M4sg7KjyBYR/4P4BQFLCPCEyFYDDdFi6+7PmBkoqDAdiMGVgr2CMGdo rpGqkRFaYwxYxlxOMDInJASt0lV+ljIrmttGeS3fECVaaVWDm+VFEiLAlLUN/1B171WQNC0axwA jAgaFCm5e1Lu2a0D/EfkjQO8fkP26s8aumgbH9d+5q8I14zhX17rh9UkteSHUrp4ioMKtdX7Nqf cmfeE8mXmXFmzVsQ1rM0MVYtI3DsP31w== X-Received: by 2002:a05:6000:2212:b0:43b:8f4e:27f8 with SMTP id ffacd0b85a97d-446481b01e4mr4140361f8f.12.1777369713097; Tue, 28 Apr 2026 02:48:33 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4463fa890a6sm4622204f8f.30.2026.04.28.02.48.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 02:48:32 -0700 (PDT) Date: Tue, 28 Apr 2026 12:48:29 +0300 From: Dan Carpenter To: Ayush Mukkanwar Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 4/4] staging: octeon: refactor to per-device state and pass platform_device Message-ID: References: <20260427151556.91153-1-ayushmukkanwar@gmail.com> <20260427151556.91153-5-ayushmukkanwar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260427151556.91153-5-ayushmukkanwar@gmail.com> On Mon, Apr 27, 2026 at 08:45:55PM +0530, Ayush Mukkanwar wrote: > Move the static oct_rx_group array from ethernet-rx.c into the > octeon_ethernet_platform structure to associate receive group state > with the platform device. How is this related to logging? > Pass struct platform_device instead of > struct device through the ethernet-mem and ethernet-rx call chains, > extracting &pdev->dev only at the point of use in dev_warn() calls. You're undoing something that you did in patch 1. Just do it correctly the first time instead of doing it and the fixing it in the same patchset. > > Move struct oct_rx_group and struct octeon_ethernet_platform > definitions into octeon-ethernet.h so they are shared across > compilation units. > Btw, here: > + struct octeon_ethernet_platform *plt = platform_get_drvdata(pdev); Could you name it "plat" instead of "plt"? Generally "plt" is an acronym for something else. Procedure Linkage Table or Phy LED Trigger. There are a couple other meanings. regards, dan carpenter