From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CY3PR05CU001.outbound.protection.outlook.com (mail-westcentralusazon11013003.outbound.protection.outlook.com [40.93.201.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3292441323A for ; Tue, 28 Apr 2026 13:17:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.201.3 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777382233; cv=fail; b=bVbVgfQmKugoNFI99nl2P644JQ0uYAU6fQfNex7srzJ4dnmf7z7IEp1ERA7UDPowSU1vA2MQvUt4VMeobMpn/ElZcf5xHohmtaRX7juSlwrGyZMNo0YL+H2wu0AdZaQtf7pzcKcx05Dr+ZdbNAYdFf9Tew1vSdy85e65Ll6pi/g= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777382233; c=relaxed/simple; bh=+Zgtr4ixRwqFtna1D/wB1dPj61l9qJknqzoW0LqEh3Y=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=A75Yo7ovmtJ9yiZyhzBndHTcDKWLMzrN7ugm3y2o2ZQ3Mffa3kw5PMA7W+GJlppJPZ8CcWrm7k2uz8OQjyGhvdPCB6Mcwu3fsvO/1iS8oCb5ge9vh1ldca8ma0IfQbkSsVDZQsCJ9viwi5UFE0H68SEeXsHBW7XkN3dt9VWrABA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=qY4mhW6S; arc=fail smtp.client-ip=40.93.201.3 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="qY4mhW6S" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=INs0NfM7EUXOnvgcsdyjbjc/gsZGjq1MTWeaz2/wa6Ak74cKPqmG6LQv4RKt8YMxuz8gY1XAUHcl0QLpEaifTWRru8U+vlv33hsV/wPjXE5kmx7KxdwW5rmRtKqbl7lOqE4B9v+w+6kuPpajHwGKKnJjsd+j0YCw0K4jAC8+UiMK3BLSHcoAv1D+eLVzAQnu8KjBHVCZDql1ldX2QVTCpzhfzEkiIXX2O5wvHzTpAw+4iG34E82Rkw+5W1rid3P3UeWo30n9NZN0WUcyKPkNvmSyDbOccSsstDQQOWuADeG5Gov8GP7DN7MDmS4xMXMgrdLD8qPe+KCky6VgdRkk8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xlxQckoWCgSY3i96HsDqle4dP8A+o6ybkFTY7hJPTSY=; b=Jfp4Xci8Uzy87P3VFvgzjZx4W8xuRRCKFIuskYajDHk0yDiKRxJR+qOcUTzj9LdYanyTk1LRKWTqnTKD+vNwV+kve1H3fqmc6iNYClthBqUvNnXwlSUMTz/3d+ZZduCdZp70Ps9auaw9PWhpVO23pcZ4GAyEb96g5Cp7VawS452R1weR2VoOSZh3GjbESvEq7v/ZZ1NA+jdILHMqGMDJyyK5tiT9evFB3XNOEr+GGpG3KdK2uSIejfK1us+wN0iWPLaAtAj3cNcNaSEy4g9tmmDeDHgdnV2MF9x5UgtGgxnipcBtentinyYPEo/4MEIKbNdWPl2HmacFqO7jdaRmUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xlxQckoWCgSY3i96HsDqle4dP8A+o6ybkFTY7hJPTSY=; b=qY4mhW6SivN9Q2+Sp/Ly3VQsWmVDJFyRS8W86vyOa+27dYekxuzekpik5ik8DZOosTrU2ndrVqtUItFS1yqX1WgUBtBr3eox3PxnYgk+W0GIC3BQn36CIVNnyUdrs4jHVlmEixSnfznzGHqvCacbHr5EFwjqc3rFYI9XmrUo64jvZZ24zZL5Cq74vx0I2R3aSOf95dMxePbFGLKw0hhd51niYq3XwvXvoVbUjHGZEgH3VJxHiTtD4NsHzdJi2sgyezfV4vfDI623WUyK/uO+m2LOSRcoGFbsprg+bZsa36uWOZ1FGa4w3BhzQDYC5al+yVD8hyMBRfWddBsE2cFbWQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by CH2PR12MB4327.namprd12.prod.outlook.com (2603:10b6:610:7d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.20; Tue, 28 Apr 2026 13:17:04 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9870.013; Tue, 28 Apr 2026 13:17:04 +0000 Date: Tue, 28 Apr 2026 15:16:53 +0200 From: Andrea Righi To: Peter Zijlstra Cc: K Prateek Nayak , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Christian Loehle , Koba Ko , Felix Abecassis , Balbir Singh , Joel Fernandes , Shrikanth Hegde , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] sched/fair: Use guard(rcu) for sched_domain RCU sections Message-ID: References: <20260428051720.3180182-1-arighi@nvidia.com> <20260428051720.3180182-2-arighi@nvidia.com> <0882ce78-a51f-4317-a1b4-624e39e65507@amd.com> <20260428115017.GW3102624@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260428115017.GW3102624@noisy.programming.kicks-ass.net> X-ClientProxiedBy: ZR1PEPF000077E0.CHEP278.PROD.OUTLOOK.COM (2603:10a6:918::40e) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|CH2PR12MB4327:EE_ X-MS-Office365-Filtering-Correlation-Id: 3288b903-30d8-4813-20c9-08dea5287079 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|1800799024|366016|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: qfLtCAVXPrzKI2u8PlUTa/HEDTY/3lHSDjwLYTUpeIvFys9ncYK70urDHNhfDBaC49FUFxQQG2gm2j+rXawPROjXpStp236Uv6rwxRNdb89k0twV4fpeAvaxOUOcL7cEefy7qyI4klAZNItWNmNnWsZaktQ1rQUw3fDdkFH67Mi/+KgJDl3SaHT4TuM0GMMAxOfO4hrSX6oOSwnD+aX/67nFxkBzXgJoJC1qjdZoV5hwuCNK8+icTTV0iGdmRqPNn1W34oN0ndqsXSLKzTiVUt/NZPsT6+dY9nswC2V61E00PVW50tUNOIi6lpnYmafxpIRrQT2Rb0X5bw7wjCCA35rAHBeBCAUCZjBuVZ7G95Qj7y+eJyncPlzscTD9YcSy/EcDtxrSmDQMy7Qbf+TawElesk/wnXoERdaUaVZB0MBpWU6FEBAOu8zkP8HlSFExgta57f5Vup04/jvNB/KBkDBDof36TxcSrvvsE1M0aZDhH4K4WoTadhfqazx0LUUwFW8O0nVO29vBtwVnRsivQ1znhlj/O4JBF26ef5fTBl5v9VVzrOCylC9r8MoHsRcbbmSBdvUts656VohEHEOUmImtF+8L4ZDrxllBYvn6ZY68O8OngLg8jIkSsab79orZv1FcU6TcG+eq57PiU92Kas3pych7ijYJsz/nz0ujWqEZOvgnm9Pq1Qlg9BLAZOf+vJmYsRqj2hOq/+sF4q3d1kLossIBMJj8phxYieje85Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(1800799024)(366016)(56012099003)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5Pv8y2Hjo9spg+p6DCUxk5DMQl3+8BmYhp2fVRlyB1QIX0iCIqJUIrhlcSQv?= =?us-ascii?Q?ckI0EzIfM7kPwNmmwyRxsps0VVrXl+fggl5CWpndqDtPXkz/V9vAtVpz25V1?= =?us-ascii?Q?siw/GofWuXmrdzylzVP9xa1e9DaC/cOawfsNUprYDoLaDvjRBLdllKZYvv5A?= =?us-ascii?Q?xyNMDM+92Jeq9lrs941BjQVbaX9WevQoaTt2oKOzNs+k8HVB+oMQ8Wz7TTr0?= =?us-ascii?Q?BwdHNSqXzQeF/+b8N4EOX3pch+6eRCokeHg8if9cRmSCyHHapGstBLDNnjQR?= =?us-ascii?Q?t49SHI7CEJDIOKY7oE14CddVrwW4OTDWppIMxnzDNerg9AlWtmvahVj5WgBZ?= =?us-ascii?Q?QGpRsUfmnRX3x92nsHDFwoSUw67eCM780BuJnPh5ZWGMEVUy7kQmPt79PCwk?= =?us-ascii?Q?zGA2cBiBqZi62m3iZfpiPpGtxZg4xHZX+OcUZtzdX1VBvxBH8fxk/gIBsClg?= =?us-ascii?Q?jkxM2Bust/pv8D8qsvSghs39JIdEPnz8THBQp1LQDMoXXLVqbGMYyuIo6jrZ?= =?us-ascii?Q?Ro1dqDEDwo4pPMaKL/DiIpjLlSOaspDIeu+Lbb27QEdPwdkoK+qGA+bSKvkx?= =?us-ascii?Q?3c9g8gdU14W4Q178tfXYVVVfIonJIHKKCapmDiQl2cPM5AxSXvIcSUFrES/2?= =?us-ascii?Q?y6uAQPkfD/7rxWzxizKSVMnTkax1tcw8M+CmcwZTQrPyCjpkrtnqlIeksvQr?= =?us-ascii?Q?Oz2A3+lmPBPAmAtUDhuuG3OHV5tot4j+YpMp6BHz7HlpCJl+zsVcNmttz1mn?= =?us-ascii?Q?MKHuiC3+BXqZ9UEObn0sI+IBoMaBEbpR750dkvbozL+6jfbM4SylD7h6wTUt?= =?us-ascii?Q?g3/h+xY3woKuTzvlSFqwR2g4BZnSoYH/ZPb35006AWqPYxPe5E9A3iRdm/V/?= =?us-ascii?Q?BUSmAQ5lxuVwhTm7ajeNcAteb2KhFsXrBnTgFC3DqHNHwOUrtgsL2gQ5g40R?= =?us-ascii?Q?4CJCc4hlQ0cnzDWdK6H65K44kKSbgkdPq7ELQt9tbUo1Y6/MJxH6y+7/JmCR?= =?us-ascii?Q?GAY0g+rI8UXkpqxivpP6XuH2o0LenkWb2NVa41Z+hLJnuE9MTavyly32k9aS?= =?us-ascii?Q?ADdGow3jR5dMXNwmckXCrJQ8aMJSe2NejUkOXhNWhTd56nEEN8CZdZel1Jkq?= =?us-ascii?Q?p88/NNvFQALfAjpLd/ZTZMn71ozynC7X0TDWD9+hAJsrBFFuhK/1GFziG6gd?= =?us-ascii?Q?ZH8XiJQ4bM+AdZ/uS8UB5f5Lo+JUC9evxHcb134fL51fuOKILVUGAghPD/8E?= =?us-ascii?Q?DeUB6mX7FUVurr+FusiSwzD2ujFkGujC+94B8tORzJ7Ldrs9EUwCvpIzzy48?= =?us-ascii?Q?qTFgEAV2x4hRYv+Zbl9HZF5YM9mAZfOvegjagT+1qdaD9LjcvZwr8ZvX0gNN?= =?us-ascii?Q?YZCM4XN7Bwg1CkPbCcIc+XSkRmgJoLEbMb0MNt3Pb5Bq0Up/hehCbdRlZAVw?= =?us-ascii?Q?m4WLhb27qzDlLl5n4ZG4+TMyWmGrRkWrX97M+ofDo5xkZl394wv5iXT+wfLh?= =?us-ascii?Q?5ngNCDzXz2Kj1PXVwyk7be0qvW+je6K0cFDcZS/WSkSAjzYfHQSK0c7ui733?= =?us-ascii?Q?RFrXtrfr9WpdwNSA+ySbYB8quGUS+xXfKbBZTJefML8JMKOgJvqO1jQQcW7h?= =?us-ascii?Q?6VjW4mVcqVjzEEhJf8VsXRxFuZIXAvxi344Zr0LI4r79hayLtZcg8226t/yg?= =?us-ascii?Q?2sC5haJqQ1lHEUBx0wi8oLXZdA4Xck4Ie/PSa+Vz3h1wgOF0nHKUXox7ZT0K?= =?us-ascii?Q?9/QGYCPJjQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3288b903-30d8-4813-20c9-08dea5287079 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2026 13:17:04.0402 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NfrK7InG60Zla50Bneq9IaxipeXcnGgbYm2TBNoqoJei+pOP5BacQyEkzpdw9ZTTim1X5BulYaOnDFiYBQwXcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4327 Hi Peter, On Tue, Apr 28, 2026 at 01:50:17PM +0200, Peter Zijlstra wrote: > On Tue, Apr 28, 2026 at 12:43:22PM +0200, Andrea Righi wrote: > > > > and since this is only called from: > > > > > > sched_tick() /* IRQs disabled */ > > > sched_balance_trigger() > > > nohz_balancer_kick() > > > > > > with IRQs disabled, we can get rid of that rcu_read_lock() entirely. > > > > Yeah, all makes sense. I'll update the patch dropping rcu_read_lock/unlock() > > completely. > > > > Is it worth adding a lockdep_assert_irqs_disabled()? > > I think the rcu_dereference_all() thing will go scream if it doesn't > have any of IRQs/preempt/rcu disabled. Ah yes, indeed, I'll drop the lockdep_assert_irqs_disabled(). Thanks, -Andrea