Re: [Intel-wired-lan] [PATCH iwl-next v7 14/14] ixd: add devlink support

[Larysa Zaremba <larysa.zaremba@intel.com>]

On Tue, Apr 28, 2026 at 10:53:47AM +0200, Loktionov, Aleksandr wrote:
> 
> 
> > -----Original Message-----
> > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf
> > Of Larysa Zaremba
> > Sent: Tuesday, April 28, 2026 10:27 AM
> > To: intel-wired-lan@lists.osuosl.org; Nguyen, Anthony L
> > <anthony.l.nguyen@intel.com>
> > Cc: Lobakin, Aleksander <aleksander.lobakin@intel.com>; Samudrala,
> > Sridhar <sridhar.samudrala@intel.com>; Michal Swiatkowski
> > <michal.swiatkowski@linux.intel.com>; Zaremba, Larysa
> > <larysa.zaremba@intel.com>; Fijalkowski, Maciej
> > <maciej.fijalkowski@intel.com>; Tantilov, Emil S
> > <emil.s.tantilov@intel.com>; Chittim, Madhu <madhu.chittim@intel.com>;
> > Hay, Joshua A <joshua.a.hay@intel.com>; Keller, Jacob E
> > <jacob.e.keller@intel.com>; Shanmugam, Jayaprakash
> > <jayaprakash.shanmugam@intel.com>; Jiri Pirko <jiri@resnulli.us>;
> > David S. Miller <davem@davemloft.net>; Eric Dumazet
> > <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> > <pabeni@redhat.com>; Simon Horman <horms@kernel.org>; Jonathan Corbet
> > <corbet@lwn.net>; Richard Cochran <richardcochran@gmail.com>; Kitszel,
> > Przemyslaw <przemyslaw.kitszel@intel.com>; Andrew Lunn
> > <andrew+netdev@lunn.ch>; netdev@vger.kernel.org; linux-
> > doc@vger.kernel.org; linux-kernel@vger.kernel.org; R, Bharath
> > <bharath.r@intel.com>
> > Subject: [Intel-wired-lan] [PATCH iwl-next v7 14/14] ixd: add devlink
> > support
> > 
> > From: Amritha Nambiar <amritha.nambiar@intel.com>
> > 
> > Enable initial support for the devlink interface with the ixd driver.
> > The ixd hardware is a single function PCIe device. So, the PCIe
> > adapter gets its own devlink instance to manage device-wide resources
> > or configuration.
> > 
> > $ devlink dev show
> > pci/0000:83:00.6
> > 
> > $ devlink dev info pci/0000:83:00.6
> > pci/0000:83:00.6:
> >   driver ixd
> >   serial_number 00-a0-c9-ff-ff-23-45-67
> >   versions:
> >       fixed:
> >         device.type MEV
> >       running:
> >         virtchnl 2.0
> > 
> > Signed-off-by: Amritha Nambiar <amritha.nambiar@intel.com>
> > Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> > Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
> > Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> > Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
> > Tested-by: Bharath R <Bharath.r@intel.com>
> > Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> > ---
> >  Documentation/networking/devlink/index.rst   |  1 +
> >  Documentation/networking/devlink/ixd.rst     | 30 ++++++
> >  drivers/net/ethernet/intel/ixd/Kconfig       |  1 +
> >  drivers/net/ethernet/intel/ixd/Makefile      |  1 +
> >  drivers/net/ethernet/intel/ixd/ixd_devlink.c | 97
> > ++++++++++++++++++++  drivers/net/ethernet/intel/ixd/ixd_devlink.h |
> > 44 +++++++++
> >  drivers/net/ethernet/intel/ixd/ixd_main.c    | 16 +++-
> >  7 files changed, 187 insertions(+), 3 deletions(-)  create mode
> > 100644 Documentation/networking/devlink/ixd.rst
> >  create mode 100644 drivers/net/ethernet/intel/ixd/ixd_devlink.c
> >  create mode 100644 drivers/net/ethernet/intel/ixd/ixd_devlink.h
> > 
> > diff --git a/Documentation/networking/devlink/index.rst
> > b/Documentation/networking/devlink/index.rst
> > index f7ba7dcf477d..f0c077843fa7 100644
> > --- a/Documentation/networking/devlink/index.rst
> > +++ b/Documentation/networking/devlink/index.rst
> > @@ -88,6 +88,7 @@ parameters, info versions, and other features it
> > supports.
> >     ionic
> >     iosm
> >     ixgbe
> 
> ...
> 
> > --- /dev/null
> > +++ b/drivers/net/ethernet/intel/ixd/ixd_devlink.h
> > @@ -0,0 +1,44 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/* Copyright (c) 2025, Intel Corporation. */
> > +
> devlink.c  has:
> > +// SPDX-License-Identifier: GPL-2.0
> But devlink.h has:
> > +/* SPDX-License-Identifier: GPL-2.0 */
> 
> Why?

Because source and header files require different license format.

> 
> > +#ifndef _IXD_DEVLINK_H_
> > +#define _IXD_DEVLINK_H_
> > +#include <net/devlink.h>
> 
> ...
> 
> >  }
> > 
> >  static const struct pci_device_id ixd_pci_tbl[] = {
> > --
> > 2.47.0
>