From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AF483A75BB for ; Tue, 28 Apr 2026 15:01:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777388509; cv=none; b=X+OkTQQlbWzFCrQsneiGdw4hz49AclqeYFT9mwmgJ5mrfFoDOSQ+gT5DfpTK/tg7pjvievfr/36DkFfgQ/cEb9TgLXw2IFlKr1sDdERdl5ivlHyGlvZE34WuSgkMRBHrhdvjksBjCO3p7Lfpj+/LUwGJnox5+0B48GDYusZtO9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777388509; c=relaxed/simple; bh=qJer4Z07xwMH+A78Ib0ymUPGWZ+mNnYVbTFhj6WGO5A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DAPS6kVJu68wktCYBcEzlv0GHxAFX2s7a6uR6DgOQWEA704JEWlTJkw/pi+aYlD40P6u31zmETf4XnkhkWGIBwMEc0fvoJHkLOQOJOMH1euqGq4UvGvJQq9olAf/Uj32OHnFewPjwr8WDpwQzQZ/qsEmQkVhkRTq0dRZjF0GzxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rcxKsGoH; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rcxKsGoH" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-ba6838e76f2so1194886966b.2 for ; Tue, 28 Apr 2026 08:01:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777388505; x=1777993305; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TD3g81YgYyk+ev+8kkfCadZc9PhNHKB3ZIvkWb2+QeU=; b=rcxKsGoHWww5RWld30JP429/9DnmUPbPhP9s3JQMZUZMVmGUxjM5+KOSZe8QH5h0M4 P40o5OfuXgNeYLZEkVFho1l9yOmpk/31nNo3IClkrFSrhUgxgQFGg+xmRat1Iuwiebsb VBEQ7+6vYiyimISXAd40q1kdaEebwMMLHLytbN4auGL8LvjJr/5WwROUA2n5CRzDqNHY LL1j1XF0aaZZRwtZ4zBw88k9YQQ/2/P4GO23nKyIkXsxDZ3AYJdEL7uuj9GbSCCyPMHp v91nKIaDFoe6xFXyV2khgNX9oQtsff0NGoQL3Wtg1suJS9PwP9S8ynjE/ULHdNJijLXc T8BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777388505; x=1777993305; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TD3g81YgYyk+ev+8kkfCadZc9PhNHKB3ZIvkWb2+QeU=; b=mlxBCVUqGb6gC8bhzDmSdw7Kff+N/uM8JBzuB8hJd4ob6oN9jzTi/Q6RQqhOmSH5C7 yVLtdV1RpmDuh5nhyUM43SjO0YqO8Y3IdYm/kgZQHuGJD7ISSOA9txO1HbkUNUyInx53 QBq94rteOEUJA0F3/biSLK8QHlLNtDxRDpsH/DJ/xmj0UZZLFhVmudlFKrbBWM3DzWqh QULQoYeGDxZojggdzzXVYbe86WCX15bK4TCsQdRNHayRnu8fOAyAx8IfswOOsnhYh7De 3ShSy2AB5HqOnPxKRpNUvyjOIN0raKOvMAfcj/scyE6ONOV/t+QY0EWS1tM+6xQBgUVD Efvg== X-Forwarded-Encrypted: i=1; AFNElJ9QBntdPfN6bfW3EtHQySK7haT2RMRiYpfgxM/wWbPzbsKJxvaN70MjMkjxrHQPuS1XLliPDwH7HG+oeQM=@vger.kernel.org X-Gm-Message-State: AOJu0YxnxzYg4Uvy0DUTTZgmgDlRoRQmxNxS0fZ3SzC6BDEnwHEqW53J vq3zG4DTgMWmCJPZmbuqCrgR582r9peEYJRqsd6fUfm3em8erfkvnfcW X-Gm-Gg: AeBDievs/smDTbez5WHg9kpZWiaWn7uFBBEqABsVFVezxWr0hilJytjWOtTwhsz5LqE FJXhWCg7iitRSRWxzYfehp3KDrC2tgGJYOeJt3tRpq5PkT7J2VOslWl+91DYdBgH1VVHqwLuYdN jdYITYxnnB6pEV/xqfaYEKhtoMIuiIZ3KMhFe6GPk2Iudqui9ZpOt+Umzd+q6fOC2IcckY2scUu EDRUf7GcW9Cbo9P3f/HEly2mwGaW08cwU96KSofPGZYAip+mF2bmx7TfrUf3CdciPpHkKF16Cmy m3Tnd7dO3Grqum7BDwXhdx6NbNIyPZSVyvlijltjmnsua9pwMaLquDe5A1Gv824Q8ySsIf4G/zc CklXRqi7VMkN+9KCOydgM+IDJTMyeFHhPJJ3uCuli6ECh67HCSFdJV/YPN+4/RBmVP3dNpot7Lx t5np8dRjKL9fk6RLsG8NYRANQXt98jDJJFwaJ27ZFA X-Received: by 2002:a17:907:3d45:b0:bae:70db:91f5 with SMTP id a640c23a62f3a-bb803e5c931mr212259066b.35.1777388504521; Tue, 28 Apr 2026 08:01:44 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bb80ba9b8c8sm110829466b.48.2026.04.28.08.01.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Apr 2026 08:01:43 -0700 (PDT) Date: Tue, 28 Apr 2026 18:01:39 +0300 From: Dan Carpenter To: Przemek Kitszel Cc: Jakub Raczynski , netdev@vger.kernel.org, kuba@kernel.org, intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v3 net-next] net/intel: Replace manual array size calculation with ARRAY_SIZE Message-ID: References: <20260428103653.3539239-1-j.raczynski@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Apr 28, 2026 at 04:06:48PM +0200, Przemek Kitszel wrote: > On 4/28/26 12:36, Jakub Raczynski wrote: > > There are still places in the code where manual calculation of array size > > exist, but it is good to enforce usage of single macro through the whole > > code as it makes code bit more readable. > > While at it, beautify condition surrounding it by reversing check and remove > > unnecessary casting. > > > > Signed-off-by: Jakub Raczynski > > Reviewed-by: Dan Carpenter > > thank you, > Reviewed-by: Przemek Kitszel > > (next time use "iwl-next" in the title, no need to repost just for that) > Which sub directories go through iwl-next? I was trying to update my script > > > > drivers/net/ethernet/intel/i40e/i40e_adminq.h | 2 +- > > drivers/net/ethernet/intel/iavf/iavf_adminq.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) but look at these file names. There is no "iwl" anywhere in the names! :( regards, dan carpenter